Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi scheduler name for scheduler and webhook #2393

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

jinzhejz
Copy link
Contributor

@jinzhejz jinzhejz commented Jul 29, 2022

#2394
Signed-off-by: Zhe Jin jinzhe.hit@gmail.com

Currently, volcano support multiple scheduler name in controllers(#1792). This pr is used to support multiple scheduler names for scheduler and webhook, include:

  • support specify multiple scheduler names in command line
  • filer schedulable pods by multiple scheduler names
  • use volcano as default component name when specify multiple scheduler names
  • choose one scheduler name for volcano job in webhook if the job's schedulerName is empty

Signed-off-by: Zhe Jin <jinzhe.hit@gmail.com>
@volcano-sh-bot
Copy link
Contributor

Welcome @jinzhejz!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 29, 2022
Copy link
Member

@wpeng102 wpeng102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wpeng102

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2022
@volcano-sh-bot volcano-sh-bot merged commit 0e6b9c8 into volcano-sh:master Jul 30, 2022
@jinzhejz jinzhejz deleted the develop branch July 30, 2022 02:12
@william-wang william-wang changed the title support multi scheduler name for scheduler and webhook Support multi scheduler name for scheduler and webhook Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants