Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multi-scheduler for k8s workload deployment, etc #1792

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

huone1
Copy link
Contributor

@huone1 huone1 commented Oct 16, 2021

Signed-off-by: huone1 huwanxing@huawei.com

set deployment volcano-controller scheduler list : volcano and volcano2

spec:
      containers:
      - args:
        - --logtostderr
        - --scheduler-name=volcano
        - --scheduler-name=volcano2
        - -v=4
        - 2>&1

kubeclt apply deploymentA and the podgroup should be created

apiVersion: apps/v1
kind: Deployment
metadata:
  name: deploymentA
  labels:
    app: deployment-a
spec:
  replicas: 2
  selector:
    matchLabels:
      app: nginx
  template:
    metadata:
      labels:
        app: deployment-a
    spec:
      schedulerName: volcano2
      containers:
      - name: nginx
        image: nginx:1.14.2
        ports:
        - containerPort: 80
kubectl get pg
NAME                                            AGE
podgroup-7be41a1b-78ee-477e-8690-2a79a284b5ca   5m7s

kubeclt apply deploymentB with schedulerName=volcano3 and the podgroup shouldn't be created

apiVersion: apps/v1
kind: Deployment
metadata:
  name: deploymentB
  labels:
    app: deployment-b
spec:
  replicas: 2
  selector:
    matchLabels:
      app: nginx
  template:
    metadata:
      labels:
        app: deployment-b
    spec:
      schedulerName: volcano3
      containers:
      - name: nginx
        image: nginx:1.14.2
        ports:
        - containerPort: 80
kubectl get pg
No resources found in default namespace.

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2021
@Thor-wl
Copy link
Contributor

Thor-wl commented Oct 18, 2021

Any background for this PR? @huone1

@Thor-wl
Copy link
Contributor

Thor-wl commented Oct 25, 2021

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
Signed-off-by: huone1 <huwanxing@huawei.com>
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
@volcano-sh-bot
Copy link
Contributor

@huone1: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2021
@volcano-sh-bot volcano-sh-bot merged commit 25f88c8 into volcano-sh:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants