Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up bump version script #960

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Clean up bump version script #960

merged 4 commits into from
Sep 13, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 13, 2021

References

Follow-up to #954

Code changes

Simplify the bumping to be able to use next for both patch and build

User-facing changes

None

Backwards-incompatible changes

None

@github-actions
Copy link
Contributor

Binder 👈 Try it on binder (branch jtpio/voila/clean-up-bump-version)

@jtpio jtpio added this to the 0.2.x milestone Sep 13, 2021
@jtpio jtpio marked this pull request as ready for review September 13, 2021 07:29
@jtpio
Copy link
Member Author

jtpio commented Sep 13, 2021

macos check failures are unrelated

@jtpio jtpio merged commit aa79d9c into voila-dashboards:master Sep 13, 2021
@jtpio jtpio deleted the clean-up-bump-version branch September 13, 2021 13:26
@trungleduc
Copy link
Member

@jtpio do you know why `` many_iopub_messages_test.py test failed on macos? I have also this problem on my PR

@jtpio
Copy link
Member Author

jtpio commented Sep 14, 2021

@trungleduc until now the check seemed quite flaky, and would often pass after restarting it.

I've opened #961 to track this.

@jtpio jtpio mentioned this pull request Oct 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
0.2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @trungleduc