Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next to the bump script #1002

Merged
merged 4 commits into from
Oct 15, 2021
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 14, 2021

References

This option was missing from the bump script.

Follow-up to #960.

Code changes

Update to the version bump script.

User-facing changes

None

Backwards-incompatible changes

None

@github-actions
Copy link
Contributor

Binder 👈 Try it on binder (branch jtpio/voila/bump-script)

@jtpio
Copy link
Member Author

jtpio commented Oct 14, 2021

We can wait for 0.3.0a2 to be released first before merging this PR: #1001

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2021

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb
Render
chromium
actual 2763 <- [2812 - 2887 - 2973] -> 3337 2368 <- [2382 - 2394 - 2438] -> 2480 2692 <- [2802 - 2850 - 2913] -> 2961 3054 <- [3113 - 3175 - 3178] -> 3241 1840 <- [1851 - 1859 - 1927] -> 1940 3221 <- [3223 - 3339 - 3665] -> 4723 8255 <- [13449 - 14342 - 15447] -> 15767 9356 <- [9372 - 9394 - 9423] -> 9468 1167 <- [1266 - 1297 - 1314] -> 1353
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2021-10-14 18:53:28.705822284 +0000
+++ /dev/fd/62	2021-10-14 18:53:28.705822284 +0000
@@ -8,33 +8,33 @@
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8272CL",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 36700160
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "85",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.6,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "7",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7291695104
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.8.0-1042-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
       "release": "20.04.3 LTS",
-      "serial": "f87a2cd4ed534fea8f3ccb44ed7db74e",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@jtpio jtpio marked this pull request as ready for review October 14, 2021 14:41
@jtpio jtpio added this to the 0.2.x milestone Oct 14, 2021
@jtpio
Copy link
Member Author

jtpio commented Oct 14, 2021

cc @trungleduc if you want to have a look

@trungleduc
Copy link
Member

just curious, why does it still work in the previous PR with next spec?

@jtpio
Copy link
Member Author

jtpio commented Oct 14, 2021

just curious, why does it still work in the previous PR with next spec?

next is being converted here:

if spec == "next":
spec = "patch" if is_final else "build"

So maybe we could slightly rework the logic to do that check first.

Copy link
Member

@trungleduc trungleduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ValueError is more appropriate.

scripts/bump-version.py Outdated Show resolved Hide resolved
Co-authored-by: Duc Trung LE <leductrungxf@gmail.com>
@trungleduc
Copy link
Member

LGTM, thanks!

@trungleduc trungleduc merged commit 219bed7 into voila-dashboards:main Oct 15, 2021
@jtpio jtpio deleted the bump-script branch October 15, 2021 07:50
@jtpio
Copy link
Member Author

jtpio commented Oct 15, 2021

@meeseeksdev please backport to 0.2.x

meeseeksmachine pushed a commit to meeseeksmachine/voila that referenced this pull request Oct 15, 2021
jtpio added a commit that referenced this pull request Oct 15, 2021
…2-on-0.2.x

Backport PR #1002 on branch 0.2.x (Add next to the bump script)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants