Usability: Open browser, display url and shortcut to serving directory #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one has ssl, I think it's good to have otherwise why have a link at all if it won't work sometimes:#119 |
|
👍 |
|
Cool, happy to put in the SSL. How do you configure voila to use https btw? Because we don't support the certfile yet, I didn't think support for it make sense. |
|
We don't yet either but how much more do you have to do vs passing the settings through to tornado? |
|
I don't want to put too much in this PR. If we add in SSL we can simply uncomment https://github.com/QuantStack/voila/pull/136/files#diff-024301d95616622c19f49b8cd78d33c3R224 and have https as protocol. |
|
This closes #111 |
maartenbreddels
added a commit
to maartenbreddels/voila
that referenced
this pull request
May 17, 2019
voila-dashboards#136) * New: open browser on launch * Show the url voila is running at * New: shortcut to serving a directory when the cmd line argument is a directory * flake8 * fix: help was None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make voila easier to use, we now open the browser (this is done analogous to the notebook as close as possible). To avoild opening the browser, pass
--no-browser.Also, analogous to the notebook, it now shows the url it is running at:
This can be customized, using
--Voila.custom_display_url='foobar'and--Voila.ip=''for instance, again similar to the classical notebook.A third improvement is hosting directories. Previously this was done using
--Voila.root_dir='/path/to'and no giving extra arguments. With this PR, if the passed argument is a directory, it wil set the root dir.Future: I've left in some commented out code for the tokens and SSL, I don't think we should attack that now.