Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better connection string log #119

Closed
wants to merge 1 commit into from
Closed

Better connection string log #119

wants to merge 1 commit into from

Conversation

timkpaine
Copy link
Member

Depending on whether tornado_settings is setup for SSL will print
Screen Shot 2019-04-17 at 1 39 37 PM
or
Screen Shot 2019-04-17 at 1 39 42 PM

@timkpaine timkpaine changed the title Better log Better connection string log Apr 17, 2019
@timkpaine timkpaine mentioned this pull request May 7, 2019
Closed
@choldgraf
Copy link
Contributor

This would make my life better by a small but significant amount :-)

@timkpaine timkpaine mentioned this pull request May 14, 2019
Merged
@SylvainCorlay
Copy link
Member

@timkpaine this appears to need a rebase now that we open a web browser. Would you like to rebase? I am happy to do it otherwise.

@maartenbreddels
Copy link
Member

I think the way forward is to open a PR with https support and uncomment https://github.com/QuantStack/voila/blob/a66eb1fcf619da0b3a3cf39d5cd2c3261f51027a/voila/app.py#L226 so we get this for free.
Do you agree @timkpaine ?

@timkpaine
Copy link
Member Author

Yeah this is encompassed by the other PR

@timkpaine timkpaine closed this May 18, 2019
@timkpaine timkpaine deleted the better_log branch May 28, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timkpaine @choldgraf @SylvainCorlay @maartenbreddels