-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default VOILA_WS_BASE_URL value in preheating mode #1141
Fix default VOILA_WS_BASE_URL value in preheating mode #1141
Conversation
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. Results table
❗ Test metadata have changed--- /dev/fd/63 2022-04-11 10:11:36.482331025 +0000
+++ /dev/fd/62 2022-04-11 10:11:36.482331025 +0000
@@ -4,37 +4,37 @@
"BENCHMARK_REFERENCE": "actual"
},
"browsers": {
- "chromium": "97.0.4666.0"
+ "chromium": "94.0.4595.0"
},
"systemInformation": {
"cpu": {
- "brand": "Xeon® E5-2673 v4",
+ "brand": "Xeon® E5-2673 v3",
"cache": {
"l1d": 65536,
"l1i": 65536,
"l2": 524288,
- "l3": 52428800
+ "l3": 31457280
},
"cores": 2,
"family": "6",
- "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear",
+ "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
"governor": "",
"manufacturer": "Intel®",
- "model": "79",
+ "model": "63",
"physicalCores": 2,
"processors": 1,
"revision": "",
"socket": "",
- "speed": 2.3,
+ "speed": 2.4,
"speedMax": null,
"speedMin": null,
- "stepping": "1",
+ "stepping": "2",
"vendor": "GenuineIntel",
"virtualization": false,
"voltage": ""
},
"mem": {
- "total": 7283847168
+ "total": 7291699200
},
"osInfo": {
"arch": "x64",
@@ -42,11 +42,11 @@
"codename": "Focal Fossa",
"codepage": "UTF-8",
"distro": "Ubuntu",
- "kernel": "5.13.0-1021-azure",
+ "kernel": "5.8.0-1040-azure",
"logofile": "ubuntu",
"platform": "linux",
- "release": "20.04.4 LTS",
- "serial": "2f7f553bd7b042d1bf1c5b62ae644666",
+ "release": "20.04.3 LTS",
+ "serial": "cfc067bfcb844f35865e279a1b0e66c5",
"servicepack": "",
"uefi": false
} |
Thanks @vkaidalov-rft for your PR! |
Hi @trungleduc, sure! |
I can see I've "allowed edits by maintainers" for this PR, so I suppose nothing else is needed. I haven't used this feature yet 😄 |
Thanks! I will ping you when I push my commits |
2ce2c7c
to
0bd5378
Compare
@vkaidalov-rft I updated your fix since the default WebSocket handler is at Lines 500 to 502 in 9afaaf0
And Line 448 in 9afaaf0
So it will work as expected. |
Thank you, @trungleduc! I've checked your changes and can confirm everything still works as expected 👍 |
@martinRenou can you take a look at this PR as I contributed quite extensively on this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
References
Resolves #1140.
Code changes
Use
VOILA_BASE_URL
as the default value ifVOILA_WS_BASE_URL
has not been specified to make thewait_for_request
andget_query_string
functions backwards-compatible in the preheating mode.