Kernels don't get the query string if --Voila.base_url
is specified and preheating is turned on
#1140
Labels
bug
Something isn't working
Description
Hi!
When I was updating Voila from 0.3.1 to 0.3.5 on my machine, I saw that the preheated kernels produced some warning messages even before leaving the kernels pool. After taking a look at the recent changes, I found out that specifying the
VOILA_WS_BASE_URL
env. variable was now required to use the--Voila.base_url
parameter.Reproduce
get_qs_example.ipynb
file with the following code:According to the source code, the VoilaHandler ignores the WebSocket connection error and goes on with an empty query string value.
4. Go to http://localhost:8866/example-base-url/?foo1=bar1&foo2=bar2 in the browser and see
None
instead of the expectedfoo1=bar1&foo2=bar2
value.Expected behavior
I managed to modify my bash script to make app work correctly by providing the
VOILA_WS_BASE_URL
env. var. as follows:However, it's still a breaking change as I had to modify my bash script and I would expect Voila to use the value of
--Voila.base_url
parameter if theVOILA_WS_BASE_URL
variable hasn't been specified.The text was updated successfully, but these errors were encountered: