-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: giara-1.0.1 #37132
New package: giara-1.0.1 #37132
Conversation
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
3d682d2
to
9bc75e4
Compare
deps updated, tested again that it still works. |
I merged blueprint-compiler separately for now because I needed it for another package, could you drop it from this PR? |
9bc75e4
to
76a032c
Compare
Done. I've rebased it on master, dropping the blueprint-compiler commit in the process |
3d934ce
to
153f1d0
Compare
153f1d0
to
a38caf9
Compare
a38caf9
to
cd06343
Compare
cd06343
to
63926aa
Compare
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
still planning on getting this merged, will update later. |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Testing the changes
New package
Follow up to #28453, which I've discovered after I had already packaged everything and was looking into mistune acting up at runtime. I agree with the sentiment that the packaging is a fragile pita, but with nearly everything in here not having the checks disabled now, I'm a bit more confident that this is actually fine.
One thing that should probably be done here is updating mistune again, because there's a stable 2.0.2 release now, which has also been updated in jupyter/nbconvert#1764, which probably means we can update
python3-mistune
to 2.0.2 oncepython3-jupyter_nbconvert
has its next stable release. The 7.0.0-rc.1 has been released 5 days ago after the mistune update had been merged.