Update to Mistune 2.0.2 #1764
Merged
Update to Mistune 2.0.2 #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this @TiagodePAlves! I think what you've done so far is a great approach to keeping backwards compatibility. I'd say if we get the existing test suite to pass, we should merge this PR. Pinning isn't a long term solution, and vendoring |
|
Ok, I think the regexes may be the problem. I'll push it as soon as I fix it. |
|
No rush, thanks again for taking this up! |
|
I rewrote the regexes and they were passing the |
|
All green in CI! @bollwyvl @SylvainCorlay I propose we release a 7.0rc0 with this change. |
- 'AXT_HEADING' is now requiring whitespace after the '#', fixed with a new regex - 're.Scanner' is not able to extract the correct group, the text needs trimming before use - 'javascript:...' links considered harmful by 'HTMLRenderer', should we disable it too?
Important to avoid problems with the TeX-style block math where the trailing '$$' is not removed.
|
Thanks a lot for this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mistune 2.0 was major overhaul, requiring a lot of changes on the
markdown2html_mistunefilter. I understand that the update may noy be desirable (see #1685), but I'm leaving this here as an option. Still, some more testing seems needed.Possible problems
BlockParserdoesn't consider#TITLEwithout space a valid header. I've fixed it with a customAXT_HEADINGregex, but there may be other problems hidden in those regexes.re.Scanner, but I couldn't make it remove the$$suffix in block math and had to strip the text manually. Can we trustre.Scanner? It seems to have other unexpected shortcomings too.javascript:...links harmful and removes them. I've bypassed that, but maybe it should be adopted too.