vdk-jupyter: add Convert Job To Notebook UI button #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
murphp15
reviewed
Jun 27, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/serverRequests.ts
Show resolved
Hide resolved
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
for more information, see https://pre-commit.ci
duyguHsnHsn
reviewed
Jun 27, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/TransformJob.tsx
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/TransformJob.tsx
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/vdk_ui.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/handlers.py
Outdated
Show resolved
Hide resolved
…2.14 in /projects/control-service/projects/pipelines_control_service (#2321) Bumps io.swagger.core.v3:swagger-models from 2.2.12 to 2.2.14. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Incremental change for adding the secrets capability. Add secrets implementation and tests in vdk-core. --------- Signed-off-by: Dako Dakov <ddakov@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
|
Please make sure all UI related PRs have screenshots of relevant changes |
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/handlers.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/TransformJob.tsx
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/TransformJob.tsx
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/TransformJob.tsx
Outdated
Show resolved
Hide resolved
...k-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/transform-job-component.spec.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/utils.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
...k-jupyter/vdk-jupyterlab-extension/src/__tests__/transform-job-to-notebook-component.spec.ts
Outdated
Show resolved
Hide resolved
antoniivanov
approved these changes
Jun 29, 2023
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
yonitoo
deleted the
topic/ysalambashev/jupyter-add-transform-job-ui-button
branch
yonitoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add button to the VDK menu in the UI responsible for the Convert Job To Notebook action.
Why:
To provide the user with the option to do Convert Job To Notebook operation.
Newly introduced UI component:
Testing Done:
Аdded jest tests for the component. + The plugin is built successfully.
Signed-off-by: Yoan Salambashev ysalambashev@vmware.com