vdk-core: add vdk sdk secrets api - part III #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incremental change for adding the secrets capability. Add secrets implementation and tests in vdk-core. Signed-off-by: Dako Dakov <ddakov@vmware.com>
murphp15
reviewed
Jun 26, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/job_properties/base_properties_impl.py
Show resolved
Hide resolved
murphp15
reviewed
Jun 26, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/job_properties/base_properties_impl.py
Show resolved
Hide resolved
murphp15
reviewed
Jun 26, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/job_secrets/base_secrets_impl.py
Show resolved
Hide resolved
murphp15
reviewed
Jun 26, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/job_secrets/cached_secrets.py
Show resolved
Hide resolved
murphp15
reviewed
Jun 26, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/job_secrets/datajobs_service_secrets.py
Show resolved
Hide resolved
murphp15
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
There's a lot of duplication between properties and job_secrets.
Do you plan to refactor it?
Sometimes duplication may be ok . If two modules will have different reasons to change and are likely to diverge.
But this is not true for large part of the code here.
antoniivanov
approved these changes
Jun 26, 2023
added 4 commits
June 27, 2023 09:57
Make sure the dev version of vdk-core is used in the build. Signed-off-by: Dako Dakov <ddakov@vmware.com>
Make sure the dev version of vdk-core is used in the build. Signed-off-by: Dako Dakov <ddakov@vmware.com>
Make sure the dev version of vdk-core is used in the build. Signed-off-by: Dako Dakov <ddakov@vmware.com>
Make sure the dev version of vdk-core is used in the build. Signed-off-by: Dako Dakov <ddakov@vmware.com>
yonitoo
pushed a commit
that referenced
this pull request
Jun 27, 2023
Incremental change for adding the secrets capability. Add secrets implementation and tests in vdk-core. --------- Signed-off-by: Dako Dakov <ddakov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental change for adding the secrets capability.
Add secrets implementation and tests in vdk-core.