Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: skip tests unless running docker on linux #3611

Merged
merged 1 commit into from
Nov 4, 2024
Merged

chore: skip tests unless running docker on linux #3611

merged 1 commit into from
Nov 4, 2024

Conversation

dougm
Copy link
Member

@dougm dougm commented Nov 4, 2024

Fixes #3604

@dougm
chore: skip tests unless running docker on linux
34ca8c8 
Fixes vmware#3604

Signed-off-by: Doug MacEachern <dougm@broadcom.com>
rikatz
rikatz reviewed Nov 4, 2024
View reviewed changes
rikatz
rikatz approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@rikatz rikatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving approval, besides the fmt.Println everything seems fine to me

@dougm dougm merged commit 1d5568b into vmware:main Nov 4, 2024
11 checks passed
@dougm dougm deleted the issue-3604 branch November 4, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikatz rikatz rikatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] some tests fail without docker on linux
2 participants
@dougm @rikatz