Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] some tests fail without docker on linux #3604

Closed
asxe opened this issue Oct 27, 2024 · 4 comments · Fixed by #3611
Closed

[BUG] some tests fail without docker on linux #3604

asxe opened this issue Oct 27, 2024 · 4 comments · Fixed by #3611

Comments

@asxe
Copy link

asxe commented Oct 27, 2024

Describe the bug
go test is failing on FreeBSD 13 ports repository. Execution of 'make test' is failing. The same results for Go 1.21 & 1.22 from Ports.

To Reproduce
Steps to reproduce the behavior:

  1. cd sysutils/govmomi
  2. make test

Expected behavior
test is PASSed. If platform is unsupported, skip test as unsupported.

Affected version
Tested on 0.45.1, 0.44.1, 0.33.0

Screenshots/Debug Output
Log is attached.
govmimo-test.txt

Additional context
Highly possible, the FAIL result is because Docker isn't well supported. Is any way to skip tests for unsupported platforms?
@github-actions GitHub Actions
Copy link
Contributor

Howdy 🖐   asxe ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Nov 2, 2024
@asxe
sysutils/govmomi: Update to 0.45.1
fd26a78 
Add TESTING_UNSAFE, opened a PR on project page
(vmware/govmomi#3604).

Changelogs:
https://github.com/vmware/govmomi/releases/tag/v0.45.1
https://github.com/vmware/govmomi/releases/tag/v0.45.0
https://github.com/vmware/govmomi/releases/tag/v0.44.1
https://github.com/vmware/govmomi/releases/tag/v0.44.0

PR:             282238
Approved by:    submitter is maintainer
@dougm dougm changed the title [BUG] [BUG] some tests fail without docker on linux Nov 4, 2024
dougm added a commit to dougm/govmomi that referenced this issue Nov 4, 2024
@dougm
chore: skip tests unless running docker on linux
6855749 
Fixes vmware#3604
dougm added a commit to dougm/govmomi that referenced this issue Nov 4, 2024
@dougm
chore: skip tests unless running docker on linux
5e3c608 
Fixes vmware#3604
@dougm dougm mentioned this issue Nov 4, 2024
Merged
@dougm dougm closed this as completed in 34ca8c8 Nov 4, 2024
@dougm
Copy link
Member

dougm commented Nov 4, 2024

@asxe , yes these were docker related, added check so we skip without docker + linux

@asxe
Copy link
Author

asxe commented Nov 10, 2024

test is failing on 0.46.0 version.
Is any way to skip tests on unsupported operating systems?

--- PASS: Example_runContainer (0.33s)
FAIL
FAIL    github.com/vmware/govmomi/simulator     54.996s

@dougm
Copy link
Member

dougm commented Nov 11, 2024

test is failing on 0.46.0 version. Is any way to skip tests on unsupported operating systems?

--- PASS: Example_runContainer (0.33s)
FAIL
FAIL    github.com/vmware/govmomi/simulator     54.996s

Was that the only output?

That example test should return early:
https://github.com/vmware/govmomi/blob/main/simulator/feature_test.go#L92

Unless run on linux with docker in PATH:
https://github.com/vmware/govmomi/blob/main/test/helper.go#L33-L41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: skip tests unless running docker on linux dougm/govmomi
2 participants
@dougm @asxe