Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume metrics #62

Closed
erdembas opened this issue Jun 16, 2022 · 2 comments · Fixed by #75
Closed

Volume metrics #62

erdembas opened this issue Jun 16, 2022 · 2 comments · Fixed by #75
Assignees
Labels
enhancement New feature or request

Comments

@erdembas
Copy link

erdembas commented Jun 16, 2022

Is your feature request related to a problem? Please describe.

I am trying to monitor PVs and am not able to get the kubelet_volume_stats_available_bytes because it is no longer supported by default in the node exporter.

Describe the solution you'd like

Include the metrics similar to how the AWS EBS CSI driver did it. I think CSI drivers themselves need to implement these metrics since k8s v1.13 or something around there though I could be wrong.

Issue: kubernetes-sigs/aws-ebs-csi-driver#524
PR: kubernetes-sigs/aws-ebs-csi-driver#677

Digital Ocean CSI PR : digitalocean/csi-digitalocean#197

VSphere Implementation : https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/d288ab214ed6d62b2d29e4e0c6e3cf0522d4fc16/pkg/csi/service/node.go#L232

Describe alternatives you've considered

I've been trying to get my relabel configs right to monitor a group of PVs and am not able to get the PV name out of the node exporter to be able to match node_filesystem_free_bytes to the right PV. This is broadly needed to monitor sensitive PVs running on VKE that might need volumes added to the array as they will up.

Additional context

No response

@erdembas erdembas added the enhancement New feature or request label Jun 16, 2022
@arunmk arunmk self-assigned this Jun 19, 2022
@erdembas
Copy link
Author

Hi @arunmk,
Any progress on this? Using disk metrics without monitoring will cause problems. @arunmk

arunmk added a commit to arunmk/cloud-director-named-disk-csi-driver that referenced this issue Jul 16, 2022
@arunmk
Copy link
Collaborator

arunmk commented Jul 16, 2022

@erdembas we have been busy with a few releases. This PR should provide metrics.

arunmk added a commit to arunmk/cloud-director-named-disk-csi-driver that referenced this issue Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants