Implement NodeGetVolumeStats RPC #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwg
approved these changes
Nov 6, 2019
|
|
||
| return nil, status.Error(codes.Unimplemented, "") | ||
| if req.VolumeId == "" { |
There was a problem hiding this comment.
Doesn't look like we actually use the VolumeId. Are we validating it just because that's what's in the CSI spec?
There was a problem hiding this comment.
That's correct: the field is marked as required per the CSI spec, and the upstream unit tests codify this requirement.
timoreimann
force-pushed
the
implement-get-volume-stats-rpc
branch
from
17343cf to
1991f5c
Compare
Exposing node capacity statistics facilitates features like alerting on high disk usage.
timoreimann
force-pushed
the
implement-get-volume-stats-rpc
branch
from
1991f5c to
e817678
Compare
This was referenced Sep 23, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing node capacity statistics facilitates features like alerting on high disk usage.
I ran my implementation on a cluster with Prometheus on and was able to retrieve metrics with the
kubelet_volume_*prefix, e.g.,kubelet_volume_stats_capacity_bytes. So this seems to work. I'll do some more testing for sure though before merging.Fixes #134