Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Fix broken multimodal test #10950

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

DarkLight1337
Copy link
Member

Turns out this test still fails even after #10106. I didn't see it in the CI log because the command wasn't run after the previous one failed 😅

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does transformers have plan to fix it?

@DarkLight1337
Copy link
Member Author

I commented on the PR but seems they haven't really fixed it yet.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 6, 2024 08:47
@DarkLight1337 DarkLight1337 merged commit 222f5b0 into main Dec 6, 2024
40 of 42 checks passed
@DarkLight1337 DarkLight1337 deleted the DarkLight1337-fix-mm-extended branch December 6, 2024 10:41
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants