Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Bump test transformers version #10106

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Nov 7, 2024

FILL IN THE PR DESCRIPTION HERE

Seems that transformers' new 4.46.2 patch version has addressed the Chameleon and Llava issues: https://github.com/huggingface/transformers/releases/tag/v4.46.2

Let's see if the broken test can run again with 4.46.2.

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels

Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

  • Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
  • Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
  • Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops. See tests/kernels for examples.
  • When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
  • If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Signed-off-by: Isotr0py <2037008807@qq.com>
Copy link

github-actions bot commented Nov 7, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 7, 2024
@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 7, 2024
@Isotr0py Isotr0py marked this pull request as ready for review November 7, 2024 06:13
Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py
Copy link
Collaborator Author

Isotr0py commented Nov 7, 2024

Well, "broadcast-chameleon" and "broadcast-llava_next" passed on my side locally, see if other models work well in CI.

@DarkLight1337
Copy link
Member

DarkLight1337 commented Nov 7, 2024

CI is currently broken right now. Hope it gets fixed soon. Fixed

@DarkLight1337
Copy link
Member

Looks like LLaVA-NeXT still fails to handle text-only inputs.

@Isotr0py
Copy link
Collaborator Author

Isotr0py commented Nov 7, 2024

Yes, the LLaVA-NeXT embedding test is still failing... BTW, is this issue reported to transformers repo?

@Isotr0py Isotr0py marked this pull request as draft November 7, 2024 08:35
@Isotr0py Isotr0py changed the title [CI/Build] Bump test transformers version to 4.46.2 [CI/Build] Bump test transformers version Nov 7, 2024
@DarkLight1337
Copy link
Member

DarkLight1337 commented Nov 7, 2024

Only the issue with Chameleon has been reported... I thought they would fix this issue as well in huggingface/transformers#34332, but guess not.

@DarkLight1337
Copy link
Member

I have reported the issue to their repo. As for this PR, you can re-enable the other tests first.

Copy link

mergify bot commented Nov 8, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @Isotr0py.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 8, 2024
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 removed the ready ONLY add when PR is ready to merge/full CI is needed label Dec 5, 2024
@DarkLight1337 DarkLight1337 marked this pull request as ready for review December 5, 2024 10:59
@DarkLight1337
Copy link
Member

Let's see if v4.46.3 fixed the problem.

@mergify mergify bot removed the needs-rebase label Dec 5, 2024
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the problem has been fixed on HF side. Let's merge this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 5, 2024 14:10
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 5, 2024
@DarkLight1337 DarkLight1337 merged commit 998eeaf into vllm-project:main Dec 5, 2024
85 checks passed
@Isotr0py Isotr0py deleted the ci-update-transformers branch December 5, 2024 16:23
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants