Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evaluation of boolean conditions in github workflows #136

Merged

Conversation

Kevincifuentes
Copy link
Contributor

@Kevincifuentes Kevincifuentes commented Jan 2, 2025

📝 Description

This PR fixes the conditional for providing file name for diff-base-breakdown-file-name on the example provided, which was leading to always provide that value (even with thatmain.breakdown file is missing). The reason for this was that we were expecting a boolean output from the previous action and, unfortunately, even if the response is false, the conditional considers the value as string (already known behavior).

This PR simply checks that value as string and updates the documentation to display that change.

🔗 Related Issue

N/A

✅ Checklist Before Requesting a Review

  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if applicable).
  • I have ensured that all tests pass locally.
  • I have followed the project's coding standards.

📋 Changes Summary

  • Change 1: Added string comparison instead on example workflow test.yml
  • Change 2: Updated documentation for github action on github_action.md

🚀 How to Test

I have tested the issue on my private repository too, so I can share some screenshots about it:

Before the fix:
Screenshot 2025-01-02 at 16 59 34
Screenshot 2025-01-02 at 16 59 26

After the fix:
Screenshot 2025-01-02 at 16 59 58
Screenshot 2025-01-02 at 17 00 06

🛠️ Additional Notes

Thanks so much for this project! I have been working with GO a few weeks so far, and this has been a nice repository to use ❤️

@vladopajic vladopajic changed the title [Found_artifact fix] Updated docs and test.yml workflow to proper check for found_artifact conditional fix: evaluation of boolean conditions in github workflows Jan 2, 2025
@vladopajic
Copy link
Owner

@Kevincifuentes excellent! thanks <3

@vladopajic vladopajic merged commit 947781c into vladopajic:main Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants