Minor issue on comparison on Github Actions for found_artifact boolean

[Kevincifuentes]

Hi!

First of all, thank you so much for this project and the support!

Setting up a new repository, I have seen that there is a minor issue on comparison for diff-base-breakdown-file-name:

diff-base-breakdown-file-name: ${{ steps.download-main-breakdown.outputs.found_artifact && 'main.breakdown' || '' }}

Apparently, this conditional always resolves as "true", because the output is likely treated as string (reference).

It can be easily fixed by:

diff-base-breakdown-file-name: ${{ steps.download-main-breakdown.outputs.found_artifact == 'true' && 'main.breakdown' || '' }}

I would refactor it and update the documentation myself, but I don't have access for that.

Thanks again and happy holidays!

[vladopajic]

@Kevincifuentes hey man!

Thanks for letting me know. It would be really helpful if you can make this change.

You don't need access on this repo if you want to contribute. You can fork this repo and then make PR. See this guide for reference (step 3 is not necessary here), or search online to see other guides.

Happy coding 🌞

[Kevincifuentes]

Sure thing!

Of course! That's a possibility!

Here you have the PR: #136

Thanks for the support and the great project!

[vladopajic]

closing as PR #136 was merged. thanks @Kevincifuentes