fix: fix multisig issues

[Hemanthghs]

Summary by CodeRabbit

• New Features

  • Implemented a copy-to-clipboard feature for account addresses.
  • Enhanced the multisig account deletion process with improved state handling.

• Enhancements

  • Upgraded interactive elements for creating multisig transactions to use buttons for better accessibility.

• Bug Fixes

  • Corrected balance parsing in delegation and redelegation messages to handle amounts as arrays.
  • Fixed the amount structure in delegate transaction messages to align with expected object format.

• Style

  • Updated styling for account member lists and addresses for better visual clarity.

• Documentation

  • (No visible documentation changes for end-users)

• Refactor

  • Refactored transaction parsing functions to correctly handle single amount entries.

• Chores

  • (No visible chore changes for end-users)

• Tests

  • (No visible test changes for end-users)

• Revert

  • (No reverts in this release)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dev-resolute	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 19, 2023 10:49am
resolute	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 19, 2023 10:49am

[coderabbitai]

Walkthrough

The recent updates to the multisig components of the frontend application involve various enhancements and bug fixes. The changes include improved clipboard interactions, UI adjustments, better state management, and code optimization. The delegation-related components have been refined to handle data structures more effectively, with the amount field's structure being a focal point of these adjustments. Additionally, modifications to logging and CSS styling further refine the user experience and code maintainability.

Changes

File Path	Change Summary
.../multisig/components/AccountInfo.tsx	Added copyToClipboard functionality, updated state handling, and added onClick handler for address copying.
.../multisig/components/DialogCreateMultisig.tsx	Changed a span to a button for creating a multisig.
.../multisig/components/DialogCreateTxn.tsx	Inserted console.log statements before setting parsedTxns.
.../multisig/components/msgs/DelegateMessage.tsx, .../multisig/components/msgs/RedelegateMessage.tsx, .../multisig/components/msgs/UndelegateMessage.tsx	Adjusted parseBalance function calls to pass an array.
.../multisig/components/txns/Delegate.tsx, .../multisig/components/txns/ReDelegate.tsx, .../multisig/components/txns/UnDelegate.tsx	Modified the amount property structure and updated formatCoin usage.
.../multisig/multisig.css	Updated CSS styling for .account-members and .member-address.
frontend/src/components/SelectNetwork.tsx	Imported copyToClipboard and modified Image component's onClick.
frontend/src/utils/parseMsgs.ts	Altered amount parameter handling in message parsing functions.

"In the realm of code, where the rabbits play,
A flurry of changes have hopped our way. 🐾
With each keystroke, they dance and they prance,
Crafting a world with a more graceful stance." 🎉🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment made by CodeRabbit.
• You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
• You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e58b557 and 53e19a7.

Files selected for processing (12)

• frontend/src/app/(routes)/multisig/components/AccountInfo.tsx (6 hunks)
• frontend/src/app/(routes)/multisig/components/DialogCreateMultisig.tsx (1 hunks)
• frontend/src/app/(routes)/multisig/components/DialogCreateTxn.tsx (2 hunks)
• frontend/src/app/(routes)/multisig/components/msgs/DelegateMessage.tsx (1 hunks)
• frontend/src/app/(routes)/multisig/components/msgs/RedelegateMessage.tsx (1 hunks)
• frontend/src/app/(routes)/multisig/components/msgs/UndelegateMessage.tsx (1 hunks)
• frontend/src/app/(routes)/multisig/components/txns/Delegate.tsx (1 hunks)
• frontend/src/app/(routes)/multisig/components/txns/ReDelegate.tsx (1 hunks)
• frontend/src/app/(routes)/multisig/components/txns/UnDelegate.tsx (2 hunks)
• frontend/src/app/(routes)/multisig/multisig.css (1 hunks)
• frontend/src/components/SelectNetwork.tsx (3 hunks)
• frontend/src/utils/parseMsgs.ts (3 hunks)

Files skipped from review due to trivial changes (1)

• frontend/src/app/(routes)/multisig/multisig.css

Additional comments: 18

frontend/src/app/(routes)/multisig/components/AccountInfo.tsx (5)

• 12-12: The addition of the copyToClipboard import is consistent with the changes in the file that introduce clipboard functionality.

• 114-114: The state deleteMultisigRes is used to handle the response of the delete multisig action. Ensure that the state is properly reset after handling to avoid unintended side effects.

• 126-131: The useEffect hook is used to close the delete dialog and navigate back when the deleteMultisigRes status is 'idle'. It's important to verify that the status 'idle' correctly represents a successful deletion and that there are no edge cases where this status might lead to incorrect behavior.

• 133-140: The handleDelete function dispatches the deleteMultisig action. It's crucial to ensure that the queryParams object is populated with the correct parameters required for the deletion API call.

• 248-257: The onClick handler for the copy icon is correctly using the copyToClipboard utility. However, it's important to ensure that the copyToClipboard function handles errors gracefully and provides user feedback.

frontend/src/app/(routes)/multisig/components/DialogCreateMultisig.tsx (1)

• 449-454: The change from a span to a button element for adding a new member improves accessibility and is semantically correct for an interactive element.

frontend/src/app/(routes)/multisig/components/msgs/DelegateMessage.tsx (1)

• 23-23: The change to pass an array to parseBalance is consistent with the updated function signature. Ensure that all calls to parseBalance are updated accordingly.

frontend/src/app/(routes)/multisig/components/msgs/RedelegateMessage.tsx (1)

• 23-23: The update to pass an array to parseBalance is correct, assuming the function now expects an array. This change should be consistently applied wherever parseBalance is used.

frontend/src/app/(routes)/multisig/components/msgs/UndelegateMessage.tsx (1)

• 23-23: The update to pass an array to parseBalance is correct, assuming the function now expects an array. This change should be consistently applied wherever parseBalance is used.

frontend/src/app/(routes)/multisig/components/txns/Delegate.tsx (1)

• 80-83: The change from an array to an object for the amount property aligns with the updated data model. Ensure that the receiving end of this data is also updated to handle an object instead of an array.

frontend/src/app/(routes)/multisig/components/txns/ReDelegate.tsx (1)

• 151-155: The change from an array to an object for the amount property aligns with the updated data model. Ensure that the receiving end of this data is also updated to handle an object instead of an array.

frontend/src/app/(routes)/multisig/components/txns/UnDelegate.tsx (2)

• 119-122: The change from an array to an object for the amount property aligns with the updated data model. Ensure that the receiving end of this data is also updated to handle an object instead of an array.

• 197-197: The update to use currency?.coinDenom instead of selectedValBal?.denom for the formatCoin function is correct, assuming that currency?.coinDenom is the intended denomination for display.

frontend/src/components/SelectNetwork.tsx (2)

• 13-13: The import of copyToClipboard is consistent with the addition of clipboard functionality in the component.

• 77-84: The onClick handler for the copy icon is correctly using the copyToClipboard utility and dispatching a success message. Ensure that the copyToClipboard function handles errors gracefully and provides user feedback.

frontend/src/utils/parseMsgs.ts (3)

• 108-108: The change to access the first element of the amount array is correct if the function now expects a single object instead of an array. Ensure that all calls to these parsing functions are updated accordingly.

• 158-158: The change to access the first element of the amount array is correct if the function now expects a single object instead of an array. Ensure that all calls to these parsing functions are updated accordingly.

• 211-211: The change to access the first element of the amount array is correct if the function now expects a single object instead of an array. Ensure that all calls to these parsing functions are updated accordingly.

[vercel]

Deployment failed with the following error:

Resource is limited - try again in 12 minutes (more than 100, code: "api-deployments-free-per-day").

[vercel]

Deployment failed with the following error:

Resource is limited - try again in 9 minutes (more than 100, code: "api-deployments-free-per-day").

[vercel]

Deployment failed with the following error:

Resource is limited - try again in 40 minutes (more than 100, code: "api-deployments-free-per-day").

[coderabbitai]

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 53e19a7 and b57324d.

Files selected for processing (1)

• frontend/src/utils/chainsInfo.ts (7 hunks)

Files not summarized due to errors (1)

• frontend/src/utils/chainsInfo.ts: Error: Message exceeds token limit

Additional comments: 13

frontend/src/utils/chainsInfo.ts (13)

• 82-83: The network configuration starting from line 82 appears to be consistent with the expected structure based on the rest of the file. Ensure that all necessary properties are present and correctly set for each network object.

• 515-517: Verify that the URLs for the logos and explorer endpoints are correct and the resources are accessible. For example, the menu logo URL on line 515 and the toolbar logo URL on line 517.

• 530-531: Ensure that the coinDecimals property is set to the correct value for each currency configuration. For example, on line 530, coinDecimals is set to 6 for 'OSMO'. This should match the actual decimal precision used by the network.

• 556-556: Confirm that the coinType under the bip44 property is set correctly for each network. For instance, on line 556, the coinType is set to 118, which is commonly used for Cosmos networks. Ensure this is the intended value for the network being configured.

• 536-541: Check that the bech32Config prefixes are correct for the network's address format. For example, lines 536 to 541 show the bech32 prefixes for the 'Osmosis' network. These should be validated against the network's official documentation.

• 545-546: Ensure that the coinDenom and coinMinimalDenom are set correctly for the feeCurrencies and stakeCurrency. For example, on lines 545 and 546, 'OSMO' and 'uosmo' are used for the 'Osmosis' network. Confirm these values are accurate.

• 549-549: Review the gasPriceStep values to ensure they are reasonable and align with the network's fee market. For instance, on line 549, the values for 'low', 'average', and 'high' gas prices should be set to appropriate amounts for the 'Osmosis' network.

• 563-563: Check that the image URL is accessible and the theme CSS values are valid. For example, on line 563, the image URL should point to a valid logo image for the network.

• 737-737: Confirm whether the leapExperimental property on line 737 accurately reflects the network's current support status for the Leap wallet. If the network is not in an experimental stage with Leap, this should be set to false.

• 763-763: Verify that the walletUrlForStaking on line 763 is a valid URL and points to an operational staking interface for the network.

• 769-769: Ensure that the coinGeckoId property, such as on line 769, matches the identifier used by CoinGecko for the respective cryptocurrency. This is important for fetching accurate price data.

• 753-753: Check that the coinType under the bip44 property is consistent across different network configurations and set appropriately. For example, on line 753, the coinType is set to 118, which should be validated against the network's specifications.

• 786-786: Confirm that the gradient property under theme on line 786 has a valid CSS gradient value and that it renders correctly in the application's UI.