Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add undelegate and redelegate txns in multisig #968

Merged
merged 9 commits into from
Dec 19, 2023

Conversation

charymalloju
Copy link
Contributor

@charymalloju charymalloju commented Dec 16, 2023

Summary by CodeRabbit

  • New Features

    • Introduced the ability to delete multisig accounts with user confirmation through new dialog components.
    • Added a new component to list all transactions associated with multisig accounts.
    • Implemented conditional rendering for different transaction types in the creation dialog.
  • Enhancements

    • Improved transaction broadcasting interface and user feedback with progress indicators.
    • Updated transaction cards to reflect new data properties and improved user interface.
    • Enhanced sidebar functionality to fetch and display account-specific multisig transactions more effectively.
  • Bug Fixes

    • Fixed logic in the delete transaction functionality to correctly reference multisig account properties.
    • Corrected styling inconsistencies across various transaction-related components.
  • Refactor

    • Restructured props and interfaces for better clarity and functionality in multisig components.
    • Optimized utility functions for address formatting and multisig membership checks.
  • Style

    • Updated CSS classes and styles to ensure a consistent and polished user interface.
  • Documentation

    • Updated type declarations to reflect new features and changes in the multisig functionality.

Copy link

vercel bot commented Dec 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-resolute ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 7:43am
resolute ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 7:43am

Copy link
Contributor

coderabbitai bot commented Dec 16, 2023

Walkthrough

The update enhances a multisig feature in a frontend application. It introduces a delete function for multisig accounts, a new component for listing all transactions, and updates to transaction handling and display components, such as adding conditional rendering and updating props. The changes also include new styles and utility functions to support these features, and the backend slice is updated to manage new actions and state changes related to multisig transaction deletion and retrieval.

Changes

File Path Changes
.../AllTransactionsList.tsx Added a new component AllTransactionsList and its associated functionality.
.../BroadCastTxn.tsx, .../DialogCreateTxn.tsx Restructured the BroadCastTxnProps interface and related variable assignments within the BroadCastTxn functional component. Added conditional rendering for UnDelegate and ReDelegate components based on the value of txType. Added FileUpload component to handle file uploads and parsing for different transaction types. Modified the DialogCreateTxn component to conditionally render UnDelegate and ReDelegate components based on the value of txType.
.../DeleteTxn.tsx Added a new property isMember to the DeleteTxnProps interface.
.../MultisigSidebar.tsx Modified the import statements and added a new dispatch call to getAccountAllMultisigTxns within the MultisigSidebar component.
.../PageMultisig.tsx, .../PageMultisigInfo.tsx Added resetDeleteMultisigRes import. Modified setError import to include resetError. Added a new useEffect block to reset errors and delete multisig response.
Added a resetError function call within a useEffect hook.
.../msgs/DelegateMessage.tsx Modified the parseBalance function call by removing the square brackets around msg.value.amount.
.../msgs/RedelegateMessage.tsx Reorganized the JSX structure, introduced new HTML elements and classes for styling. Added an Image component from the 'next/image' package to display icons. Introduced conditional rendering for the delete functionality, utilizing the Image component for the delete icon.
.../msgs/UndelegateMessage.tsx Added an Image import from 'next/image'. Reorganized the JSX structure within the return statement, including the addition of an image and changes to the layout and styling of the rendered content.
.../txns/Delegate.tsx Modified the structure of the amount property, modifying it from an object to an array. Removed the rounded-2xl mb-6 class from the TextField components, affecting their styling.
.../txns/ReDelegate.tsx, .../txns/UnDelegate.tsx Added a new file with significant content.
Added a new file with significant content.
.../multisigSlice.ts Introduces a new asynchronous action deleteMultisig and modifies the existing getTxns action within the multisigSlice.ts file. The deleteMultisig action handles the deletion of multisig transactions, and its corresponding logic for pending, fulfilled, and rejected states has been added to the reducer using builder.addCase. Additionally, the getAccountAllMultisigTxns action has been added to fetch account-specific multisig transactions, and its related logic has been incorporated into the reducer using builder.addCase.
.../multisig.d.ts In the multisig.d.ts file, a new declaration deleteMultisigRes of type TxRes has been added to the MultisigState interface. Additionally, the Txn interface has been updated to include optional fields pubkeys of type MultisigAddressPubkey[] and threshold of type number.
.../util.ts Modified the shortenAddress function to handle optional chaining for bech32 and address variables. Added a new function isMultisigMember to check if a wallet address is a member of a multisig using the provided pubkeys.
.../constants.ts Added multiple constants related to multisig transactions: MULTISIG_SEND_TEMPLATE, MULTISIG_DELEGATE_TEMPLATE, MULTISIG_UNDELEGATE_TEMPLATE, and MULTISIG_REDELEGATE_TEMPLATE, each assigned a URL pointing to a CSV file.
.../AccountInfo.tsx, .../DialogDeleteMultisig.tsx Import Modification: Additional import statements for useAppDispatch and deleteMultisig have been added.
Interface Modification: The AccountDetails component now includes a chainName property.
Functionality Addition: Two new functions, handleDeleteDialogClose and handleDelete, have been added to handle the delete dialog and initiate the delete action, respectively.
Component Addition: A new component, DialogDeleteMultisig, has been added.
Button Behavior Modification: The "Delete Multisig" button now triggers the opening of the delete dialog.
Component Integration: Integration of the DialogDeleteMultisig component to handle the delete action.
.../SignTxn.tsx, .../TransactionItem.tsx Added an import statement for CircularProgress from @mui/material and changes to the class name and button content within the SignTxn component. The class name is now conditionally set based on the value of isMember, and the button content is also conditionally set to display a loading spinner when load is true.
The addition of an Image import from 'next/image' and a significant reorganization of the JSX structure within the return statement, involving the addition of an image, changes to the layout, and styling of the rendered content.
server/handler/multisig.go, server/handler/transactions.go The unidiff snippet illustrates modifications in the DeleteMultisigAccount function within the multisig.go file. The changes involve the addition of a database deletion operation for pubkeys associated with a multisig address, followed by an error handling block. These alterations adjust the logic and control flow of the function to accommodate the new database operation.
The diff in server/handler/transactions.go involves significant changes to the SQL queries within the GetTransactions and GetAllMultisigTxns functions. The queries have been modified to include additional table joins, column selections, and conditional filtering based on transaction status, resulting in changes to the logic of data retrieval. Additionally, the type of the transactions variable has been updated from an array of schema.Transaction to an array of schema.AllTransactionResult.

🐇✨
A hop of code, a leap of features,
Multisig's dance, now with new creatures.
Delete and list, with UI so bright,
CodeRabbit's work, into the night. 🌙
✨🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 4

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ce8dcdc and 7f469e4.
Files selected for processing (6)
  • frontend/src/app/(routes)/multisig/components/DialogCreateTxn.tsx (3 hunks)
  • frontend/src/app/(routes)/multisig/components/msgs/RedelegateMessage.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/msgs/UndelegateMessage.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/txns/ReDelegate.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/txns/UnDelegate.tsx (1 hunks)
  • frontend/src/utils/util.ts (2 hunks)
Additional comments: 9
frontend/src/app/(routes)/multisig/components/DialogCreateTxn.tsx (2)
  • 43-44: The addition of UnDelegate and ReDelegate components is in line with the PR's objective to enhance multisig functionality. Ensure that these components are properly imported and used within the DialogCreateTxn component.

  • 298-322: The integration of UnDelegate and ReDelegate components with their respective props such as chainID, address, baseURL, and callback functions is correctly implemented. However, ensure that the console.log statements are intended for production or are for debugging purposes only and should be removed before merging.

frontend/src/app/(routes)/multisig/components/msgs/RedelegateMessage.tsx (2)
  • 10-46: The use of the Image component from 'next/image' for icons and the conditional rendering for the delete functionality appear to be correctly implemented. The Image component is used with appropriate attributes such as src, height, width, and alt. The conditional rendering for the delete icon is based on the presence of the onDelete prop, which is a common pattern in React for optional features.

However, there are a couple of points to consider:

  1. Ensure that the alt attribute for images provides descriptive text for screen readers. Currently, the alt attribute for the arrow icon is empty, which might not be ideal for accessibility.
  2. The hardcoded src paths for the icons (/solid-arrow-icon.svg and /delete-cross-icon.svg) assume that these assets are available at the root of the public directory. Confirm that these assets are correctly placed and accessible at the specified paths.
  • 22-34: The usage of parseBalance and shortenAddress utility functions seems appropriate for formatting balance and addresses. However, given the changes to shortenAddress to handle null or undefined values for the bech32 parameter, it's important to ensure that the msg.value.validatorSrcAddress and msg.value.validatorDstAddress are never null or undefined when passed to shortenAddress. If there's a possibility of these values being null or undefined, the code should handle these cases before calling shortenAddress.
frontend/src/app/(routes)/multisig/components/txns/ReDelegate.tsx (4)
  • 15-22: The ReDelegateProps interface has been correctly updated to include new properties necessary for the re-delegation functionality.

  • 50-52: The useEffect hook is correctly fetching delegations on component mount. Ensure that this is the intended behavior and that the delegations do not need to be updated based on any other changing values.

  • 156-157: The setAmountValue function correctly sets the form's amount value based on the selected validator's balance.

  • 301-301: The ReDelegate component is exported as the default export, aligning with the user's preference for default exports throughout the application.

frontend/src/utils/util.ts (1)
  • 137-145: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [137-154]

The function signature of shortenAddress has been updated to accept null or undefined as valid types for the bech32 parameter. It's important to verify that all calls to this function across the codebase have been updated to handle the new parameter types. This can be done by searching for usages of shortenAddress and ensuring that they are compatible with the new signature.

Verification successful

The output from the script shows the locations where shortenAddress is called. To ensure that these calls are compatible with the updated function signature that allows null or undefined, I need to examine the surrounding code for each call to see if there are checks for null or undefined before the function is called.

I will generate a script to extract the relevant surrounding code for each call to shortenAddress.


The output from the script shows that the calls to shortenAddress use optional chaining when accessing properties, which suggests that the code is written with the possibility of null or undefined values in mind. Since the function shortenAddress now explicitly handles null or undefined, it appears that the calls to this function are prepared for these cases.

However, it is ultimately the responsibility of the caller to ensure that the values passed to shortenAddress are handled appropriately. Given the function's new signature, it seems that the code is compatible with the updated function signature, and no explicit issues have been found in the calls to shortenAddress.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Search for usages of `shortenAddress` to ensure they handle `null` or `undefined`.
rg 'shortenAddress\(' --type ts

Length of output: 1940



Script:

#!/bin/bash
# Extract the surrounding code for each call to `shortenAddress` to check for null or undefined handling.

files=(
  "frontend/src/app/(routes)/multisig/components/msgs/DelegateMessage.tsx"
  "frontend/src/app/(routes)/multisig/components/msgs/UndelegateMessage.tsx"
  "frontend/src/app/(routes)/multisig/components/msgs/RedelegateMessage.tsx"
  "frontend/src/app/(routes)/multisig/components/msgs/TxnMsg.tsx"
  "frontend/src/app/(routes)/multisig/components/msgs/SendMessage.tsx"
  "frontend/src/app/(routes)/multisig/components/AllMultisigs.tsx"
  "frontend/src/app/(routes)/multisig/components/AccountInfo.tsx"
)

for file in "${files[@]}"; do
  echo "File: $file"
  rg -C 5 'shortenAddress\(' "$file"
  echo
done

Length of output: 6751

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 5

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7f469e4 and 5c3628b.
Files selected for processing (6)
  • frontend/src/app/(routes)/multisig/components/MultisigSidebar.tsx (4 hunks)
  • frontend/src/app/(routes)/multisig/components/TransactionCard.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/txns/ReDelegate.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/txns/UnDelegate.tsx (1 hunks)
  • frontend/src/store/features/multisig/multisigService.ts (2 hunks)
  • frontend/src/store/features/multisig/multisigSlice.ts (2 hunks)
Additional comments: 16
frontend/src/app/(routes)/multisig/components/MultisigSidebar.tsx (7)
  • 3-3: The addition of getAccountAllMultisigTxns alongside getTxns suggests an expansion of functionality. Ensure that the new function is integrated correctly and that existing features are not adversely affected by this change.

  • 54-55: The new dispatch call to getAccountAllMultisigTxns is added to handle cases when accountSpecific is false. Verify that the logic for when to call getAccountAllMultisigTxns versus getTxns is correct and that the parameters provided match the expected input for the function.

  • 196-210: The conditional rendering based on accountSpecific has been updated to render TransactionsList and DialogCreateTxn components. Ensure that the components are receiving the correct props and that the conditional logic aligns with the intended behavior.

  • 28-31: The useEffect hooks are used to manage state updates and side effects. Confirm that the dependencies for each useEffect are correctly specified to avoid unnecessary re-renders or missed updates.

  • 28-31: Review the error handling within the useEffect hooks to ensure consistency and clarity of the error messages being dispatched. Confirm that the messages are informative and user-friendly.

  • 28-31: Verify that the calls to getAllTxs within the useEffect hooks are made at the appropriate times and that the transaction status is being managed correctly to ensure the transaction list is updated accurately.

  • 213-213: The MultisigSidebar component is correctly exported as a default export, aligning with the user's preference for default exports throughout the application.

frontend/src/app/(routes)/multisig/components/TransactionCard.tsx (3)
  • 140-140: The updated logic to determine the address for the DeleteTxn component introduces a fallback to txn?.multisig_address if multisigAccount.account.address is not available. Verify that txn?.multisig_address is always a valid and appropriate fallback and that this change does not introduce any unintended behavior, such as allowing deletion of transactions by unauthorized addresses.

  • 137-143: The changes within this hunk appear to be consistent with the rest of the component's logic and do not introduce any syntax errors or security concerns. The use of optional chaining is appropriate for handling potential null or undefined values.

  • 137-143: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-143]

Given the broader context of the PR, which aims to enhance multisig functionality, the rest of the file should be reviewed to ensure that all changes align with the objective of adding undelegate and redelegate transactions and that they integrate well with the existing codebase. This includes verifying that the new logic for the address property in the DeleteTxn component does not conflict with the new multisig features.

frontend/src/app/(routes)/multisig/components/txns/ReDelegate.tsx (1)
  • 301-301: The use of default export is consistent with the user's preference.
frontend/src/store/features/multisig/multisigService.ts (3)
  • 93-99: The addition of getAccountAllMultisigTxns function is consistent with the existing code style and correctly constructs the URI with the status query parameter.

  • 121-121: The inclusion of getAccountAllMultisigTxns in the default export object aligns with the project's preference for default exports.

  • 90-91: The getTxns function now accepts a status parameter, which is a change that aligns with the new getAccountAllMultisigTxns function, allowing for status-based filtering of transactions.

frontend/src/store/features/multisig/multisigSlice.ts (2)
  • 235-247: The implementation of getAccountAllMultisigTxns follows the pattern of existing async actions and correctly handles both the success and error cases. It uses the multisigService.getAccountAllMultisigTxns method to fetch data and properly handles AxiosError instances.

  • 448-463: The reducer logic for getAccountAllMultisigTxns correctly handles the pending, fulfilled, and rejected states. It updates the txns state slice with the appropriate status and error messages, and in the case of a fulfilled action, it updates the list of transactions.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 9

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 5c3628b and d6936f5.
Files selected for processing (6)
  • frontend/src/app/(routes)/multisig/components/AccountInfo.tsx (5 hunks)
  • frontend/src/app/(routes)/multisig/components/DialogDeleteMultisig.tsx (1 hunks)
  • frontend/src/store/features/multisig/multisigService.ts (3 hunks)
  • frontend/src/store/features/multisig/multisigSlice.ts (4 hunks)
  • frontend/src/types/multisig.d.ts (1 hunks)
  • server/handler/multisig.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • frontend/src/store/features/multisig/multisigSlice.ts
Additional comments: 10
frontend/src/app/(routes)/multisig/components/AccountInfo.tsx (6)
  • 1-2: The import modifications are consistent with the PR's objectives to enhance multisig functionality.

  • 14-15: The addition of the chainName property to the AccountInfoProps interface is consistent with the PR's objectives.

  • 110-137: Ensure that the deletion process is robustly handled, including proper error handling and state management, especially considering the previous learnings about error handling in the PageMultisig and createMultisigForm components.

  • 11-12: The addition of DialogDeleteTxn and DialogDeleteMultisig components aligns with the PR's objectives to manage transaction deletion within the multisig component.

  • 204-206: The "Delete Multisig" button's new behavior to trigger the delete dialog is consistent with the PR's objectives to enhance multisig functionality.

  • 210-214: Verify that the DialogDeleteMultisig component is correctly integrated with the appropriate props to handle the delete action as intended.

frontend/src/store/features/multisig/multisigService.ts (3)
  • 93-99: The implementation of getAccountAllMultisigTxns follows the existing pattern for API calls and correctly constructs the URI with the status parameter. This addition should enable the fetching of all multisig transactions with a specified status.

  • 127-133: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [121-133]

The exported default object has been correctly updated to include the new getAccountAllMultisigTxns and deleteMultisig functions, ensuring they are available for import elsewhere in the application.

  • 78-83: Refactoring of the updateTx function to use the SIGNATURE_PARAMS_STRING for URI construction is consistent with the pattern used in other functions within the service, improving code maintainability.
frontend/src/types/multisig.d.ts (1)
  • 116-116: The addition of deleteMultisigRes to the MultisigState interface is consistent with the PR's objective to enhance the multisig functionality and is aligned with the existing structure of the interface.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 6

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between d6936f5 and 351fdc7.
Files selected for processing (5)
  • frontend/src/app/(routes)/multisig/components/AccountInfo.tsx (5 hunks)
  • frontend/src/store/features/multisig/multisigService.ts (3 hunks)
  • server/handler/transactions.go (4 hunks)
  • server/model/transactions.go (1 hunks)
  • server/schema/transactions.go (1 hunks)
Files skipped from review due to trivial changes (1)
  • server/model/transactions.go
Files skipped from review as they are similar to previous changes (1)
  • frontend/src/store/features/multisig/multisigService.ts
Additional comments: 10
frontend/src/app/(routes)/multisig/components/AccountInfo.tsx (1)
  • 133-135: Verify if the hardcoded id: 0 in the deleteMultisig dispatch call is intentional and correct for all use cases.
server/handler/transactions.go (2)
  • 231-234: Ensure that proper authorization checks are in place before allowing a user to sign a transaction in SignTransaction.

  • 216-234: Validate the new transaction status in UpdateTransactionInfo to ensure it's an allowed status before updating the database.

server/schema/transactions.go (7)
  • 11-11: The change from json.RawMessage to *json.RawMessage for the Fee field in the Transaction struct allows for null values, which is consistent with the PR's objective to enhance multisig functionality.

  • 27-27: Changing the Messages field to a pointer type (*json.RawMessage) in AllTransactionResult struct may imply that the field is optional and can be null.

  • 34-35: The addition of Threshold and Pubkeys fields to the AllTransactionResult struct is likely related to the new multisig functionality, allowing for the representation of multisig transaction requirements.

  • 31-31: The change from json.RawMessage to *json.RawMessage for the Signatures field in the AllTransactionResult struct allows for null values, which aligns with the PR's objective to enhance multisig functionality.

  • 25-25: The addition of omitempty to the Fee field's JSON tag in AllTransactionResult struct is a good practice to exclude the field from the JSON output if it's null or the zero value.

  • 32-33: The addition of omitempty to the LastUpdated and CreatedAt fields' JSON tags in AllTransactionResult struct is a good practice to exclude the fields from the JSON output if they are null or the zero value.

  • 9-35: Verify that the changes to the Transaction and AllTransactionResult structs are properly handled in database queries, JSON serialization, and deserialization throughout the codebase.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 8

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 351fdc7 and 8c32652.
Files selected for processing (1)
  • server/handler/transactions.go (3 hunks)
Additional comments: 1
server/handler/transactions.go (1)
  • 132-148: The usage of the transactions variable as a slice of schema.AllTransactionResult seems correct and matches the updated type.

* chore: resolve lint issues

* fix: fix all multisigs txn issues

* chore: fix lint issues

* chore(multisig): ui fixes

* chore

* chore: review changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 16

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8c32652 and 7cc3032.
Files selected for processing (20)
  • frontend/src/app/(routes)/multisig/components/AccountInfo.tsx (5 hunks)
  • frontend/src/app/(routes)/multisig/components/AllTransactionsList.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/BroadCastTxn.tsx (9 hunks)
  • frontend/src/app/(routes)/multisig/components/DeleteTxn.tsx (2 hunks)
  • frontend/src/app/(routes)/multisig/components/DialogCreateTxn.tsx (7 hunks)
  • frontend/src/app/(routes)/multisig/components/DialogViewTxnMessages.tsx (4 hunks)
  • frontend/src/app/(routes)/multisig/components/MultisigSidebar.tsx (5 hunks)
  • frontend/src/app/(routes)/multisig/components/SignTxn.tsx (2 hunks)
  • frontend/src/app/(routes)/multisig/components/TransactionCard.tsx (5 hunks)
  • frontend/src/app/(routes)/multisig/components/TransactionItem.tsx (5 hunks)
  • frontend/src/app/(routes)/multisig/components/TransactionsList.tsx (2 hunks)
  • frontend/src/app/(routes)/multisig/components/txns/Delegate.tsx (3 hunks)
  • frontend/src/app/(routes)/multisig/components/txns/ReDelegate.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/txns/Send.tsx (3 hunks)
  • frontend/src/app/(routes)/multisig/components/txns/UnDelegate.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/multisig.css (2 hunks)
  • frontend/src/app/(routes)/multisig/styles.ts (6 hunks)
  • frontend/src/store/features/multisig/multisigSlice.ts (6 hunks)
  • frontend/src/types/multisig.d.ts (3 hunks)
  • frontend/src/utils/util.ts (4 hunks)
Files skipped from review due to trivial changes (2)
  • frontend/src/app/(routes)/multisig/components/txns/Delegate.tsx
  • frontend/src/app/(routes)/multisig/multisig.css
Files skipped from review as they are similar to previous changes (3)
  • frontend/src/app/(routes)/multisig/components/DialogCreateTxn.tsx
  • frontend/src/app/(routes)/multisig/components/MultisigSidebar.tsx
  • frontend/src/store/features/multisig/multisigSlice.ts
Additional comments: 38
frontend/src/app/(routes)/multisig/components/AccountInfo.tsx (4)
  • 13-14: The addition of the chainName property to the AccountInfoProps interface aligns with the PR's objective to enhance multisig functionality.

  • 125-130: The useEffect hook to handle the deletion of the multisig account upon the deleteMultisigRes status change is a good practice for managing side effects in response to state changes.

  • 203-205: The "Delete Multisig" button's onClick event handler to set the delete dialog state is consistent with the PR's objective to introduce delete functionality.

  • 209-213: The integration of the DialogDeleteMultisig component to handle the delete action is consistent with the PR's objective to enhance the multisig account management interface.

frontend/src/app/(routes)/multisig/components/DeleteTxn.tsx (3)
  • 10-13: The addition of the isMember property to the DeleteTxnProps interface aligns with the PR's objective to manage multisig transactions and is correctly implemented in the component.

  • 44-47: The conditional disabling of the delete button based on the isMember property is a sensible addition, ensuring that only members can perform delete operations.

  • 10-20: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [20-27]

Ensure that the authToken is handled securely throughout the application, especially since it's used in a network request.

frontend/src/app/(routes)/multisig/components/DialogViewTxnMessages.tsx (3)
  • 4-4: The import statement change aligns with the PR's objectives and the updated component props.

  • 11-19: The props interface has been updated correctly according to the PR's objectives and the AI-generated summary.

  • 94-101: The TransactionItem component now correctly receives the updated props, which is in line with the PR's objectives and the AI-generated summary.

frontend/src/app/(routes)/multisig/components/SignTxn.tsx (2)
  • 11-11: The import of CircularProgress is correctly added and used within the component.

  • 102-110: The conditional rendering of the button's class name and content based on isMember and load is implemented correctly.

frontend/src/app/(routes)/multisig/components/TransactionCard.tsx (4)
  • 12-19: The TransactionCardProps interface has been updated with new properties multisigAddress and threshold, which aligns with the PR's objective to enhance multisig functionality.

  • 42-45: The isReadyToBroadcast function's logic correctly checks if the number of signatures meets the threshold for broadcasting a multisig transaction.

  • 85-99: The BroadCastTxn and SignTxn components have been updated to receive multisigAddress and threshold as props, which is consistent with the changes made to the TransactionCardProps interface.

  • 143-147: The DeleteTxn component has been updated to receive multisigAddress and isMember as props, which is consistent with the changes made to the TransactionCardProps interface.

frontend/src/app/(routes)/multisig/components/TransactionItem.tsx (4)
  • 13-20: The addition of multisigAddress, pubKeys, and threshold props to TransactionItemProps is consistent with the PR's objective to handle multisig transactions more effectively.

  • 41-44: The update to the isReadyToBroadcast function to use the threshold prop directly is a logical change that aligns with the PR's objectives.

  • 108-122: The BroadCastTxn and SignTxn components are receiving new props (multisigAddress, pubKeys, threshold, isMember) which are necessary for the multisig functionality. Ensure that these components are properly updated to handle these new props.

  • 149-149: The addition of the isMember prop to the DeleteTxn component is consistent with the PR's objective and should help in managing the deletion of multisig transactions based on user permissions.

frontend/src/app/(routes)/multisig/components/txns/Send.tsx (1)
  • 63-69: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [63-143]

Overall, the changes in the Send.tsx file are stylistic and involve adding a background color style to the TextField components. There are no alterations to the declarations of exported or public entities, and the changes do not introduce any functional issues.

frontend/src/app/(routes)/multisig/components/txns/UnDelegate.tsx (7)
  • 15-22: The UnDelegateProps interface has been updated with new properties. Ensure that all usages of the UnDelegate component have been updated to pass the new required props.

  • 50-52: The useEffect hook is used to dispatch getDelegations on component mount. Verify that there are no side effects or performance issues with fetching delegations on every mount of this component.

  • 63-102: The useEffect hook is used to populate the data state with validator information. Ensure that the validators dependency is stable to prevent unnecessary re-renders or effect executions.

  • 104-130: The onSubmit function constructs a message object for undelegation. Ensure that the message structure aligns with the expected format for the onDelegate callback and that the domain logic is correctly implemented.

  • 132-133: The setAmountValue function sets the form's amount value. Ensure that this does not introduce any unexpected behavior when the user manually enters a value and then selects a validator.

  • 176-177: The onChange handler for the Autocomplete component sets the selected validator's balance. Ensure that the balance is correctly formatted and that the division by 10 ** currency.coinDecimals is appropriate for all possible values of currency.coinDecimals.

  • 205-205: The validation for the amount field ensures that the value is greater than 0 and less than or equal to the selected validator's balance. Confirm that this validation logic is consistent with the business rules for undelegation amounts.

frontend/src/app/(routes)/multisig/styles.ts (7)
  • 14-15: The addition of mb and borderRadius properties to textFieldStyles is consistent with the summary and appears to follow a design update. Ensure that these changes align with the design requirements.

  • 31-32: The changes to autoCompleteStyles are consistent with the summary and appear to be part of a design update. Verify that these changes do not affect the layout or functionality of components using these styles in an unintended way.

  • 44-44: The addition of borderRadius to autoCompleteTextFieldStyles is consistent with the summary. Ensure that this change is reflected in the UI as expected.

  • 59-60: The addition of mb and borderRadius to sendTxnTextFieldStyles is consistent with the summary. Verify that the margin and border radius are applied correctly in the UI.

  • 90-91: The changes to createMultisigTextFieldStyles are not mentioned in the summary. Verify that the addition of mb and borderRadius is intentional and aligns with design specifications.

  • 113-114: The addition of borderRadius and mb to selectTxnStyles is consistent with the summary. Verify that these changes are consistent with the intended design and do not introduce any layout issues.

  • 117-117: No changes were made to dialogTxnFailedStyles as indicated by the summary. This is correct as per the provided context.

frontend/src/types/multisig.d.ts (1)
  • 207-212: The DeleteMultisigInputs interface has been added. Ensure that this interface is correctly used wherever required and that all necessary fields are included.
frontend/src/utils/util.ts (2)
  • 338-343: The new utility function isMultisigMember correctly checks for membership by comparing walletAddress with the addresses in pubkeys.

  • 334-343: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [3-343]

Verify that the changes to public and exported entities do not break existing contracts and that all usages have been updated to reflect the new interfaces.

* chore: resolve lint issues

* fix: fix all multisigs txn issues

* chore: fix lint issues

* chore(multisig): ui fixes

* chore

* chore: review changes

* wip

* feat(multisig): add file upload txn

* chore: add resetError

* chore: fix
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 4

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7cc3032 and dc79d71.
Files selected for processing (14)
  • frontend/src/app/(routes)/multisig/components/AllTransactionsList.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/DialogCreateTxn.tsx (13 hunks)
  • frontend/src/app/(routes)/multisig/components/MultisigSidebar.tsx (5 hunks)
  • frontend/src/app/(routes)/multisig/components/PageMultisig.tsx (2 hunks)
  • frontend/src/app/(routes)/multisig/components/PageMultisigInfo.tsx (2 hunks)
  • frontend/src/app/(routes)/multisig/components/msgs/DelegateMessage.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/msgs/RedelegateMessage.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/msgs/UndelegateMessage.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/txns/Delegate.tsx (4 hunks)
  • frontend/src/app/(routes)/multisig/components/txns/ReDelegate.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/txns/UnDelegate.tsx (1 hunks)
  • frontend/src/store/features/multisig/multisigSlice.ts (8 hunks)
  • frontend/src/utils/constants.ts (1 hunks)
  • frontend/src/utils/parseMsgs.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • frontend/src/app/(routes)/multisig/components/txns/Delegate.tsx
Files skipped from review as they are similar to previous changes (6)
  • frontend/src/app/(routes)/multisig/components/AllTransactionsList.tsx
  • frontend/src/app/(routes)/multisig/components/MultisigSidebar.tsx
  • frontend/src/app/(routes)/multisig/components/msgs/RedelegateMessage.tsx
  • frontend/src/app/(routes)/multisig/components/msgs/UndelegateMessage.tsx
  • frontend/src/app/(routes)/multisig/components/txns/ReDelegate.tsx
  • frontend/src/store/features/multisig/multisigSlice.ts
Additional comments: 23
frontend/src/app/(routes)/multisig/components/DialogCreateTxn.tsx (15)
  • 4-11: The import statements for MULTISIG_DELEGATE_TEMPLATE, MULTISIG_REDELEGATE_TEMPLATE, MULTISIG_SEND_TEMPLATE, and MULTISIG_UNDELEGATE_TEMPLATE are added. Ensure that these constants are used correctly in the file and that the URLs they point to are valid and accessible.

  • 17-24: The import of Tooltip and IconButton components from @mui/material is added. Verify that these components are used appropriately within the file for user interface enhancements.

  • 49-57: New imports for UnDelegate, ReDelegate, and parsing functions from @/utils/parseMsgs are added. Ensure that these components and functions are integrated correctly and that the parsing functions handle the file contents as expected.

  • 69-73: The FileUploadProps interface and the FileUpload component are added. Check that the onFileContents, resetMessages, and txType props are used correctly and that the component is integrated properly within the DialogCreateTxn component.

  • 97-100: The onClick handler for the clear icon button within the FileUpload component should prevent event propagation to avoid unintended side effects. Confirm that stopping propagation is the intended behavior and does not interfere with other click events.

  • 119-145: The file input change handler is responsible for reading the uploaded file's contents and invoking the onFileContents callback with the file contents and transaction type. Ensure that the file reading process is robust and handles errors gracefully, and that the file contents are processed correctly based on the transaction type.

  • 152-184: The onClick handler for downloading sample CSV files based on the transaction type should be reviewed for potential security concerns. Ensure that the URLs provided in the constants are secure and that the window opening behavior is consistent with the application's security policies.

  • 225-225: The baseURL property from the getChainInfo hook is used here. Verify that this property is consistently used throughout the application and that the URL is correctly configured for the environment.

  • 273-279: The resetMessages function and its usage in a useEffect hook are added to reset messages when the isFileUpload state changes. Ensure that this behavior is intended and does not lead to loss of user data unintentionally.

  • 322-391: The onFileContents function is responsible for parsing the contents of uploaded files based on the transaction type. Ensure that the parsing functions (parseSendMsgsFromContent, parseDelegateMsgsFromContent, parseReDelegateMsgsFromContent, parseUnDelegateMsgsFromContent) are correctly implemented and handle all edge cases, including error handling.

  • 454-490: The transaction type selection logic is implemented with a Select component. Ensure that the txType state is managed correctly and that the transaction type selection updates the UI as expected.

  • 523-545: Conditional rendering is used to display UnDelegate and ReDelegate components based on the txType state. Verify that the components are rendered correctly for each transaction type and that the props passed to these components are appropriate.

  • 570-573: The Pagination component is used to manage message pagination. Ensure that the pagination logic is correct and that the currentPage and slicedMsgs states are updated appropriately when the page changes.

  • 594-597: The TextField component for gas input is styled with a background color. Verify that the styling is consistent with the application's design system and that the input validation for gas is correctly implemented.

  • 621-624: The TextField component for memo input is styled with a background color. Verify that the styling is consistent with the application's design system and that the memo input is handled correctly in the form submission.

frontend/src/app/(routes)/multisig/components/PageMultisig.tsx (3)
  • 8-13: The imports for resetDeleteMultisigRes and resetError are added. Verify that these actions are dispatched correctly to reset the relevant state when the component is unmounted or when specific events occur.

  • 72-75: A new useEffect hook is added to reset errors and delete multisig response when the component is mounted. Ensure that this side effect does not interfere with the user's experience and that it is the intended behavior.

  • 5-16: Given the learning that error handling for the verifyAccount dispatch is managed within the PageMultisig component itself, ensure that the new useEffect hooks for resetting errors and responses do not conflict with the existing error handling logic.

frontend/src/app/(routes)/multisig/components/PageMultisigInfo.tsx (2)
  • 13-16: The resetError function is imported and used within a useEffect hook. Verify that this function is called at the appropriate times to reset errors without affecting the user's experience negatively.

  • 108-109: The useEffect hook for resetting errors is added. Confirm that this is the desired behavior and that it does not inadvertently clear errors that should be displayed to the user.

frontend/src/app/(routes)/multisig/components/msgs/DelegateMessage.tsx (1)
  • 23-23: The parseBalance function call is modified to remove the square brackets around msg.value.amount. Ensure that this change correctly reflects the expected input for the parseBalance function and that the balance is parsed correctly.
frontend/src/utils/constants.ts (1)
  • 85-92: New constants for multisig transaction templates are added. Verify that these URLs point to the correct CSV templates and that they are used appropriately within the application.
frontend/src/utils/parseMsgs.ts (1)
  • 24-24: The loop in parseSendMsgsFromContent now starts from index 0 instead of 1. Confirm that this change correctly includes the first message in the parsing process and that no off-by-one errors are introduced.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between dc79d71 and 4008c67.
Files selected for processing (1)
  • frontend/src/utils/constants.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • frontend/src/utils/constants.ts

@charymalloju charymalloju merged commit 9a42b40 into dev Dec 19, 2023
@charymalloju charymalloju deleted the chary/un-re-delegate-txns branch December 19, 2023 07:43
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 4

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 4008c67 and 9cff1d6.
Files selected for processing (10)
  • frontend/src/app/(routes)/multisig/components/AccountInfo.tsx (5 hunks)
  • frontend/src/app/(routes)/multisig/components/DialogDeleteMultisig.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/SignTxn.tsx (2 hunks)
  • frontend/src/app/(routes)/multisig/components/TransactionItem.tsx (5 hunks)
  • frontend/src/app/(routes)/multisig/components/msgs/UndelegateMessage.tsx (1 hunks)
  • frontend/src/app/(routes)/multisig/components/txns/ReDelegate.tsx (1 hunks)
  • frontend/src/types/multisig.d.ts (4 hunks)
  • frontend/src/utils/util.ts (4 hunks)
  • server/handler/multisig.go (1 hunks)
  • server/handler/transactions.go (3 hunks)
Files skipped from review due to trivial changes (2)
  • frontend/src/app/(routes)/multisig/components/DialogDeleteMultisig.tsx
  • frontend/src/app/(routes)/multisig/components/SignTxn.tsx
Files skipped from review as they are similar to previous changes (2)
  • frontend/src/types/multisig.d.ts
  • server/handler/multisig.go
Additional comments: 22
frontend/src/app/(routes)/multisig/components/AccountInfo.tsx (9)
  • 1-2: The addition of useAppDispatch and deleteMultisig imports suggests new functionality related to state management and deletion actions has been introduced.

  • 13-13: The AccountInfoProps interface has been correctly updated to include the chainName property, aligning with the PR's objective to handle multisig transactions.

  • 11-11: The addition of DialogDeleteMultisig component import indicates a new dialog component for deletion functionality has been introduced.

  • 78-78: The chainName prop is being passed to the AccountDetails component, which is necessary for routing and display purposes.

  • 109-110: The useState hook for deleteDialogOpen and the useAppDispatch hook are introduced to manage the state of the delete dialog and dispatch actions, respectively. Ensure that the delete functionality is thoroughly tested to prevent accidental deletions.

  • 121-122: The handleDeleteDialogClose function is used to close the delete dialog. It's important to ensure that this function is called in all scenarios where the dialog should be closed for a consistent user experience.

  • 125-130: The useEffect hook is used to listen for changes in deleteMultisigRes.status and close the delete dialog when the status is 'idle'. This is a good use of the useEffect hook to react to state changes.

  • 132-137: The handleDelete function dispatches the deleteMultisig action. It's crucial to ensure that the action is dispatched with the correct parameters and that error handling is in place for failed deletion attempts.

  • 203-213: The "Delete Multisig" button now has an onClick event to open the delete dialog, and the DialogDeleteMultisig component is integrated with the necessary props. It's important to verify that the dialog behaves correctly and that the delete action is only performed after user confirmation.

frontend/src/app/(routes)/multisig/components/TransactionItem.tsx (5)
  • 1-17: The imports and interface changes suggest that the TransactionItem component now handles the display and interaction logic for multisig transactions, including delegation and signing. Ensure that the new logic correctly handles the multisig transaction data.

  • 43-43: The isReadyToBroadcast function checks if the number of signatures meets the threshold. It's important to ensure that this logic is accurate and that the transaction is only broadcast when it's ready.

  • 47-54: The useState and useEffect hooks are used to determine if the wallet address is a member of the multisig and set the isMember state accordingly. This is a critical piece of logic that should be tested to ensure that only authorized members can sign transactions.

  • 107-110: The BroadCastTxn component is being passed new props related to multisig functionality. It's important to verify that these props are being used correctly within the component to handle broadcasting multisig transactions.

  • 145-145: The DeleteTxn component now receives the isMember prop, which likely controls whether the delete option is available based on the user's membership status in the multisig. Ensure that this prop is being used correctly to prevent unauthorized deletion actions.

frontend/src/app/(routes)/multisig/components/msgs/UndelegateMessage.tsx (2)
  • 4-4: The import of Image from 'next/image' suggests that images are now being used within the UndelegateMessage component, likely for visual enhancement.

  • 10-42: The JSX structure has been significantly reorganized to include an image and additional spans for formatting the undelegate message. It's important to ensure that the layout and styling changes are consistent with the application's design guidelines.

frontend/src/app/(routes)/multisig/components/txns/ReDelegate.tsx (4)
  • 1-22: The introduction of several hooks and the ReDelegateProps interface indicates that the ReDelegate component is responsible for handling the re-delegation of staked tokens within a multisig context. Ensure that the re-delegation logic is correctly implemented and thoroughly tested.

  • 132-164: The onSubmit function constructs a re-delegation message and calls the onDelegate callback with the message. It's critical to ensure that the message structure is correct and that the re-delegation process is handled securely.

  • 166-170: The setAmountValue function sets the amount to re-delegate based on the selected validator balance. It's important to verify that the balance is correctly retrieved and that the amount is set accurately to prevent errors in re-delegation.

  • 172-321: The form structure and the use of Controller components from react-hook-form suggest a complex form handling scenario. Ensure that all form fields are validated and that the form submission process adheres to best practices for form handling in React.

frontend/src/utils/util.ts (2)
  • 141-143: The shortenAddress function now uses optional chaining and conditional assignment to handle potentially undefined bech32 strings. This is a good defensive programming practice to prevent runtime errors.

  • 338-343: The new isMultisigMember function checks if a wallet address is part of the multisig's pubkeys. It's important to ensure that this function is used correctly to enforce multisig membership rules throughout the application.

Comment on lines +107 to +115
defer rows.Close()
if status == model.Pending {
rows, err = h.DB.Query(`SELECT id,multisig_address,fee,status,created_at,messages,hash,
err_msg,last_updated,memo,signatures FROM transactions WHERE multisig_address=$1 AND status=$2 LIMIT $3 OFFSET $4`, address, status, limit, (page-1)*limit)
rows, err = h.DB.Query(`SELECT t.id,t.multisig_address,t.status,t.created_at,t.last_updated,t.memo,t.signatures,t.messages,t.hash,t.err_msg,t.fee, m.threshold,
json_agg(jsonb_build_object('pubkey', p.pubkey, 'address', p.address, 'multisig_address',p.multisig_address)) AS pubkeys FROM transactions t JOIN multisig_accounts m ON t.multisig_address = m.address JOIN pubkeys p ON t.multisig_address = p.multisig_address WHERE t.multisig_address=$1 and t.status='PENDING' GROUP BY t.id, t.multisig_address, m.threshold, t.messages LIMIT $2 OFFSET $3`,
address, limit, (page-1)*limit)
} else {
rows, err = h.DB.Query(`SELECT id,multisig_address,fee,status,created_at,messages,hash,
err_msg,last_updated,memo,signatures FROM transactions WHERE multisig_address=$1 AND status<>$2 LIMIT $3 OFFSET $4`, address, model.Pending, limit, (page-1)*limit)
rows, err = h.DB.Query(`SELECT t.id,t.multisig_address,t.status,t.created_at,t.last_updated,t.memo,t.signatures,t.messages,t.hash,t.err_msg,t.fee, m.threshold,
json_agg(jsonb_build_object('pubkey', p.pubkey, 'address', p.address, 'multisig_address',p.multisig_address)) AS pubkeys FROM transactions t JOIN multisig_accounts m ON t.multisig_address = m.address JOIN pubkeys p ON t.multisig_address = p.multisig_address WHERE t.multisig_address=$1 and t.status <> 'PENDING' GROUP BY t.id, t.multisig_address, m.threshold, t.messages LIMIT $2 OFFSET $3`,
address, limit, (page-1)*limit)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SQL queries in both GetTransactions and GetAllMultisigTxns functions have been updated to include additional joins and a conditional filter based on transaction status. Ensure that the GROUP BY clause includes all non-aggregated columns present in the SELECT clause to avoid unpredictable results.

- GROUP BY t.id, t.multisig_address, m.threshold, t.messages
+ GROUP BY t.id, t.multisig_address, m.threshold, t.messages, t.status, t.created_at, t.last_updated, t.memo, t.signatures, t.hash, t.err_msg, t.fee

Committable suggestion

IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
defer rows.Close()
if status == model.Pending {
rows, err = h.DB.Query(`SELECT id,multisig_address,fee,status,created_at,messages,hash,
err_msg,last_updated,memo,signatures FROM transactions WHERE multisig_address=$1 AND status=$2 LIMIT $3 OFFSET $4`, address, status, limit, (page-1)*limit)
rows, err = h.DB.Query(`SELECT t.id,t.multisig_address,t.status,t.created_at,t.last_updated,t.memo,t.signatures,t.messages,t.hash,t.err_msg,t.fee, m.threshold,
json_agg(jsonb_build_object('pubkey', p.pubkey, 'address', p.address, 'multisig_address',p.multisig_address)) AS pubkeys FROM transactions t JOIN multisig_accounts m ON t.multisig_address = m.address JOIN pubkeys p ON t.multisig_address = p.multisig_address WHERE t.multisig_address=$1 and t.status='PENDING' GROUP BY t.id, t.multisig_address, m.threshold, t.messages LIMIT $2 OFFSET $3`,
address, limit, (page-1)*limit)
} else {
rows, err = h.DB.Query(`SELECT id,multisig_address,fee,status,created_at,messages,hash,
err_msg,last_updated,memo,signatures FROM transactions WHERE multisig_address=$1 AND status<>$2 LIMIT $3 OFFSET $4`, address, model.Pending, limit, (page-1)*limit)
rows, err = h.DB.Query(`SELECT t.id,t.multisig_address,t.status,t.created_at,t.last_updated,t.memo,t.signatures,t.messages,t.hash,t.err_msg,t.fee, m.threshold,
json_agg(jsonb_build_object('pubkey', p.pubkey, 'address', p.address, 'multisig_address',p.multisig_address)) AS pubkeys FROM transactions t JOIN multisig_accounts m ON t.multisig_address = m.address JOIN pubkeys p ON t.multisig_address = p.multisig_address WHERE t.multisig_address=$1 and t.status <> 'PENDING' GROUP BY t.id, t.multisig_address, m.threshold, t.messages LIMIT $2 OFFSET $3`,
address, limit, (page-1)*limit)
defer rows.Close()
if status == model.Pending {
rows, err = h.DB.Query(`SELECT t.id,t.multisig_address,t.status,t.created_at,t.last_updated,t.memo,t.signatures,t.messages,t.hash,t.err_msg,t.fee, m.threshold,
json_agg(jsonb_build_object('pubkey', p.pubkey, 'address', p.address, 'multisig_address',p.multisig_address)) AS pubkeys FROM transactions t JOIN multisig_accounts m ON t.multisig_address = m.address JOIN pubkeys p ON t.multisig_address = p.multisig_address WHERE t.multisig_address=$1 and t.status='PENDING' GROUP BY t.id, t.multisig_address, m.threshold, t.messages, t.status, t.created_at, t.last_updated, t.memo, t.signatures, t.hash, t.err_msg, t.fee LIMIT $2 OFFSET $3`,
address, limit, (page-1)*limit)
} else {
rows, err = h.DB.Query(`SELECT t.id,t.multisig_address,t.status,t.created_at,t.last_updated,t.memo,t.signatures,t.messages,t.hash,t.err_msg,t.fee, m.threshold,
json_agg(jsonb_build_object('pubkey', p.pubkey, 'address', p.address, 'multisig_address',p.multisig_address)) AS pubkeys FROM transactions t JOIN multisig_accounts m ON t.multisig_address = m.address JOIN pubkeys p ON t.multisig_address = p.multisig_address WHERE t.multisig_address=$1 and t.status <> 'PENDING' GROUP BY t.id, t.multisig_address, m.threshold, t.messages, t.status, t.created_at, t.last_updated, t.memo, t.signatures, t.hash, t.err_msg, t.fee LIMIT $2 OFFSET $3`,
address, limit, (page-1)*limit)

@@ -104,12 +104,15 @@

status := utils.GetStatus(c.QueryParam("status"))
var rows *sql.Rows
defer rows.Close()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defer rows.Close() statement should be placed immediately after the error check for the Query method to ensure that the rows are always closed, even if an error occurs during row processing.

- defer rows.Close()
+ if rows != nil {
+   defer rows.Close()
+ }

Committable suggestion

IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
defer rows.Close()
if rows != nil {
defer rows.Close()
}

Comment on lines +200 to +207
if status == "PENDING" {
rows, err = h.DB.Query(`SELECT t.id,t.multisig_address,t.status,t.created_at,t.last_updated,t.memo,t.signatures,t.messages,t.hash,t.err_msg,t.fee, m.threshold,
json_agg(jsonb_build_object('pubkey', p.pubkey, 'address', p.address, 'multisig_address',p.multisig_address)) AS pubkeys FROM transactions t JOIN multisig_accounts m ON t.multisig_address = m.address JOIN pubkeys p ON t.multisig_address = p.multisig_address WHERE t.multisig_address=$1 and t.status='PENDING' GROUP BY t.id, t.multisig_address, m.threshold, t.messages LIMIT $2 OFFSET $3`,
multisigAddress, limit, (page-1)*limit)
} else {
rows, err = h.DB.Query(`SELECT t.id,t.multisig_address,t.status,t.created_at,t.last_updated,t.memo,t.signatures,t.messages,t.hash,t.err_msg,t.fee, m.threshold,
json_agg(jsonb_build_object('pubkey', p.pubkey, 'address', p.address, 'multisig_address',p.multisig_address)) AS pubkeys FROM transactions t JOIN multisig_accounts m ON t.multisig_address = m.address JOIN pubkeys p ON t.multisig_address = p.multisig_address WHERE t.multisig_address=$1 and t.status <> 'PENDING' GROUP BY t.id, t.multisig_address, m.threshold, t.messages LIMIT $2 OFFSET $3`,
multisigAddress, limit, (page-1)*limit)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SQL query in GetAllMultisigTxns should include pagination parameters (LIMIT and OFFSET) to handle large datasets efficiently and avoid potential performance issues.

Comment on lines +173 to +176
multisigRows, err := h.DB.Query(`SELECT p.multisig_address
FROM pubkeys p
JOIN multisig_accounts m ON p.multisig_address = m.address
WHERE p.address = $1`, address)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SQL query in GetAllMultisigTxns should be based on the multisig address, not the pubkey's address. Ensure that the correct address is used in the WHERE clause to retrieve the relevant multisig transactions.

aleem1314 added a commit that referenced this pull request Jan 4, 2024
* Resolute next js (#805)

* Delete all files

* Add nextJS template

* remove readme from frontend

* yarn

* changed the names

* added voteforproposal popup

* Integrate connect wallet popup

* ui: Adjust backgorund color and image

* added the groups 2nd page

* feegrant page - 1

* feegrant page - 2

* Resolve conflicts

* Add tables in feegrant

* added the group 2nd page components

* Add tabs group in groups page

* feat: integrated multiple wallets

* chore: fixed sidebar

* review changes

* review changes home page

* refactor: change css class names

* refactor: change css class names

* wip

* wip: refactor

* refactor: connect wallet nuances

* added wallet key change event listeners

* Add redux store

* feat: wallet redux state

* fix: redux state when reloaded

* chore: reload UX

* chore: update github action

---------

Co-authored-by: pavania1 <adinapavani@gmail.com>
Co-authored-by: saiteja <tejargukt123@gmail.com>
Co-authored-by: Teja2045 <106052623+Teja2045@users.noreply.github.com>
Co-authored-by: aleem1314 <aleem@vitwit.com>

* created  AllMultisigAccount page and Multisig tabs

* feat: integrated cosmosJS and bank slice

* Revert "feat: integrated cosmosJS and bank slice"

This reverts commit 6770216.

* Revert "Revert "feat: integrated cosmosJS and bank slice""

This reverts commit 00ec1bc.

* chore: deleted node modules

* chore: install dependencies

* chore

* fix: fix build issue with window object (#841)

* chore: fixings bug

* chore: review changes

* chore

* chore: removed js files and unused files

* chore: made review changes

* fix: add eslint (#849)

* fix: add eslint

* add yarn lock file

* change node version frontend workflow

* change next js version 14.0.1

* remove lint to yarn build

* chore

* chore: bank state

* fix

* chore

* fix: fix eslint issues (#851)

* fix: fix eslint issues

* eslint change

* chore: lint changes

* review changes

* review changes

* chore: bank state types

* chore: fixing some types

* refactor: refactored the cosmjs files

* refactor: review changes

* chore

* chore

* review changes

* chore

* Update frontend.yml (#854)

* chored: removed passage code

* chore

* build: implemented redux state for staking (#865)

* build: implemented redux state for staking

* chore: added declarations *.d.ts files

* chore: fixed a lint issue

* chore: fixed build errors

* ui: Add sidebar (#870)

* Added SideNav bar

* Add sidebar

---------

Co-authored-by: pavania1 <adinapavani@gmail.com>

* feat: integration of starting overview page (#869)

* feat: integration of starting overview page

* refactor: review changes

* chore

* refactor: implemented custom hooks for clean code

* chore

* feat: Add common slice and common service (#877)

* feat: Add common slice and common service

* chore

* Add types file

* chore

* Review changes

* chore

* ui: change backgroud colors and sidebar (#881)

* chore(deps): bump @types/react from 18.2.22 to 18.2.37 in /frontend (#862)

Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.2.22 to 18.2.37.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump @types/react-dom from 18.2.7 to 18.2.15 in /frontend (#863)

Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 18.2.7 to 18.2.15.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom)

---
updated-dependencies:
- dependency-name: "@types/react-dom"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: implemented Overview UI (#882)

* feat: integration of starting overview page

* refactor: review changes

* chore

* refactor: implemented custom hooks for clean code

* chore

* feat: implemented governance UI

* feat: implemented UI

* feat: implemented UI

* feat: implented overview UI

* chore

* chore

* chore: review changes

* chore: review changes

* feat: Add getUnbondingDelegations reducer (#887)

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix: fixed transaction signing error (#890)

fix: fixed transaction error

* feat: implemented chain specific overview (#888)

* feat: integration of starting overview page

* refactor: review changes

* chore

* refactor: implemented custom hooks for clean code

* chore

* feat: implemented governance UI

* feat: implemented UI

* feat: implemented UI

* feat: implented overview UI

* chore

* chore

* chore: review changes

* chore: review changes

* feat: implemented chain specific overview

* chore

* chore: review changes

* chore

* chore: review changes

* chore: review changes

* feat: Add distribution slice (#891)

* feat: Add distribution slice

* review changes

* feat: implemented auth slice (#892)

* feat: integration of starting overview page

* refactor: review changes

* chore

* refactor: implemented custom hooks for clean code

* chore

* feat: implemented governance UI

* feat: implemented UI

* feat: implemented UI

* feat: implented overview UI

* chore

* chore

* chore: review changes

* chore: review changes

* feat: implemented chain specific overview

* chore

* chore: review changes

* feat: implemented auth slice

* chore: fixed lint errors

* feat(gov): Implement gov slice (#895)

* wip(gov): gov slice

* wip(gov): refactor

* chore(gov)

* gov: Add getDepositProps reducer

* wip(gov)

* wip(gov): add get proposal

* (gov): add constants

* feat(gov): Add txDeposit and txVote

* chore(gov): review changes

* refactor(gov): review changes

* feat: Implement select network and add network (#899)

* wip: Add select network dialog

* chore

* wip

* wip: select network

* wip: Add new network

* wip(add network)

* chore(add network): change network config schema

* Add rounting

* chore(select network)

* chore(select-network)

* chore(select-network): review changes

* review changes

* feat: implement transaction history (#893)

* feat: implented transaction history logic

* chore

* chore: clean code

* Implented recent transactions

* chore: clean code

* chore: small fix

* feat: implented actions

* chore

* fix: lint errors

* chore: tx loading

* chore

* refactor: review changes

* chore: small UI changes

* chore: close ads

* chore

* fix: add memo in Transaction type (#904)

fix: tx fix

* chore(deps): bump typescript from 5.2.2 to 5.3.2 in /frontend (#884)

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.2.2 to 5.3.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.2.2...v5.3.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: Implement staking page (#901)

* Add staking overview ui

* wip: Staking ui

* chore

* Add unbonding ui

* Integrate delegations

* wip

* Add all validators dialog

* Integrate search option

* fix: fix lint issues

* chore

* fix

* wip

* wip

* Add unbonding delegations

* chore

* wip

* Add validators status

* wip

* Add validator logos

* fix: fix lint issues

* chore

* refactor

* chore

* chore

* staking: changes

* wip

* refactor(staking)

* feat(staking): Add staking actions (#906)

* feat(staking): Add delegate dialog

* chore(staking-actions)

* wip(staking): Add delegate action to staking cards

* chore(staking-actions): Customize mui text field

* wip(staking-actions-changes)

* wip(staking): Add undelegate action

* wip(staking-actions): Add redelegate

* wip(staking): Add claim, claim and stake

* wip(Staking-actions)

* refactor

* refactor(staking): Add interfaces for props

* refactor(staking)

* refactor(staking)

* wip(staking): add claim and stake

* refactor(staking)

* chore(staking-actions): review changes

* chore(staking-actions): review changes.

* chore(multisig page): review changes

* chore(staking-actions): Review changes-2

* chore(staking-page): review changes

* feat: add transaction success popup (#907)

* Added TransactionSuccess Popup

* Transaction Success Popup

* PR chnages

* ConnectWalletPopup

* removed the errors

* Update frontend/src/components/WalletPopup.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* chore: fix build (#919)

* feat: ui improvements and txPopup integration (#921)

* feat: ui improvements and txPop integration

* chore: txPop integration in distribution

* chore: fixed gov slice

* chore: review changes

* feat: transfers (#915)

* build: transfers layout and recent transactions

* feat: assets integration in transfers page

* chore: txStatus type fix

* refactor: transfer support for all networks

* feat: added send page form

* feat: send transaction action

* chore: lint fix

* refactor: review changes

* chore: add loading

* chore: fixed loading for assets

* chore: ui change

* chore: overflow scroll

* refactor: review changes

* chore: fixed css syntax error

* chore: review changes

* chore: key change for assets list

* chore: review changes

* chore: css fix

* refactor: refactor select assets ui

* chore: yarn lock

* chore: review changes

* feat: add API for recent multisig txns (#922)

* add delete multisig account api

* add account of all multisig account txns

* remove multisig account

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* feat: implement multi-transfer (#926)

* build: transfers layout and recent transactions

* feat: assets integration in transfers page

* chore: txStatus type fix

* refactor: transfer support for all networks

* feat: added send page form

* feat: send transaction action

* chore: lint fix

* refactor: review changes

* chore: add loading

* chore: fixed loading for assets

* chore: ui change

* chore: overflow scroll

* refactor: review changes

* chore: fixed css syntax error

* chore: review changes

* chore: key change for assets list

* chore: review changes

* chore: css fix

* refactor: refactor select assets ui

* feat: implemented Multi-send

* chore: cursor Poiner for deleting message

* fix: delete message fix

* chore: review changes

* refactor: review changes

* chore: review changes

* feat: responsive padding and history transactions

* feat(multisig): Implement multisig slice (#912)

* wip(multisig-slice)

* wip(multisig-slice)

* feat(multisig): Add multisig slice

* chore(multisig-slice): resolve lint issues

* chore(multisig-slice)

* refactor(multisig slice)

* chore

* chore(multisig-slice): review changes

* chore(multisig-slice): review changes

* chore(multisig-slice): Review changes

* chore(multisig-slice): review changes

* feat: add governance page (#872)

* Added SideNav bar

* Ui for the Governance main page

* Made chnages required in the PR

* removed main from the css file

* added history-icon

* Add changes required for the PR

* All the ui screens for governance

* Added chnages in DepositPopup

* chore

* Review changes

* Chnaged Radio button component name

* Review chnages

* Review changes

* Review changes

* chnages in RightOverview

* Added json files requested in the PR

* changes in page.tsx

* some ui changes

* chnages

* add integration for list of proposals

* fix(gov): fix custom hooks issue

* fix eslint issues

* fix single proposal overview

* debug: vote txn error

* Made UI changes

* Added proposalId selected and chnages in govSlice

* fix: build issues

* Update frontend/src/app/(routes)/governance/ProposalOverviewVote.tsx

not it's not the correct way.
the quorum value is accessing form the proposalOverviewData file

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* review changes

* review changes

* review chnages

* eslint-disable for _ChainName

* Added ReactMarkdown package

* review chnages

* fix:eslint error

* fix: all the changes

* chore(gov): gov page changes (#931)

* chore(gov): fixes

* wip(gov): fixes

* chore(gov): gov fixes

* chore(gov): remove lint issues

* chore(gov): gov improvements

* feat(gov): Add proposal projection

* chore(gov): ui changes

---------

Co-authored-by: Hemanth Sai <ghshemanth@gmail.com>
Co-authored-by: charymalloju <chary@vitwit.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* refactor: overview page review changes (#935)

* refactor: overview ui review changes

* chore: remove hover state for transfers card

* chore: no assets style change

* chore: font change

* refactored: refactored assets information implementation

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* chore(staking): Staking UI iterations (#939)

* wip(staking-ui): Staking ui changes

* chore(staking): staking ui changes

* chore

* chore(staking): review change

* Fix: Changes in UI (#940)

* Fix: Changes in UI

* Fix: UI for Rightoverview

* fix: ProposalOverviewvote

* chore: fix tailwindcss warnings (#952)

* refactor: transfers UI changes (#951)

* refactor: overview ui review changes

* chore: remove hover state for transfers card

* chore: no assets style change

* chore: font change

* refactored: refactored assets information implementation

* refactor: transfers UI refactor

* chore: review changes

* chore: layout change

* chore: top nav padding

* refactor: layout changes and hide pagination

* chore: pagination change

* chore: lint fix

* chore: remove transaction icon and add extra column for asset value in Assets table (#953)

* chore: review changes

* chore: remove commented lines

* add delete multisig account api (#920)

* add delete multisig account api

* validatoe multisig account exists

* fix error format messages

* add db txn to delete account

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix:networks popup ui changes  (#954)

* fix:Chnages inAddNetworkPopup

* fix: Change the background of select network

* fix:decrease opacity of horizontal line

* changed the all-networks-icon

* fix: fix the characters of a network

* fix: changed the TopNav in select network

* chnaged the dropdown

* Update frontend/src/components/SelectNetwork.tsx

* Update frontend/src/components/SelectNetwork.tsx

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix(ui): sidebar review changes (#955)

* fix: changes in SideNavbar

* chnages in sideNavbar

* fix: added tooltip to topnavbar

* feat(multisig): Implement multisig page (#910)

* wip(multisig): Add layout

* wip(multisig-slice)

* wip(multisig-slice)

* feat(multisig): Add multisig slice

* chore(multisig-slice): resolve lint issues

* chore(multisig-slice)

* refactor(multisig slice)

* chore

* chore(multisig-slice): review changes

* chore(multisig-slice): review changes

* chore(multisig-slice): Review changes

* chore(multisig-slice): review changes

* ui: Multisigcard component (#911)

* wip(multisig-ui)

* wip(multisig): Add multisig info page

* wip(multisig): Create new multisig

* wip(multisig)

* wip(multisig)

* feat(multisig): List txns

* feat: Add create multisig account

* wip(multisig): Create txn

* wip(multisig): Add send txn form

* wip(multisig): Add delegate txn

* wip(multisig): Add signTx and broadCastTx

* wip(multisg)

* wip(multisig): refactor

* wip(multisig): refactor code

* wip

* chore

* refactor(multisig): review changes (#956)

* wip(multisig): review changes

* wip(multisig): review changes-2

* wip(multisig): review changes-3

* wip(multisig): review changes-4

* chore(multisig): review changes

* chore(multisig): review changes

* chore(multisig): review changes

* chore(multisig): review changes

---------

Co-authored-by: pavania1 <117721819+pavania1@users.noreply.github.com>

* fix: all networks logo size (#957)

* fix: all networks logo size

* fix:all network-logo-size

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix: fix add network config format (#965)

fix: fix network config format

* feat(ui): Add custom alert bar (#964)

* feat(ui): Add custom alert bar

* chore: review changes

* chore: review changes

* addded new drop-down icon (#961)

* fix: Changes implemented in transaction popup (#958)

* Displaying the quorum reached and required (#959)

* Displaying the quorum reached and required

* fix: validation errors and ui chnages

* review changes

* added scrollbar

* eslint error resolved

* eslint errors resolved

* chore(gov): proposalInfo ui fix

* fix: internalscroll

* removed unnecessary text

* review chnages

* review changes

* radded Tooltip to quorumrequired

* added quorumrequired

---------

Co-authored-by: hemanthghs <ghshemanth@gmail.com>

* staking(ui): fix staking page ui issues (#967)

* wip: staking ui issues

* wip: staking ui issues

* wip(staking-ui-issues)

* wip(staking-ui-issues)

* chore(ui): Add no data found ui

* wip: staking-ui-issues

* feat: implemented ibc transfers (#969)

* feat: implemented ibc transfers

* chore: build fix and review changes

* chore: review change

* chore: deleted unused file

* fix: ibc denom not found bug

* fix: ui issues (#978)

* fix: fix Nan years time bug

* fix: fix claim action loading bug

* fix: temporary fix for transaction failed case

* chore: Fix the quorum required (#977)

* add undelegate and redelegate txns in multisig (#968)

* add undelegate and redelegate txns in multisig

* add list account of all multisig txns

* add delete operation for multisig

* fix all multisig account txns

* chore: update get all multisig txns (#970)

* chore(multisig): fix multisig all txns issue (#971)

* chore: resolve lint issues

* fix: fix all multisigs txn issues

* chore: fix lint issues

* chore(multisig): ui fixes

* chore

* chore: review changes

* feat: Add file upload txn (#979)

* chore: resolve lint issues

* fix: fix all multisigs txn issues

* chore: fix lint issues

* chore(multisig): ui fixes

* chore

* chore: review changes

* wip

* feat(multisig): add file upload txn

* chore: add resetError

* chore: fix

* chore: review changes

---------

Co-authored-by: Hemanth Sai <ghshemanth@gmail.com>

* chore: ui improvements (#980)

* chore: remove alerts and improve amount validations

* chore: multiple keplr requests issue

* chore: removed msgs after submission

* chore: clear messages after multi-transfer submission

* chore: messages clear change

* chore: persist messages when tx failed in multi transfer

* fix: fix multisig issues (#987)

* fix: fix multisig issues

* chore: review changes

* chore: changes networks list

* Update server.go (#988)

* fix(server): fix backend issue (#992)

fix(backend): fix backend issues

* staking(ui): fix staking ui issues (#1000)

* refactor(ui): staking ui changes

* refactor(ui): staking ui issues

* refactor(ui): staking ui changes

* refactor: ui changes (#999)

* refactor: ui changes

* chore: icons padding

* chore: adjusted button width

* feat: implement landing page (#937)

* Landingpage

* Landingpage

* removing the white spaces at the bottom

* changed button

* implement Landingpage

* fix: review changes

* review changes

* add bgcolor for the selected network

* added hover and pointer to walletbuttons

* added background animation

* added background animation

* chore: fix ui issues

* fix: eslint errors

* resolved eslint issues

* fix:eslint errors

* chore: review changes

* chnages in connectwallet

* fix: padding issues

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* chore: overview page ui changes (#1003)

* refactor: overview changes

* refactor: copy to clipboard component

* chore: review changes

* refactor: refactored transfers page (#1009)

refactor: refactored transfers ui

Co-authored-by: chary <57086313+charymalloju@users.noreply.github.com>

* chore(deps): add sharp package for image optimization (#1007)

chore(deps): add sharp package

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix: proposal details and date format(ui) (#1005)

* fix: proposal details and date format

* chore: added tooltips to the proposal details

* fix: review changes

---------

Co-authored-by: chary <57086313+charymalloju@users.noreply.github.com>

* feat: Implement cancel unbonding delegations (#960)

* wip(cancel-unbonding)

* fix: fix amino converter

* chore

* chore

* chore(ui): fix common ui issues (#1008)

* chore(ui): common ui changes

* chore: review changes

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* Chore: Ui issues related to Deposit (#1010)

* Chore: Ui issues related to Deposit

* chore: added deposit details in the deposit overview

* fix: ui changes in deposit

* chore: resolved eslint issues

* feat: transfers and overview illustrations (#1013)

* feat: add illustrations

* chore: fix image shape

* chore(transfers): input field focus and add download icon (#1011)

* chore: text fields focus and download-icon

* chore: padding alignment of memo field

* chore: added illsutration to governance (Proposals not found) (#1012)

* chore: added illsutration

* chore: removed absolute positioning

* Update frontend/src/utils/messages.json

---------

Co-authored-by: saiteja <tejargukt123@gmail.com>
Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* feat: add ibc transfer note (#1015)

* chore: text fields focus and download-icon

* chore: padding alignment of memo field

* feat: added ibc badge

* fix: fixed page shifting

* chore: review change

* multisig(ui): fix multisig ui issues (#1006)

* wip(multisig): multisig ui changes

* chore(multisig): multisig ui changes

* chore(multisig): multisig ui issues

* chore(multisig(: Add illustration for no txns

* chore(multisig): Add illustration for no txns

* chore

* chore: review change

* chore

* chore(ui): add illustrations for empty screens

* chore(ui): multisigui changes

* chore

* refactor: discussed changes (#1016)

* chore: text fields focus and download-icon

* chore: padding alignment of memo field

* feat: added ibc badge

* fix: fixed page shifting

* chore: review change

* refactor: review changes

* chore: illustration positioning

* chore

* chore: recent transactions margin

* fix: fixed addresses issue for multi hop ibc transfers

* disabled draggability

* lint fix

* chore: landing page fix

* chore: fixed padding in transfers page

* common(ui): common ui changes (#1018)

* chore: common ui changes

* chore

* chore

* chore

* chore: add favicon

* feat: loading page (#1019)

* feat: Add txn receipt (#1021)

* wip: txn receipt

* chore

* wip

* chore: add txn messages

* chore: fix lint issues

* chore

* chore

* chore

* chore(ui): Txn receipt ui changes (#1025)

* chore: changes bgcolor

* chore: ui changes

* staking(ui): staking page ui changes (#1017)

* chore(staking): change staking action buttons

* chore(staking): staking ui changes

* chore(staking): ui changes

* chore

* chore

* chore: staking ui changes

* chore

* chore

* chore

* chore

* chore

* fix: loading issue (#1022)

* fix: loading issue

* fix: server side local storage bug

* chore: some nextJS weird errors, fixed the loading issue in another way

* feat: added loader animation

* refactor: assets card ui change

* chore: add ibc tag

* chore: Governance ui changes (#997)

* chore: Change the close-icon

* chanages is characterlimit, viewfullproposal and fonts

* UI changes related to the Total votes

* Review changes

* fix: review changes

* fix: eslint errors

* fix: quorum line and highlighted proposalid

* chore: review changes

* chore: fix lint issues

* chore: gov ui changes

* chore: changed divider-line

* chore: added justify-between in rightoverview

* chore: decrease the proposal-id font size

* chore: changes in votePopup

* chore: spacing in TopNav

* chore: changed the illustration

* chore: change TopNav

* chore: remove spacing in topnav

* chore: review changes

* chore: review changes

* resolved eslint errors

* fix:  jsondata field

* adjust the position of raw_data option

* ui review chnages

* chore: change the font

* chore: change the font sizes

---------

Co-authored-by: saiteja <tejargukt123@gmail.com>
Co-authored-by: Hemanth Sai <ghshemanth@gmail.com>

* chore: popup colors (#1028)

* chore: Ui changes in landingpage (#1030)

* chore: Ui changes in governance (#1029)

chore: Ui chnages in governance

* chore: common ui changes (#1031)

* chore: common ui changes

* chore: add telegram url

* fix: common ui errors (#1032)

chore: fix-common-ui-bugs

* gov(fix): fix gov proposal markdown (#1033)

* Fix: error snackbar (#1034)

* chore: fix-common-ui-bugs

* chore: fixed set error

* chore: remove snackbar

* gov(func): add loading state to vote and deposit popups (#1037)

* gov(fix): fix page break (#1040)

gov: fix page break

* chore: disable draggable to the images (#1041)

* chore: disable draggable to the images

* message

* Chary/auth middleware (#1023)

* fix merge conflicts

* add authentication layer

* fix bot errors

* remove available bal

* fixed format

* multisig: multisig iterations changes (#1042)

* chore: multisig iteration changes

* chore: multisig ui changes

* chore: add loader to verify button

* chore

* chore

* chore: add loading states

* Pavania1/landing responsive (#1045)

fix: responsive for landingpage

* chore: added isFeeEnough hook to assist transactions (#1044)

chore: allow transactions only when there is enough fee

* gov(ui): add loader  (#1046)

* gov(ui): add loader

* chore

* feat: state mutation after successful transactions (#1047)

* chore: allow transactions only when there is enough fee

* chore: state mutation after transactions

* Changes in governance ui (#1048)

* gov(ui): add loader

* chore

* fix(ui) : resolved ui changes in governance

---------

Co-authored-by: hemanthghs <ghshemanth@gmail.com>

* chore: change networks list (#1043)

* chore(multisig): multisig issues (#1050)

* chore: multisig issues

* chore: add loader to txns list

* chore: change salt value to random number

* fix: fix ui and functionality bugs (#1051)

refactor: fixed some ui and functionality bugs

* multisig(fix): remove authtokens (#1052)

multisig(fix): remove authtoken

* feat: added responsiveness to assets (#1053)

* refactor: fixed some ui and functionality bugs

* feat: made assets cards responsive

* chore: lint fix

---------

Co-authored-by: chary <57086313+charymalloju@users.noreply.github.com>

* Chary/readme (#1055)

* fix merge conflicts

* add read me file

* fixed grammatical mistakes

* delete frontend folder

* fix: fixed some issues and updates (#1054)

* refactor: fixed some ui and functionality bugs

* feat: made assets cards responsive

* chore: lint fix

* chore: fix bugs and ui issues

* chore: separate claim All and claim

* chore: console response

* remove some console statements

* chore: removed unnecessary empty callbacl

* resolve conflicts

* chore: staking issues (#1056)

* chore: staking changes

* chore: disalbe image dragging

* Update readme

* Update readme

* update readme

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: pavania1 <adinapavani@gmail.com>
Co-authored-by: saiteja <tejargukt123@gmail.com>
Co-authored-by: Teja2045 <106052623+Teja2045@users.noreply.github.com>
Co-authored-by: aleem1314 <aleem@vitwit.com>
Co-authored-by: chary <57086313+charymalloju@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Co-authored-by: pavania1 <117721819+pavania1@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: charymalloju <chary@vitwit.com>
aleem1314 added a commit that referenced this pull request Jan 4, 2024
* Resolute next js (#805)

* Delete all files

* Add nextJS template

* remove readme from frontend

* yarn

* changed the names

* added voteforproposal popup

* Integrate connect wallet popup

* ui: Adjust backgorund color and image

* added the groups 2nd page

* feegrant page - 1

* feegrant page - 2

* Resolve conflicts

* Add tables in feegrant

* added the group 2nd page components

* Add tabs group in groups page

* feat: integrated multiple wallets

* chore: fixed sidebar

* review changes

* review changes home page

* refactor: change css class names

* refactor: change css class names

* wip

* wip: refactor

* refactor: connect wallet nuances

* added wallet key change event listeners

* Add redux store

* feat: wallet redux state

* fix: redux state when reloaded

* chore: reload UX

* chore: update github action

---------

Co-authored-by: pavania1 <adinapavani@gmail.com>
Co-authored-by: saiteja <tejargukt123@gmail.com>
Co-authored-by: Teja2045 <106052623+Teja2045@users.noreply.github.com>
Co-authored-by: aleem1314 <aleem@vitwit.com>

* created  AllMultisigAccount page and Multisig tabs

* feat: integrated cosmosJS and bank slice

* Revert "feat: integrated cosmosJS and bank slice"

This reverts commit 6770216.

* Revert "Revert "feat: integrated cosmosJS and bank slice""

This reverts commit 00ec1bc.

* chore: deleted node modules

* chore: install dependencies

* chore

* fix: fix build issue with window object (#841)

* chore: fixings bug

* chore: review changes

* chore

* chore: removed js files and unused files

* chore: made review changes

* fix: add eslint (#849)

* fix: add eslint

* add yarn lock file

* change node version frontend workflow

* change next js version 14.0.1

* remove lint to yarn build

* chore

* chore: bank state

* fix

* chore

* fix: fix eslint issues (#851)

* fix: fix eslint issues

* eslint change

* chore: lint changes

* review changes

* review changes

* chore: bank state types

* chore: fixing some types

* refactor: refactored the cosmjs files

* refactor: review changes

* chore

* chore

* review changes

* chore

* Update frontend.yml (#854)

* chored: removed passage code

* chore

* build: implemented redux state for staking (#865)

* build: implemented redux state for staking

* chore: added declarations *.d.ts files

* chore: fixed a lint issue

* chore: fixed build errors

* ui: Add sidebar (#870)

* Added SideNav bar

* Add sidebar

---------

Co-authored-by: pavania1 <adinapavani@gmail.com>

* feat: integration of starting overview page (#869)

* feat: integration of starting overview page

* refactor: review changes

* chore

* refactor: implemented custom hooks for clean code

* chore

* feat: Add common slice and common service (#877)

* feat: Add common slice and common service

* chore

* Add types file

* chore

* Review changes

* chore

* ui: change backgroud colors and sidebar (#881)

* chore(deps): bump @types/react from 18.2.22 to 18.2.37 in /frontend (#862)

Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.2.22 to 18.2.37.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump @types/react-dom from 18.2.7 to 18.2.15 in /frontend (#863)

Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 18.2.7 to 18.2.15.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom)

---
updated-dependencies:
- dependency-name: "@types/react-dom"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: implemented Overview UI (#882)

* feat: integration of starting overview page

* refactor: review changes

* chore

* refactor: implemented custom hooks for clean code

* chore

* feat: implemented governance UI

* feat: implemented UI

* feat: implemented UI

* feat: implented overview UI

* chore

* chore

* chore: review changes

* chore: review changes

* feat: Add getUnbondingDelegations reducer (#887)

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix: fixed transaction signing error (#890)

fix: fixed transaction error

* feat: implemented chain specific overview (#888)

* feat: integration of starting overview page

* refactor: review changes

* chore

* refactor: implemented custom hooks for clean code

* chore

* feat: implemented governance UI

* feat: implemented UI

* feat: implemented UI

* feat: implented overview UI

* chore

* chore

* chore: review changes

* chore: review changes

* feat: implemented chain specific overview

* chore

* chore: review changes

* chore

* chore: review changes

* chore: review changes

* feat: Add distribution slice (#891)

* feat: Add distribution slice

* review changes

* feat: implemented auth slice (#892)

* feat: integration of starting overview page

* refactor: review changes

* chore

* refactor: implemented custom hooks for clean code

* chore

* feat: implemented governance UI

* feat: implemented UI

* feat: implemented UI

* feat: implented overview UI

* chore

* chore

* chore: review changes

* chore: review changes

* feat: implemented chain specific overview

* chore

* chore: review changes

* feat: implemented auth slice

* chore: fixed lint errors

* feat(gov): Implement gov slice (#895)

* wip(gov): gov slice

* wip(gov): refactor

* chore(gov)

* gov: Add getDepositProps reducer

* wip(gov)

* wip(gov): add get proposal

* (gov): add constants

* feat(gov): Add txDeposit and txVote

* chore(gov): review changes

* refactor(gov): review changes

* feat: Implement select network and add network (#899)

* wip: Add select network dialog

* chore

* wip

* wip: select network

* wip: Add new network

* wip(add network)

* chore(add network): change network config schema

* Add rounting

* chore(select network)

* chore(select-network)

* chore(select-network): review changes

* review changes

* feat: implement transaction history (#893)

* feat: implented transaction history logic

* chore

* chore: clean code

* Implented recent transactions

* chore: clean code

* chore: small fix

* feat: implented actions

* chore

* fix: lint errors

* chore: tx loading

* chore

* refactor: review changes

* chore: small UI changes

* chore: close ads

* chore

* fix: add memo in Transaction type (#904)

fix: tx fix

* chore(deps): bump typescript from 5.2.2 to 5.3.2 in /frontend (#884)

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.2.2 to 5.3.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.2.2...v5.3.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: Implement staking page (#901)

* Add staking overview ui

* wip: Staking ui

* chore

* Add unbonding ui

* Integrate delegations

* wip

* Add all validators dialog

* Integrate search option

* fix: fix lint issues

* chore

* fix

* wip

* wip

* Add unbonding delegations

* chore

* wip

* Add validators status

* wip

* Add validator logos

* fix: fix lint issues

* chore

* refactor

* chore

* chore

* staking: changes

* wip

* refactor(staking)

* feat(staking): Add staking actions (#906)

* feat(staking): Add delegate dialog

* chore(staking-actions)

* wip(staking): Add delegate action to staking cards

* chore(staking-actions): Customize mui text field

* wip(staking-actions-changes)

* wip(staking): Add undelegate action

* wip(staking-actions): Add redelegate

* wip(staking): Add claim, claim and stake

* wip(Staking-actions)

* refactor

* refactor(staking): Add interfaces for props

* refactor(staking)

* refactor(staking)

* wip(staking): add claim and stake

* refactor(staking)

* chore(staking-actions): review changes

* chore(staking-actions): review changes.

* chore(multisig page): review changes

* chore(staking-actions): Review changes-2

* chore(staking-page): review changes

* feat: add transaction success popup (#907)

* Added TransactionSuccess Popup

* Transaction Success Popup

* PR chnages

* ConnectWalletPopup

* removed the errors

* Update frontend/src/components/WalletPopup.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* chore: fix build (#919)

* feat: ui improvements and txPopup integration (#921)

* feat: ui improvements and txPop integration

* chore: txPop integration in distribution

* chore: fixed gov slice

* chore: review changes

* feat: transfers (#915)

* build: transfers layout and recent transactions

* feat: assets integration in transfers page

* chore: txStatus type fix

* refactor: transfer support for all networks

* feat: added send page form

* feat: send transaction action

* chore: lint fix

* refactor: review changes

* chore: add loading

* chore: fixed loading for assets

* chore: ui change

* chore: overflow scroll

* refactor: review changes

* chore: fixed css syntax error

* chore: review changes

* chore: key change for assets list

* chore: review changes

* chore: css fix

* refactor: refactor select assets ui

* chore: yarn lock

* chore: review changes

* feat: add API for recent multisig txns (#922)

* add delete multisig account api

* add account of all multisig account txns

* remove multisig account

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* feat: implement multi-transfer (#926)

* build: transfers layout and recent transactions

* feat: assets integration in transfers page

* chore: txStatus type fix

* refactor: transfer support for all networks

* feat: added send page form

* feat: send transaction action

* chore: lint fix

* refactor: review changes

* chore: add loading

* chore: fixed loading for assets

* chore: ui change

* chore: overflow scroll

* refactor: review changes

* chore: fixed css syntax error

* chore: review changes

* chore: key change for assets list

* chore: review changes

* chore: css fix

* refactor: refactor select assets ui

* feat: implemented Multi-send

* chore: cursor Poiner for deleting message

* fix: delete message fix

* chore: review changes

* refactor: review changes

* chore: review changes

* feat: responsive padding and history transactions

* feat(multisig): Implement multisig slice (#912)

* wip(multisig-slice)

* wip(multisig-slice)

* feat(multisig): Add multisig slice

* chore(multisig-slice): resolve lint issues

* chore(multisig-slice)

* refactor(multisig slice)

* chore

* chore(multisig-slice): review changes

* chore(multisig-slice): review changes

* chore(multisig-slice): Review changes

* chore(multisig-slice): review changes

* feat: add governance page (#872)

* Added SideNav bar

* Ui for the Governance main page

* Made chnages required in the PR

* removed main from the css file

* added history-icon

* Add changes required for the PR

* All the ui screens for governance

* Added chnages in DepositPopup

* chore

* Review changes

* Chnaged Radio button component name

* Review chnages

* Review changes

* Review changes

* chnages in RightOverview

* Added json files requested in the PR

* changes in page.tsx

* some ui changes

* chnages

* add integration for list of proposals

* fix(gov): fix custom hooks issue

* fix eslint issues

* fix single proposal overview

* debug: vote txn error

* Made UI changes

* Added proposalId selected and chnages in govSlice

* fix: build issues

* Update frontend/src/app/(routes)/governance/ProposalOverviewVote.tsx

not it's not the correct way.
the quorum value is accessing form the proposalOverviewData file

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* review changes

* review changes

* review chnages

* eslint-disable for _ChainName

* Added ReactMarkdown package

* review chnages

* fix:eslint error

* fix: all the changes

* chore(gov): gov page changes (#931)

* chore(gov): fixes

* wip(gov): fixes

* chore(gov): gov fixes

* chore(gov): remove lint issues

* chore(gov): gov improvements

* feat(gov): Add proposal projection

* chore(gov): ui changes

---------

Co-authored-by: Hemanth Sai <ghshemanth@gmail.com>
Co-authored-by: charymalloju <chary@vitwit.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* refactor: overview page review changes (#935)

* refactor: overview ui review changes

* chore: remove hover state for transfers card

* chore: no assets style change

* chore: font change

* refactored: refactored assets information implementation

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* chore(staking): Staking UI iterations (#939)

* wip(staking-ui): Staking ui changes

* chore(staking): staking ui changes

* chore

* chore(staking): review change

* Fix: Changes in UI (#940)

* Fix: Changes in UI

* Fix: UI for Rightoverview

* fix: ProposalOverviewvote

* chore: fix tailwindcss warnings (#952)

* refactor: transfers UI changes (#951)

* refactor: overview ui review changes

* chore: remove hover state for transfers card

* chore: no assets style change

* chore: font change

* refactored: refactored assets information implementation

* refactor: transfers UI refactor

* chore: review changes

* chore: layout change

* chore: top nav padding

* refactor: layout changes and hide pagination

* chore: pagination change

* chore: lint fix

* chore: remove transaction icon and add extra column for asset value in Assets table (#953)

* chore: review changes

* chore: remove commented lines

* add delete multisig account api (#920)

* add delete multisig account api

* validatoe multisig account exists

* fix error format messages

* add db txn to delete account

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix:networks popup ui changes  (#954)

* fix:Chnages inAddNetworkPopup

* fix: Change the background of select network

* fix:decrease opacity of horizontal line

* changed the all-networks-icon

* fix: fix the characters of a network

* fix: changed the TopNav in select network

* chnaged the dropdown

* Update frontend/src/components/SelectNetwork.tsx

* Update frontend/src/components/SelectNetwork.tsx

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix(ui): sidebar review changes (#955)

* fix: changes in SideNavbar

* chnages in sideNavbar

* fix: added tooltip to topnavbar

* feat(multisig): Implement multisig page (#910)

* wip(multisig): Add layout

* wip(multisig-slice)

* wip(multisig-slice)

* feat(multisig): Add multisig slice

* chore(multisig-slice): resolve lint issues

* chore(multisig-slice)

* refactor(multisig slice)

* chore

* chore(multisig-slice): review changes

* chore(multisig-slice): review changes

* chore(multisig-slice): Review changes

* chore(multisig-slice): review changes

* ui: Multisigcard component (#911)

* wip(multisig-ui)

* wip(multisig): Add multisig info page

* wip(multisig): Create new multisig

* wip(multisig)

* wip(multisig)

* feat(multisig): List txns

* feat: Add create multisig account

* wip(multisig): Create txn

* wip(multisig): Add send txn form

* wip(multisig): Add delegate txn

* wip(multisig): Add signTx and broadCastTx

* wip(multisg)

* wip(multisig): refactor

* wip(multisig): refactor code

* wip

* chore

* refactor(multisig): review changes (#956)

* wip(multisig): review changes

* wip(multisig): review changes-2

* wip(multisig): review changes-3

* wip(multisig): review changes-4

* chore(multisig): review changes

* chore(multisig): review changes

* chore(multisig): review changes

* chore(multisig): review changes

---------

Co-authored-by: pavania1 <117721819+pavania1@users.noreply.github.com>

* fix: all networks logo size (#957)

* fix: all networks logo size

* fix:all network-logo-size

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix: fix add network config format (#965)

fix: fix network config format

* feat(ui): Add custom alert bar (#964)

* feat(ui): Add custom alert bar

* chore: review changes

* chore: review changes

* addded new drop-down icon (#961)

* fix: Changes implemented in transaction popup (#958)

* Displaying the quorum reached and required (#959)

* Displaying the quorum reached and required

* fix: validation errors and ui chnages

* review changes

* added scrollbar

* eslint error resolved

* eslint errors resolved

* chore(gov): proposalInfo ui fix

* fix: internalscroll

* removed unnecessary text

* review chnages

* review changes

* radded Tooltip to quorumrequired

* added quorumrequired

---------

Co-authored-by: hemanthghs <ghshemanth@gmail.com>

* staking(ui): fix staking page ui issues (#967)

* wip: staking ui issues

* wip: staking ui issues

* wip(staking-ui-issues)

* wip(staking-ui-issues)

* chore(ui): Add no data found ui

* wip: staking-ui-issues

* feat: implemented ibc transfers (#969)

* feat: implemented ibc transfers

* chore: build fix and review changes

* chore: review change

* chore: deleted unused file

* fix: ibc denom not found bug

* fix: ui issues (#978)

* fix: fix Nan years time bug

* fix: fix claim action loading bug

* fix: temporary fix for transaction failed case

* chore: Fix the quorum required (#977)

* add undelegate and redelegate txns in multisig (#968)

* add undelegate and redelegate txns in multisig

* add list account of all multisig txns

* add delete operation for multisig

* fix all multisig account txns

* chore: update get all multisig txns (#970)

* chore(multisig): fix multisig all txns issue (#971)

* chore: resolve lint issues

* fix: fix all multisigs txn issues

* chore: fix lint issues

* chore(multisig): ui fixes

* chore

* chore: review changes

* feat: Add file upload txn (#979)

* chore: resolve lint issues

* fix: fix all multisigs txn issues

* chore: fix lint issues

* chore(multisig): ui fixes

* chore

* chore: review changes

* wip

* feat(multisig): add file upload txn

* chore: add resetError

* chore: fix

* chore: review changes

---------

Co-authored-by: Hemanth Sai <ghshemanth@gmail.com>

* chore: ui improvements (#980)

* chore: remove alerts and improve amount validations

* chore: multiple keplr requests issue

* chore: removed msgs after submission

* chore: clear messages after multi-transfer submission

* chore: messages clear change

* chore: persist messages when tx failed in multi transfer

* fix: fix multisig issues (#987)

* fix: fix multisig issues

* chore: review changes

* chore: changes networks list

* Update server.go (#988)

* fix(server): fix backend issue (#992)

fix(backend): fix backend issues

* staking(ui): fix staking ui issues (#1000)

* refactor(ui): staking ui changes

* refactor(ui): staking ui issues

* refactor(ui): staking ui changes

* refactor: ui changes (#999)

* refactor: ui changes

* chore: icons padding

* chore: adjusted button width

* feat: implement landing page (#937)

* Landingpage

* Landingpage

* removing the white spaces at the bottom

* changed button

* implement Landingpage

* fix: review changes

* review changes

* add bgcolor for the selected network

* added hover and pointer to walletbuttons

* added background animation

* added background animation

* chore: fix ui issues

* fix: eslint errors

* resolved eslint issues

* fix:eslint errors

* chore: review changes

* chnages in connectwallet

* fix: padding issues

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* chore: overview page ui changes (#1003)

* refactor: overview changes

* refactor: copy to clipboard component

* chore: review changes

* refactor: refactored transfers page (#1009)

refactor: refactored transfers ui

Co-authored-by: chary <57086313+charymalloju@users.noreply.github.com>

* chore(deps): add sharp package for image optimization (#1007)

chore(deps): add sharp package

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix: proposal details and date format(ui) (#1005)

* fix: proposal details and date format

* chore: added tooltips to the proposal details

* fix: review changes

---------

Co-authored-by: chary <57086313+charymalloju@users.noreply.github.com>

* feat: Implement cancel unbonding delegations (#960)

* wip(cancel-unbonding)

* fix: fix amino converter

* chore

* chore

* chore(ui): fix common ui issues (#1008)

* chore(ui): common ui changes

* chore: review changes

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* Chore: Ui issues related to Deposit (#1010)

* Chore: Ui issues related to Deposit

* chore: added deposit details in the deposit overview

* fix: ui changes in deposit

* chore: resolved eslint issues

* feat: transfers and overview illustrations (#1013)

* feat: add illustrations

* chore: fix image shape

* chore(transfers): input field focus and add download icon (#1011)

* chore: text fields focus and download-icon

* chore: padding alignment of memo field

* chore: added illsutration to governance (Proposals not found) (#1012)

* chore: added illsutration

* chore: removed absolute positioning

* Update frontend/src/utils/messages.json

---------

Co-authored-by: saiteja <tejargukt123@gmail.com>
Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* feat: add ibc transfer note (#1015)

* chore: text fields focus and download-icon

* chore: padding alignment of memo field

* feat: added ibc badge

* fix: fixed page shifting

* chore: review change

* multisig(ui): fix multisig ui issues (#1006)

* wip(multisig): multisig ui changes

* chore(multisig): multisig ui changes

* chore(multisig): multisig ui issues

* chore(multisig(: Add illustration for no txns

* chore(multisig): Add illustration for no txns

* chore

* chore: review change

* chore

* chore(ui): add illustrations for empty screens

* chore(ui): multisigui changes

* chore

* refactor: discussed changes (#1016)

* chore: text fields focus and download-icon

* chore: padding alignment of memo field

* feat: added ibc badge

* fix: fixed page shifting

* chore: review change

* refactor: review changes

* chore: illustration positioning

* chore

* chore: recent transactions margin

* fix: fixed addresses issue for multi hop ibc transfers

* disabled draggability

* lint fix

* chore: landing page fix

* chore: fixed padding in transfers page

* common(ui): common ui changes (#1018)

* chore: common ui changes

* chore

* chore

* chore

* chore: add favicon

* feat: loading page (#1019)

* feat: Add txn receipt (#1021)

* wip: txn receipt

* chore

* wip

* chore: add txn messages

* chore: fix lint issues

* chore

* chore

* chore

* chore(ui): Txn receipt ui changes (#1025)

* chore: changes bgcolor

* chore: ui changes

* staking(ui): staking page ui changes (#1017)

* chore(staking): change staking action buttons

* chore(staking): staking ui changes

* chore(staking): ui changes

* chore

* chore

* chore: staking ui changes

* chore

* chore

* chore

* chore

* chore

* fix: loading issue (#1022)

* fix: loading issue

* fix: server side local storage bug

* chore: some nextJS weird errors, fixed the loading issue in another way

* feat: added loader animation

* refactor: assets card ui change

* chore: add ibc tag

* chore: Governance ui changes (#997)

* chore: Change the close-icon

* chanages is characterlimit, viewfullproposal and fonts

* UI changes related to the Total votes

* Review changes

* fix: review changes

* fix: eslint errors

* fix: quorum line and highlighted proposalid

* chore: review changes

* chore: fix lint issues

* chore: gov ui changes

* chore: changed divider-line

* chore: added justify-between in rightoverview

* chore: decrease the proposal-id font size

* chore: changes in votePopup

* chore: spacing in TopNav

* chore: changed the illustration

* chore: change TopNav

* chore: remove spacing in topnav

* chore: review changes

* chore: review changes

* resolved eslint errors

* fix:  jsondata field

* adjust the position of raw_data option

* ui review chnages

* chore: change the font

* chore: change the font sizes

---------

Co-authored-by: saiteja <tejargukt123@gmail.com>
Co-authored-by: Hemanth Sai <ghshemanth@gmail.com>

* chore: popup colors (#1028)

* chore: Ui changes in landingpage (#1030)

* chore: Ui changes in governance (#1029)

chore: Ui chnages in governance

* chore: common ui changes (#1031)

* chore: common ui changes

* chore: add telegram url

* fix: common ui errors (#1032)

chore: fix-common-ui-bugs

* gov(fix): fix gov proposal markdown (#1033)

* Fix: error snackbar (#1034)

* chore: fix-common-ui-bugs

* chore: fixed set error

* chore: remove snackbar

* gov(func): add loading state to vote and deposit popups (#1037)

* gov(fix): fix page break (#1040)

gov: fix page break

* chore: disable draggable to the images (#1041)

* chore: disable draggable to the images

* message

* Chary/auth middleware (#1023)

* fix merge conflicts

* add authentication layer

* fix bot errors

* remove available bal

* fixed format

* multisig: multisig iterations changes (#1042)

* chore: multisig iteration changes

* chore: multisig ui changes

* chore: add loader to verify button

* chore

* chore

* chore: add loading states

* Pavania1/landing responsive (#1045)

fix: responsive for landingpage

* chore: added isFeeEnough hook to assist transactions (#1044)

chore: allow transactions only when there is enough fee

* gov(ui): add loader  (#1046)

* gov(ui): add loader

* chore

* feat: state mutation after successful transactions (#1047)

* chore: allow transactions only when there is enough fee

* chore: state mutation after transactions

* Changes in governance ui (#1048)

* gov(ui): add loader

* chore

* fix(ui) : resolved ui changes in governance

---------

Co-authored-by: hemanthghs <ghshemanth@gmail.com>

* chore: change networks list (#1043)

* chore(multisig): multisig issues (#1050)

* chore: multisig issues

* chore: add loader to txns list

* chore: change salt value to random number

* fix: fix ui and functionality bugs (#1051)

refactor: fixed some ui and functionality bugs

* multisig(fix): remove authtokens (#1052)

multisig(fix): remove authtoken

* feat: added responsiveness to assets (#1053)

* refactor: fixed some ui and functionality bugs

* feat: made assets cards responsive

* chore: lint fix

---------

Co-authored-by: chary <57086313+charymalloju@users.noreply.github.com>

* Chary/readme (#1055)

* fix merge conflicts

* add read me file

* fixed grammatical mistakes

* fix: fixed some issues and updates (#1054)

* refactor: fixed some ui and functionality bugs

* feat: made assets cards responsive

* chore: lint fix

* chore: fix bugs and ui issues

* chore: separate claim All and claim

* chore: console response

* remove some console statements

* chore: removed unnecessary empty callbacl

* chore: staking issues (#1056)

* chore: staking changes

* chore: disalbe image dragging

* fix: wallet issue fix (#1058)

chore: fixed wallet issue

* fix: recent transactions issue (#1059)

* chore: fixed wallet issue

* chore: recent transactions issue

* chore

* update readme

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: pavania1 <adinapavani@gmail.com>
Co-authored-by: saiteja <tejargukt123@gmail.com>
Co-authored-by: Teja2045 <106052623+Teja2045@users.noreply.github.com>
Co-authored-by: aleem1314 <aleem@vitwit.com>
Co-authored-by: chary <57086313+charymalloju@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Co-authored-by: pavania1 <117721819+pavania1@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: charymalloju <chary@vitwit.com>
aleem1314 added a commit that referenced this pull request Jan 4, 2024
* Resolute next js (#805)

* Delete all files

* Add nextJS template

* remove readme from frontend

* yarn

* changed the names

* added voteforproposal popup

* Integrate connect wallet popup

* ui: Adjust backgorund color and image

* added the groups 2nd page

* feegrant page - 1

* feegrant page - 2

* Resolve conflicts

* Add tables in feegrant

* added the group 2nd page components

* Add tabs group in groups page

* feat: integrated multiple wallets

* chore: fixed sidebar

* review changes

* review changes home page

* refactor: change css class names

* refactor: change css class names

* wip

* wip: refactor

* refactor: connect wallet nuances

* added wallet key change event listeners

* Add redux store

* feat: wallet redux state

* fix: redux state when reloaded

* chore: reload UX

* chore: update github action

---------

Co-authored-by: pavania1 <adinapavani@gmail.com>
Co-authored-by: saiteja <tejargukt123@gmail.com>
Co-authored-by: Teja2045 <106052623+Teja2045@users.noreply.github.com>
Co-authored-by: aleem1314 <aleem@vitwit.com>

* created  AllMultisigAccount page and Multisig tabs

* feat: integrated cosmosJS and bank slice

* Revert "feat: integrated cosmosJS and bank slice"

This reverts commit 6770216.

* Revert "Revert "feat: integrated cosmosJS and bank slice""

This reverts commit 00ec1bc.

* chore: deleted node modules

* chore: install dependencies

* chore

* fix: fix build issue with window object (#841)

* chore: fixings bug

* chore: review changes

* chore

* chore: removed js files and unused files

* chore: made review changes

* fix: add eslint (#849)

* fix: add eslint

* add yarn lock file

* change node version frontend workflow

* change next js version 14.0.1

* remove lint to yarn build

* chore

* chore: bank state

* fix

* chore

* fix: fix eslint issues (#851)

* fix: fix eslint issues

* eslint change

* chore: lint changes

* review changes

* review changes

* chore: bank state types

* chore: fixing some types

* refactor: refactored the cosmjs files

* refactor: review changes

* chore

* chore

* review changes

* chore

* Update frontend.yml (#854)

* chored: removed passage code

* chore

* build: implemented redux state for staking (#865)

* build: implemented redux state for staking

* chore: added declarations *.d.ts files

* chore: fixed a lint issue

* chore: fixed build errors

* ui: Add sidebar (#870)

* Added SideNav bar

* Add sidebar

---------

Co-authored-by: pavania1 <adinapavani@gmail.com>

* feat: integration of starting overview page (#869)

* feat: integration of starting overview page

* refactor: review changes

* chore

* refactor: implemented custom hooks for clean code

* chore

* feat: Add common slice and common service (#877)

* feat: Add common slice and common service

* chore

* Add types file

* chore

* Review changes

* chore

* ui: change backgroud colors and sidebar (#881)

* chore(deps): bump @types/react from 18.2.22 to 18.2.37 in /frontend (#862)

Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.2.22 to 18.2.37.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump @types/react-dom from 18.2.7 to 18.2.15 in /frontend (#863)

Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 18.2.7 to 18.2.15.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom)

---
updated-dependencies:
- dependency-name: "@types/react-dom"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: implemented Overview UI (#882)

* feat: integration of starting overview page

* refactor: review changes

* chore

* refactor: implemented custom hooks for clean code

* chore

* feat: implemented governance UI

* feat: implemented UI

* feat: implemented UI

* feat: implented overview UI

* chore

* chore

* chore: review changes

* chore: review changes

* feat: Add getUnbondingDelegations reducer (#887)

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix: fixed transaction signing error (#890)

fix: fixed transaction error

* feat: implemented chain specific overview (#888)

* feat: integration of starting overview page

* refactor: review changes

* chore

* refactor: implemented custom hooks for clean code

* chore

* feat: implemented governance UI

* feat: implemented UI

* feat: implemented UI

* feat: implented overview UI

* chore

* chore

* chore: review changes

* chore: review changes

* feat: implemented chain specific overview

* chore

* chore: review changes

* chore

* chore: review changes

* chore: review changes

* feat: Add distribution slice (#891)

* feat: Add distribution slice

* review changes

* feat: implemented auth slice (#892)

* feat: integration of starting overview page

* refactor: review changes

* chore

* refactor: implemented custom hooks for clean code

* chore

* feat: implemented governance UI

* feat: implemented UI

* feat: implemented UI

* feat: implented overview UI

* chore

* chore

* chore: review changes

* chore: review changes

* feat: implemented chain specific overview

* chore

* chore: review changes

* feat: implemented auth slice

* chore: fixed lint errors

* feat(gov): Implement gov slice (#895)

* wip(gov): gov slice

* wip(gov): refactor

* chore(gov)

* gov: Add getDepositProps reducer

* wip(gov)

* wip(gov): add get proposal

* (gov): add constants

* feat(gov): Add txDeposit and txVote

* chore(gov): review changes

* refactor(gov): review changes

* feat: Implement select network and add network (#899)

* wip: Add select network dialog

* chore

* wip

* wip: select network

* wip: Add new network

* wip(add network)

* chore(add network): change network config schema

* Add rounting

* chore(select network)

* chore(select-network)

* chore(select-network): review changes

* review changes

* feat: implement transaction history (#893)

* feat: implented transaction history logic

* chore

* chore: clean code

* Implented recent transactions

* chore: clean code

* chore: small fix

* feat: implented actions

* chore

* fix: lint errors

* chore: tx loading

* chore

* refactor: review changes

* chore: small UI changes

* chore: close ads

* chore

* fix: add memo in Transaction type (#904)

fix: tx fix

* chore(deps): bump typescript from 5.2.2 to 5.3.2 in /frontend (#884)

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.2.2 to 5.3.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.2.2...v5.3.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: Implement staking page (#901)

* Add staking overview ui

* wip: Staking ui

* chore

* Add unbonding ui

* Integrate delegations

* wip

* Add all validators dialog

* Integrate search option

* fix: fix lint issues

* chore

* fix

* wip

* wip

* Add unbonding delegations

* chore

* wip

* Add validators status

* wip

* Add validator logos

* fix: fix lint issues

* chore

* refactor

* chore

* chore

* staking: changes

* wip

* refactor(staking)

* feat(staking): Add staking actions (#906)

* feat(staking): Add delegate dialog

* chore(staking-actions)

* wip(staking): Add delegate action to staking cards

* chore(staking-actions): Customize mui text field

* wip(staking-actions-changes)

* wip(staking): Add undelegate action

* wip(staking-actions): Add redelegate

* wip(staking): Add claim, claim and stake

* wip(Staking-actions)

* refactor

* refactor(staking): Add interfaces for props

* refactor(staking)

* refactor(staking)

* wip(staking): add claim and stake

* refactor(staking)

* chore(staking-actions): review changes

* chore(staking-actions): review changes.

* chore(multisig page): review changes

* chore(staking-actions): Review changes-2

* chore(staking-page): review changes

* feat: add transaction success popup (#907)

* Added TransactionSuccess Popup

* Transaction Success Popup

* PR chnages

* ConnectWalletPopup

* removed the errors

* Update frontend/src/components/WalletPopup.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* chore: fix build (#919)

* feat: ui improvements and txPopup integration (#921)

* feat: ui improvements and txPop integration

* chore: txPop integration in distribution

* chore: fixed gov slice

* chore: review changes

* feat: transfers (#915)

* build: transfers layout and recent transactions

* feat: assets integration in transfers page

* chore: txStatus type fix

* refactor: transfer support for all networks

* feat: added send page form

* feat: send transaction action

* chore: lint fix

* refactor: review changes

* chore: add loading

* chore: fixed loading for assets

* chore: ui change

* chore: overflow scroll

* refactor: review changes

* chore: fixed css syntax error

* chore: review changes

* chore: key change for assets list

* chore: review changes

* chore: css fix

* refactor: refactor select assets ui

* chore: yarn lock

* chore: review changes

* feat: add API for recent multisig txns (#922)

* add delete multisig account api

* add account of all multisig account txns

* remove multisig account

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* feat: implement multi-transfer (#926)

* build: transfers layout and recent transactions

* feat: assets integration in transfers page

* chore: txStatus type fix

* refactor: transfer support for all networks

* feat: added send page form

* feat: send transaction action

* chore: lint fix

* refactor: review changes

* chore: add loading

* chore: fixed loading for assets

* chore: ui change

* chore: overflow scroll

* refactor: review changes

* chore: fixed css syntax error

* chore: review changes

* chore: key change for assets list

* chore: review changes

* chore: css fix

* refactor: refactor select assets ui

* feat: implemented Multi-send

* chore: cursor Poiner for deleting message

* fix: delete message fix

* chore: review changes

* refactor: review changes

* chore: review changes

* feat: responsive padding and history transactions

* feat(multisig): Implement multisig slice (#912)

* wip(multisig-slice)

* wip(multisig-slice)

* feat(multisig): Add multisig slice

* chore(multisig-slice): resolve lint issues

* chore(multisig-slice)

* refactor(multisig slice)

* chore

* chore(multisig-slice): review changes

* chore(multisig-slice): review changes

* chore(multisig-slice): Review changes

* chore(multisig-slice): review changes

* feat: add governance page (#872)

* Added SideNav bar

* Ui for the Governance main page

* Made chnages required in the PR

* removed main from the css file

* added history-icon

* Add changes required for the PR

* All the ui screens for governance

* Added chnages in DepositPopup

* chore

* Review changes

* Chnaged Radio button component name

* Review chnages

* Review changes

* Review changes

* chnages in RightOverview

* Added json files requested in the PR

* changes in page.tsx

* some ui changes

* chnages

* add integration for list of proposals

* fix(gov): fix custom hooks issue

* fix eslint issues

* fix single proposal overview

* debug: vote txn error

* Made UI changes

* Added proposalId selected and chnages in govSlice

* fix: build issues

* Update frontend/src/app/(routes)/governance/ProposalOverviewVote.tsx

not it's not the correct way.
the quorum value is accessing form the proposalOverviewData file

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* review changes

* review changes

* review chnages

* eslint-disable for _ChainName

* Added ReactMarkdown package

* review chnages

* fix:eslint error

* fix: all the changes

* chore(gov): gov page changes (#931)

* chore(gov): fixes

* wip(gov): fixes

* chore(gov): gov fixes

* chore(gov): remove lint issues

* chore(gov): gov improvements

* feat(gov): Add proposal projection

* chore(gov): ui changes

---------

Co-authored-by: Hemanth Sai <ghshemanth@gmail.com>
Co-authored-by: charymalloju <chary@vitwit.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* refactor: overview page review changes (#935)

* refactor: overview ui review changes

* chore: remove hover state for transfers card

* chore: no assets style change

* chore: font change

* refactored: refactored assets information implementation

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* chore(staking): Staking UI iterations (#939)

* wip(staking-ui): Staking ui changes

* chore(staking): staking ui changes

* chore

* chore(staking): review change

* Fix: Changes in UI (#940)

* Fix: Changes in UI

* Fix: UI for Rightoverview

* fix: ProposalOverviewvote

* chore: fix tailwindcss warnings (#952)

* refactor: transfers UI changes (#951)

* refactor: overview ui review changes

* chore: remove hover state for transfers card

* chore: no assets style change

* chore: font change

* refactored: refactored assets information implementation

* refactor: transfers UI refactor

* chore: review changes

* chore: layout change

* chore: top nav padding

* refactor: layout changes and hide pagination

* chore: pagination change

* chore: lint fix

* chore: remove transaction icon and add extra column for asset value in Assets table (#953)

* chore: review changes

* chore: remove commented lines

* add delete multisig account api (#920)

* add delete multisig account api

* validatoe multisig account exists

* fix error format messages

* add db txn to delete account

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix:networks popup ui changes  (#954)

* fix:Chnages inAddNetworkPopup

* fix: Change the background of select network

* fix:decrease opacity of horizontal line

* changed the all-networks-icon

* fix: fix the characters of a network

* fix: changed the TopNav in select network

* chnaged the dropdown

* Update frontend/src/components/SelectNetwork.tsx

* Update frontend/src/components/SelectNetwork.tsx

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix(ui): sidebar review changes (#955)

* fix: changes in SideNavbar

* chnages in sideNavbar

* fix: added tooltip to topnavbar

* feat(multisig): Implement multisig page (#910)

* wip(multisig): Add layout

* wip(multisig-slice)

* wip(multisig-slice)

* feat(multisig): Add multisig slice

* chore(multisig-slice): resolve lint issues

* chore(multisig-slice)

* refactor(multisig slice)

* chore

* chore(multisig-slice): review changes

* chore(multisig-slice): review changes

* chore(multisig-slice): Review changes

* chore(multisig-slice): review changes

* ui: Multisigcard component (#911)

* wip(multisig-ui)

* wip(multisig): Add multisig info page

* wip(multisig): Create new multisig

* wip(multisig)

* wip(multisig)

* feat(multisig): List txns

* feat: Add create multisig account

* wip(multisig): Create txn

* wip(multisig): Add send txn form

* wip(multisig): Add delegate txn

* wip(multisig): Add signTx and broadCastTx

* wip(multisg)

* wip(multisig): refactor

* wip(multisig): refactor code

* wip

* chore

* refactor(multisig): review changes (#956)

* wip(multisig): review changes

* wip(multisig): review changes-2

* wip(multisig): review changes-3

* wip(multisig): review changes-4

* chore(multisig): review changes

* chore(multisig): review changes

* chore(multisig): review changes

* chore(multisig): review changes

---------

Co-authored-by: pavania1 <117721819+pavania1@users.noreply.github.com>

* fix: all networks logo size (#957)

* fix: all networks logo size

* fix:all network-logo-size

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix: fix add network config format (#965)

fix: fix network config format

* feat(ui): Add custom alert bar (#964)

* feat(ui): Add custom alert bar

* chore: review changes

* chore: review changes

* addded new drop-down icon (#961)

* fix: Changes implemented in transaction popup (#958)

* Displaying the quorum reached and required (#959)

* Displaying the quorum reached and required

* fix: validation errors and ui chnages

* review changes

* added scrollbar

* eslint error resolved

* eslint errors resolved

* chore(gov): proposalInfo ui fix

* fix: internalscroll

* removed unnecessary text

* review chnages

* review changes

* radded Tooltip to quorumrequired

* added quorumrequired

---------

Co-authored-by: hemanthghs <ghshemanth@gmail.com>

* staking(ui): fix staking page ui issues (#967)

* wip: staking ui issues

* wip: staking ui issues

* wip(staking-ui-issues)

* wip(staking-ui-issues)

* chore(ui): Add no data found ui

* wip: staking-ui-issues

* feat: implemented ibc transfers (#969)

* feat: implemented ibc transfers

* chore: build fix and review changes

* chore: review change

* chore: deleted unused file

* fix: ibc denom not found bug

* fix: ui issues (#978)

* fix: fix Nan years time bug

* fix: fix claim action loading bug

* fix: temporary fix for transaction failed case

* chore: Fix the quorum required (#977)

* add undelegate and redelegate txns in multisig (#968)

* add undelegate and redelegate txns in multisig

* add list account of all multisig txns

* add delete operation for multisig

* fix all multisig account txns

* chore: update get all multisig txns (#970)

* chore(multisig): fix multisig all txns issue (#971)

* chore: resolve lint issues

* fix: fix all multisigs txn issues

* chore: fix lint issues

* chore(multisig): ui fixes

* chore

* chore: review changes

* feat: Add file upload txn (#979)

* chore: resolve lint issues

* fix: fix all multisigs txn issues

* chore: fix lint issues

* chore(multisig): ui fixes

* chore

* chore: review changes

* wip

* feat(multisig): add file upload txn

* chore: add resetError

* chore: fix

* chore: review changes

---------

Co-authored-by: Hemanth Sai <ghshemanth@gmail.com>

* chore: ui improvements (#980)

* chore: remove alerts and improve amount validations

* chore: multiple keplr requests issue

* chore: removed msgs after submission

* chore: clear messages after multi-transfer submission

* chore: messages clear change

* chore: persist messages when tx failed in multi transfer

* fix: fix multisig issues (#987)

* fix: fix multisig issues

* chore: review changes

* chore: changes networks list

* Update server.go (#988)

* fix(server): fix backend issue (#992)

fix(backend): fix backend issues

* staking(ui): fix staking ui issues (#1000)

* refactor(ui): staking ui changes

* refactor(ui): staking ui issues

* refactor(ui): staking ui changes

* refactor: ui changes (#999)

* refactor: ui changes

* chore: icons padding

* chore: adjusted button width

* feat: implement landing page (#937)

* Landingpage

* Landingpage

* removing the white spaces at the bottom

* changed button

* implement Landingpage

* fix: review changes

* review changes

* add bgcolor for the selected network

* added hover and pointer to walletbuttons

* added background animation

* added background animation

* chore: fix ui issues

* fix: eslint errors

* resolved eslint issues

* fix:eslint errors

* chore: review changes

* chnages in connectwallet

* fix: padding issues

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* chore: overview page ui changes (#1003)

* refactor: overview changes

* refactor: copy to clipboard component

* chore: review changes

* refactor: refactored transfers page (#1009)

refactor: refactored transfers ui

Co-authored-by: chary <57086313+charymalloju@users.noreply.github.com>

* chore(deps): add sharp package for image optimization (#1007)

chore(deps): add sharp package

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* fix: proposal details and date format(ui) (#1005)

* fix: proposal details and date format

* chore: added tooltips to the proposal details

* fix: review changes

---------

Co-authored-by: chary <57086313+charymalloju@users.noreply.github.com>

* feat: Implement cancel unbonding delegations (#960)

* wip(cancel-unbonding)

* fix: fix amino converter

* chore

* chore

* chore(ui): fix common ui issues (#1008)

* chore(ui): common ui changes

* chore: review changes

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* Chore: Ui issues related to Deposit (#1010)

* Chore: Ui issues related to Deposit

* chore: added deposit details in the deposit overview

* fix: ui changes in deposit

* chore: resolved eslint issues

* feat: transfers and overview illustrations (#1013)

* feat: add illustrations

* chore: fix image shape

* chore(transfers): input field focus and add download icon (#1011)

* chore: text fields focus and download-icon

* chore: padding alignment of memo field

* chore: added illsutration to governance (Proposals not found) (#1012)

* chore: added illsutration

* chore: removed absolute positioning

* Update frontend/src/utils/messages.json

---------

Co-authored-by: saiteja <tejargukt123@gmail.com>
Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>

* feat: add ibc transfer note (#1015)

* chore: text fields focus and download-icon

* chore: padding alignment of memo field

* feat: added ibc badge

* fix: fixed page shifting

* chore: review change

* multisig(ui): fix multisig ui issues (#1006)

* wip(multisig): multisig ui changes

* chore(multisig): multisig ui changes

* chore(multisig): multisig ui issues

* chore(multisig(: Add illustration for no txns

* chore(multisig): Add illustration for no txns

* chore

* chore: review change

* chore

* chore(ui): add illustrations for empty screens

* chore(ui): multisigui changes

* chore

* refactor: discussed changes (#1016)

* chore: text fields focus and download-icon

* chore: padding alignment of memo field

* feat: added ibc badge

* fix: fixed page shifting

* chore: review change

* refactor: review changes

* chore: illustration positioning

* chore

* chore: recent transactions margin

* fix: fixed addresses issue for multi hop ibc transfers

* disabled draggability

* lint fix

* chore: landing page fix

* chore: fixed padding in transfers page

* common(ui): common ui changes (#1018)

* chore: common ui changes

* chore

* chore

* chore

* chore: add favicon

* feat: loading page (#1019)

* feat: Add txn receipt (#1021)

* wip: txn receipt

* chore

* wip

* chore: add txn messages

* chore: fix lint issues

* chore

* chore

* chore

* chore(ui): Txn receipt ui changes (#1025)

* chore: changes bgcolor

* chore: ui changes

* staking(ui): staking page ui changes (#1017)

* chore(staking): change staking action buttons

* chore(staking): staking ui changes

* chore(staking): ui changes

* chore

* chore

* chore: staking ui changes

* chore

* chore

* chore

* chore

* chore

* fix: loading issue (#1022)

* fix: loading issue

* fix: server side local storage bug

* chore: some nextJS weird errors, fixed the loading issue in another way

* feat: added loader animation

* refactor: assets card ui change

* chore: add ibc tag

* chore: Governance ui changes (#997)

* chore: Change the close-icon

* chanages is characterlimit, viewfullproposal and fonts

* UI changes related to the Total votes

* Review changes

* fix: review changes

* fix: eslint errors

* fix: quorum line and highlighted proposalid

* chore: review changes

* chore: fix lint issues

* chore: gov ui changes

* chore: changed divider-line

* chore: added justify-between in rightoverview

* chore: decrease the proposal-id font size

* chore: changes in votePopup

* chore: spacing in TopNav

* chore: changed the illustration

* chore: change TopNav

* chore: remove spacing in topnav

* chore: review changes

* chore: review changes

* resolved eslint errors

* fix:  jsondata field

* adjust the position of raw_data option

* ui review chnages

* chore: change the font

* chore: change the font sizes

---------

Co-authored-by: saiteja <tejargukt123@gmail.com>
Co-authored-by: Hemanth Sai <ghshemanth@gmail.com>

* chore: popup colors (#1028)

* chore: Ui changes in landingpage (#1030)

* chore: Ui changes in governance (#1029)

chore: Ui chnages in governance

* chore: common ui changes (#1031)

* chore: common ui changes

* chore: add telegram url

* fix: common ui errors (#1032)

chore: fix-common-ui-bugs

* gov(fix): fix gov proposal markdown (#1033)

* Fix: error snackbar (#1034)

* chore: fix-common-ui-bugs

* chore: fixed set error

* chore: remove snackbar

* gov(func): add loading state to vote and deposit popups (#1037)

* gov(fix): fix page break (#1040)

gov: fix page break

* chore: disable draggable to the images (#1041)

* chore: disable draggable to the images

* message

* Chary/auth middleware (#1023)

* fix merge conflicts

* add authentication layer

* fix bot errors

* remove available bal

* fixed format

* multisig: multisig iterations changes (#1042)

* chore: multisig iteration changes

* chore: multisig ui changes

* chore: add loader to verify button

* chore

* chore

* chore: add loading states

* Pavania1/landing responsive (#1045)

fix: responsive for landingpage

* chore: added isFeeEnough hook to assist transactions (#1044)

chore: allow transactions only when there is enough fee

* gov(ui): add loader  (#1046)

* gov(ui): add loader

* chore

* feat: state mutation after successful transactions (#1047)

* chore: allow transactions only when there is enough fee

* chore: state mutation after transactions

* Changes in governance ui (#1048)

* gov(ui): add loader

* chore

* fix(ui) : resolved ui changes in governance

---------

Co-authored-by: hemanthghs <ghshemanth@gmail.com>

* chore: change networks list (#1043)

* chore(multisig): multisig issues (#1050)

* chore: multisig issues

* chore: add loader to txns list

* chore: change salt value to random number

* fix: fix ui and functionality bugs (#1051)

refactor: fixed some ui and functionality bugs

* multisig(fix): remove authtokens (#1052)

multisig(fix): remove authtoken

* feat: added responsiveness to assets (#1053)

* refactor: fixed some ui and functionality bugs

* feat: made assets cards responsive

* chore: lint fix

---------

Co-authored-by: chary <57086313+charymalloju@users.noreply.github.com>

* Chary/readme (#1055)

* fix merge conflicts

* add read me file

* fixed grammatical mistakes

* fix: fixed some issues and updates (#1054)

* refactor: fixed some ui and functionality bugs

* feat: made assets cards responsive

* chore: lint fix

* chore: fix bugs and ui issues

* chore: separate claim All and claim

* chore: console response

* remove some console statements

* chore: removed unnecessary empty callbacl

* chore: staking issues (#1056)

* chore: staking changes

* chore: disalbe image dragging

* fix: wallet issue fix (#1058)

chore: fixed wallet issue

* fix: recent transactions issue (#1059)

* chore: fixed wallet issue

* chore: recent transactions issue

* fix: explorer endpoint (#1063)

* chore: fixed wallet issue

* chore: recent transactions issue

* chore: fix endpoint

* chore: change endpoint

* chore: rounding the images

* chore

* chore

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: pavania1 <adinapavani@gmail.com>
Co-authored-by: saiteja <tejargukt123@gmail.com>
Co-authored-by: Teja2045 <106052623+Teja2045@users.noreply.github.com>
Co-authored-by: aleem1314 <aleem@vitwit.com>
Co-authored-by: chary <57086313+charymalloju@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Co-authored-by: pavania1 <117721819+pavania1@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: charymalloju <chary@vitwit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants