visjs-network#39: add penwidth support for dot language #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojoaxel
commented
Jul 26, 2019
mojoaxel
pushed a commit
that referenced
this pull request
Jul 27, 2019
'penwidth' defines the line width as 'width'. If both are exist, 'penwidth' is used and 'width' is discarded as described in [1]. This update fixes #24. [1] https://www.graphviz.org/doc/info/attrs.html#d:penwidth
To reduce the number of statements of parseAttributeList(), move parsing 'dir' attribute to function parseDirAttribute() because it is going to reach max-statements limitation of lint.
'penwidth' defines the line width as 'width'. If both are exist, 'penwidth' is used and 'width' is discarded as described in [1]. This update fixes #24. [1] https://www.graphviz.org/doc/info/attrs.html#d:penwidth
|
I think this is ready to be merged! The screenshot shows that it worked, but feel free to check it yourself before merging. Thanks! |
|
@Thomaash Can you please have a look at this. I think we can merge this! |
Thomaash
approved these changes
Jul 28, 2019
This example has been updated: |
|
Yeah. But it doesn't have the beauty of running |
I have no ide how to test something like this without a "visual" test. See also #33 for this. |
|
@Thomaash @yotamberk Can somebody please merge this so that I can create the next big release. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an original contribution from @geminoa: visjs-community/visjs-network#39
part of #7