Add penwidth attribute #39
Conversation
To reduce the number of statements of parseAttributeList(), move parsing 'dir' attribute to function parseDirAttribute() because it is going to reach max-statements limitation of lint.
'penwidth' defines the line width as 'width'. If both are exist, 'penwidth' is used and 'width' is discarded as described in [1]. This update fixes visjs-community#24. [1] https://www.graphviz.org/doc/info/attrs.html#d:penwidth
Add an example penwidth attribute for dot language support.
|
Here is an example. http://127.0.0.1:8080/examples/data/dotLanguage/dotEdgeStyles/
|
|
will take a look at this 😄 thanks for including an example! |
|
I got the example running locally and it looks good to me. http://127.0.0.1:8080/examples/data/dotLanguage/dotEdgeStyles/
|
|
@micahstubbs thanks for your advice! I have used npm and did not understand that |
|
@geminoa no problem 😄, thanks for the contribution! I add this small format requirement to make the diffs smaller when we review code. (there are other benefits too 😄) the tool we use is https://prettier.io/, in case you are curious. |
|
@geminoa just published a new version on npm that includes these dotLanguage |
|
💌 Thanks @geminoa for your contribution! |
This series of patches is for adding 'penwidth' attribute for dot parser which defines the line width as described in [1]. It includes refactoring of parseAttributeList() for reducing the number of lines to avoid max-statements limitation of lint.
[1] https://www.graphviz.org/doc/info/attrs.html#d:penwidth