fix: issue with uncaught UnicodeDecodeError #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though, there are methods to safely get the json from file, string, or url even, there is no surely that people will not pass their own data into the json2xml.Json2xml() contructor. However, if the data is corrupt or mal-formed, there is a chance an exception can be raised, brining the program to a halt. Hence, a new error type is introduced, that protects against it and raises InvalidDataError exception which can that be caught and logged in a program that uses Json2xml. - Github Issue: #106 Authored-by: Vinit Kumar <mail@vinitkumar.me> Signed-off-by: Vinit Kumar <mail@vinitkumar.me>
|
This pull request introduces 1 alert when merging 194ecbe into 8a996f1 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though, there are methods to safely get the json from file, string,
or url even, there is no surely that people will not pass their own data
into the json2xml.Json2xml() contructor.
However, if the data is corrupt or mal-formed, there is a chance an
exception can be raised, bringing the program to a halt.
Hence, a new error type is introduced, that protects against it and
raises InvalidDataError exception which can that be caught and logged in
a program that uses Json2xml.
Authored-by: Vinit Kumar mail@vinitkumar.me
Signed-off-by: Vinit Kumar mail@vinitkumar.me