[Uncaught exception] UnicodeDecodeError when calling to_xml with arbitrary data #106
Comments
|
@Asteriska8 Thanks for raising this issue and the explanation, it would be much more helpful if you could please just paste the input data in here so that it is easier to test it. The screenshot while informative doesn't help much in using that in the code. |
|
|
Even though, there are methods to safely get the json from file, string, or url even, there is no surely that people will not pass their own data into the json2xml.Json2xml() contructor. However, if the data is corrupt or mal-formed, there is a chance an exception can be raised, brining the program to a halt. Hence, a new error type is introduced, that protects against it and raises InvalidDataError exception which can that be caught and logged in a program that uses Json2xml. - Github Issue: #106 Authored-by: Vinit Kumar <mail@vinitkumar.me> Signed-off-by: Vinit Kumar <mail@vinitkumar.me>
|
@Asteriska8 Fixed it just now. #107 Please check this pull request and possibly run this, and let me know if it looks good to you? |
|
Thanks! |
|
@Asteriska8 Awesome, I will merge and release later this evening. |
|
Thanks to your nice work and the contribution to open-source community! |
Even though, there are methods to safely get the json from file, string, or url even, there is no surely that people will not pass their own data into the json2xml.Json2xml() contructor. However, if the data is corrupt or mal-formed, there is a chance an exception can be raised, brining the program to a halt. Hence, a new error type is introduced, that protects against it and raises InvalidDataError exception which can that be caught and logged in a program that uses Json2xml. - Github Issue: #106 Authored-by: Vinit Kumar <mail@vinitkumar.me> Signed-off-by: Vinit Kumar <mail@vinitkumar.me>
|
@Asteriska8 Thanks for your report. Happy to announce that the fix is released to pypi here:
You are welcome to upgrade to this and your issues should be resolved. I will be closing this issue. Please don't hesitate to open a new issue if you find any other problems. |
Describe the bug
I found out that theJson2xml(data).to_xml() method can raise a UnicodeDecodeError leading to a crash of the running program.
This could be problematic if users of the library are dealing with untrusted data since this issue will lead to a DoS. This should be detected and an execption should be triggered
To Reproduce
Steps to reproduce the behavior:
Expected behavior
This execption should be expected.
The text was updated successfully, but these errors were encountered: