Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #7855 remove false from return type, in php8.0 and further ve… #7859

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Resolve #7855 remove false from return type, in php8.0 and further ve… #7859

merged 3 commits into from
Apr 13, 2022

Conversation

dkemper
Copy link

@dkemper dkemper commented Apr 11, 2022

…rsions there is a ValueError returned instead

Daniel Kemper added 2 commits April 11, 2022 22:44
Resolve vimeo#7855 remove false from return type, in php8.0 and furth…
8e01a12 
…er versions there is a ValueError returned instead
Resolve vimeo#7855 remove false from return type, in php8.0 and furth…
114aad4 
…er versions there is a ValueError returned instead
@AndrolGenhald
Copy link
Collaborator

It looks like you missed DateTimeImmutable in CallMap.php. Could you also check the other methods and see if they need updated? It looks like at least diff and setTime have the same issue, and there might be one or two more that I missed.

@AndrolGenhald AndrolGenhald added the release:fix The PR will be included in 'Fixes' section of the release notes label Apr 11, 2022
@orklah orklah merged commit 3b8449a into vimeo:master Apr 13, 2022
@orklah
Copy link
Collaborator

orklah commented Apr 13, 2022

Thanks!

@AndrolGenhald AndrolGenhald mentioned this pull request Jul 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkemper @AndrolGenhald @orklah