Invalid inferred return type of DateTimeImmutable::getTimestamp

[p4veI]

Hello I've come across an issue while constructing an array with timestamps used as keys, psalm is reporting false|int can't be used as array key while getTimestamp always returns an int.

e.g. https://psalm.dev/r/c45a9a0a0f

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/c45a9a0a0f

<?php

function getArr(): array
{
	$date = new DateTimeImmutable('2022-04-11 09:45');

	$arr = [$date->getTimestamp() => []];

	return $arr;
}

Psalm output (using commit 916fddb):

ERROR: InvalidArrayOffset - 7:9 - Cannot create offset of type false|int, expecting array-key

[AndrolGenhald]

According to the docs this is a PHP 8 update to throw ValueError instead of returning false. This needs to be fixed for PHP >= 8.0, but it still needs to show the issue for PHP < 8.0.

Might as well fix the other methods on DateTimeImmutable and DateTime at the same time. You can check out the CallMap documentation if you want to give it a shot.

[p4veI]

ah, yeah that explains it, I'm on php 8.1, only looked into IDE docs (for php8.1 stubs docs). Thanks for clearing this up and thanks for looking into it :)

[orklah]

this was fixed :)