Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid weird title #4747

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Avoid weird title #4747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/clickable-component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ class ClickableComponent extends Component {
* - Returns itself when setting; method can be chained.
*/
controlText(text, el = this.el()) {
if (!text) {
if (text === undefined) {
return this.controlText_ || 'Need Text';
}

Expand Down
3 changes: 1 addition & 2 deletions src/js/menu/menu-item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,7 @@ class MenuItem extends ClickableComponent {
this.removeClass('vjs-selected');
this.el_.setAttribute('aria-checked', 'false');
// Indicate un-selected state to screen reader
// Note that a space clears out the selected state text
this.controlText(' ');
this.controlText('');
}
}
}
Expand Down