Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid weird title #4747

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Avoid weird title #4747

merged 1 commit into from
Feb 13, 2018

Conversation

arski
Copy link
Contributor

@arski arski commented Nov 14, 2017

@gkatsev @misteroneill copy of #4746 for 5.x

@OwenEdwards
Copy link
Member

As with #4746, LGTM. Thanks for the catch and the fix, @arski

@OwenEdwards OwenEdwards self-requested a review November 15, 2017 18:18
@arski
Copy link
Contributor Author

arski commented Nov 29, 2017

hi there, anything else left to be done to merge this? :)

@gkatsev
Copy link
Member

gkatsev commented Nov 29, 2017

Nope, just that 5.x is lower priority, but I can probably get it merged and released this week.

@arski
Copy link
Contributor Author

arski commented Jan 10, 2018

@gkatsev any updates on this?

@arski
Copy link
Contributor Author

arski commented Jan 23, 2018

hi again, just want to get this out of my PR list :)

@arski
Copy link
Contributor Author

arski commented Feb 13, 2018

/me hits the merge button :)

@gkatsev gkatsev merged commit b1a8938 into videojs:5.x Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OwenEdwards OwenEdwards OwenEdwards approved these changes

@ldayananda ldayananda ldayananda approved these changes

Assignees
No one assigned
Labels
5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arski @OwenEdwards @gkatsev @ldayananda @misteroneill