Added 'title' attribute to the audio track button

[jbarabander]

Description

Fixes #3528.
The audio track button on the video player was missing the 'title' attribute due to the underlying component not having a controlText_ property.

Specific Changes proposed

Assigned controlText_ property of AudioTrackButton to 'Audio'.

Requirements Checklist

• Feature implemented / Bug fixed
• Reviewed by Two Core Contributors

[brandonocasey]

LGTM

[dmlap]

LGTM

[gkatsev]

LGTM

[mister-ben]

Could "Audio" be confused with the volume controls? "Audio track"?

[jbarabander]

@mister-ben: I did indeed consider this. I opted for 'Audio' because it seemed generally consistent with other controlText_ (namely most of the other titles for the buttons were one word) and I didn't personally find it super confusing. However I'd be glad to change it to 'Audio Track' if you guys deem that that would be better.

[gkatsev]

Audio is also consistent with the other menu buttons we have like captions and subtitles.

[gkatsev]

Realized we should update the en.json file: #3569

[gkatsev]

I wonder if "Audio Track" would be confusing for people not invested in video players and the technology being used.

[brandonocasey]

Perhaps "Audio Selection"? Audio To me seems to imply that you will be able to edit or view settings on the current audio track.

[heff]

I think Track is a common enough word. YouTube appears to use it in their docs a number of places at least.

[mmcc]

Yeah "Audio Track" feels like a nice compromise. Especially given this is accessibility related, I don't think there would be confusion as to what this means.

[gkatsev]

Sounds like most people would prefer "Audio Track", I'm ok with that too.

@jbarabander would you be up for making the change? Either as another commit on this branch or if you can do a PR based on the stable branch, that would be awesome. If you want to incorporate #3569 into it, would be great too.

[jbarabander]

@gkatsev Sure thing! I'll make a new PR based off the stable branch and I'll wrap #3569 into it as well.

[gkatsev]

Closing this PR then, since it's already been merged to stable and we'll have a new updated PR.