Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'title' attribute doesn't appear for audio button #3528

Closed
pagarwal123 opened this issue Aug 12, 2016 · 4 comments
Closed

'title' attribute doesn't appear for audio button #3528

pagarwal123 opened this issue Aug 12, 2016 · 4 comments

Comments

@pagarwal123
Copy link

pagarwal123 commented Aug 12, 2016

Description

title attribute doesn't appear for audio button

Steps to reproduce

  1. Load the player in socrates
  2. Under Media section -> select "advanced bip-bop"
  3. Click on Audio button

Results

Expected

There should be a title attribute displayed on clicking the Audio button

Actual

'title' attribute doesn't appear for audio button

Additional Information

versions

videojs

what version of videojs does this occur with?
5.11.2

browsers

what browser are affected?
chrome

OSes

what platforms (operating systems and devices) are affected?
OS X

@gkatsev
Copy link
Member

gkatsev commented Aug 15, 2016

The controlText_ is missing for the audio-track-button element.
This is one of those easy bugs that can should allow entry into the project or open-source in general.

@jbarabander
Copy link
Contributor

@gkatsev I'd love to take a stab at this if that's ok with you! Also much love to all you guys for Video.js. It absolutely kicks butt.

@gkatsev
Copy link
Member

gkatsev commented Aug 23, 2016

@jbarabander that would be awesome! Let me know if you need help either here or on slack (or irc).

@gkatsev gkatsev removed the unclaimed label Aug 23, 2016
@jbarabander
Copy link
Contributor

@gkatsev Awesome! Thanks so much and will do! :)

helenjer pushed a commit to helenjer/video.js that referenced this issue Sep 6, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants