Consistent width for fullscreen button and time-control #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the width of the fullscreen button to 4em. For some reason it was 3.8, but that doesn't make much sense and is not in line with the other controls. It also sets the textual time-control's width to auto with a 1em padding to the left and right. Again this is more in line with the behavior of the other controls.
|
LGTM. Thanks. |
gkatsev
added
patch
|
LGTM |
gkatsev
added
confirmed
and removed
needs: LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the width of the fullscreen button to 4em. For some
reason it was 3.8, but that doesn't make much sense and is not in line
with the other controls.
It also sets the textual time-control's width to auto with a 1em
padding to the left and right. Again this is more in line with the
behavior of the other controls.
I do find the entire interface slightly too wide to my liking, but that is exactly why it should be consistent, so that if required, it would be easier for me to override.