Skip to content

Commit

Permalink
@hartman updated fullscreen and time controls for more consistent wid…
Browse files Browse the repository at this point in the history
…ths. closes #2893
  • Loading branch information
hartman authored and gkatsev committed Feb 4, 2016
1 parent 29f66ac commit 171ec1a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ CHANGELOG
* @gkatsev updated README to include links to plugins page and getting started and cleaner link to LICENSE ([view](https://github.com/videojs/video.js/pull/3066))
* @hartman Corrected adaptive layout selectors to match their intent ([view](https://github.com/videojs/video.js/pull/2923))
* @mister-ben updated Umuted to Unmute in lang files ([view](https://github.com/videojs/video.js/pull/3053))
* @hartman updated fullscreen and time controls for more consistent widths ([view](https://github.com/videojs/video.js/pull/2893))

--------------------

Expand Down
1 change: 0 additions & 1 deletion src/css/components/_fullscreen.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.video-js .vjs-fullscreen-control {
width: 3.8em;
cursor: pointer;
@include flex(none);
}
Expand Down
4 changes: 4 additions & 0 deletions src/css/components/_time.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
@include flex(none);
font-size: 1em;
line-height: 3em;
min-width: 2em;
width: auto;
padding-left: 1em;
padding-right: 1em;

This comment has been minimized.

Copy link
@dmlap

dmlap Feb 17, 2016

Member

I didn't realize in my review but this messes up the kerning of the time display. I think we should shoot to make the entire display a consistent width but let the individual components lay themselves out with standard spacing. FYI @gkatsev

}

.vjs-live .vjs-time-control {
Expand Down

0 comments on commit 171ec1a

Please sign in to comment.