Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control buttons submit form, missing type="button" (5.0.0-rc.49) #2470

Closed
nebrot opened this issue Aug 13, 2015 · 2 comments
Closed

Control buttons submit form, missing type="button" (5.0.0-rc.49) #2470

nebrot opened this issue Aug 13, 2015 · 2 comments

Comments

@nebrot
Copy link

nebrot commented Aug 13, 2015

In my web-application i have a player which is integrated in a form with a checkbox to mark uploaded video as deleted. My problem is that all control buttons of the player submit form, because they don't have type="button", default value is "submit" (http://www.w3.org/TR/html-markup/button.html).

Example: http://jsfiddle.net/sLsvLv0q/12/
Windows 8.1: Firefox 40, Chrome 44, IE 11

@nebrot nebrot changed the title Control buttons submit form, type="button" is missing (5.0.0-rc.49) Control buttons submit form, missing type="button" (5.0.0-rc.49) Aug 13, 2015
@mmcc
Copy link
Member

mmcc commented Aug 13, 2015

@nebrot Thanks for the heads up! I opened #2471 to address this.

@nebrot
Copy link
Author

nebrot commented Aug 13, 2015

@mmcc Thanks for your fast (upcoming) fix. Keep up the great work!

mmcc added a commit to mmcc/video.js that referenced this issue Aug 13, 2015
@nebrot nebrot closed this as completed Aug 14, 2015
syranez added a commit to syranez/video.js that referenced this issue Oct 18, 2018
The default button type is "submit" which triggers a form submit. Thus
if videojs is embedded in a form element the button triggers a form
submit.

This is the same problem with same solution as discussed in videojs#2470
gkatsev pushed a commit that referenced this issue Oct 22, 2018
The default button type is "submit" which triggers a form submit. Thus
if videojs is embedded in a form element the button triggers a form
submit.

This is the same problem with same solution as discussed in #2470
gkatsev pushed a commit that referenced this issue Oct 31, 2018
The default button type is "submit" which triggers a form submit. Thus
if videojs is embedded in a form element the button triggers a form
submit.

This is the same problem with same solution as discussed in #2470
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants