Skip to content

Commit

Permalink
added type=submit to button. fixes videojs#2470
Browse files Browse the repository at this point in the history
  • Loading branch information
mmcc committed Aug 13, 2015
1 parent 39ef157 commit efc9f70
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/js/button.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,17 @@ class Button extends Component {
* @return {Element}
* @method createEl
*/
createEl(type='button', props={}) {
createEl(tag='button', props={}) {
// Add standard Aria and Tabindex info
props = assign({
className: this.buildCSSClass(),
'role': 'button',
'type': 'button', // Necessary since the default button type is "submit"
'aria-live': 'polite', // let the screen reader user know that the text of the button may change
tabIndex: 0
}, props);

let el = super.createEl(type, props);
let el = super.createEl(tag, props);

this.controlTextEl_ = Dom.createEl('span', {
className: 'vjs-control-text'
Expand Down

0 comments on commit efc9f70

Please sign in to comment.