This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Expose buffered time ranges #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning just the latest buffered position ignores the fact that the back buffer is limited in many cases. Instead, return an array of arrays that can be mapped onto time range objects in javascript. Stop sending the "seeked" event immediately on Netstream.Seek.Notify. Flash defines the seek as complete as soon as the buffer has been flushed from the previous playback position but HTML waits to trigger "seeked" until enough data is available to being playback. Trigger "seeked" from Netstream.Buffer.Full, when a seek was in progress, to match HTML behavior.
| @@ -597,10 +600,8 @@ package com.videojs.providers{ | |||
|
|
|||
| case "NetStream.Seek.Notify": | |||
| _playbackStarted = true; | |||
| _isSeeking = false; | |||
| _hasEnded = false; | |||
| _model.broadcastEvent(new VideoPlaybackEvent(VideoPlaybackEvent.ON_STREAM_SEEK_COMPLETE, {info:e.info})); | |||
There was a problem hiding this comment.
Do we still want to broadcast the stream seek complete event here?
There was a problem hiding this comment.
That event is internal-only so I didn't think it was necessary to rename/refactor it. Its definitely a little weird to see here, I just didn't want to have to track down all the usages and update them.
The values returned from NetStream.bufferLength seem to be less than, or very close to, NetStream.bufferTime for standard progressive download content. By default, NetStream.bufferTime seems to be a very small number, 0.8 seconds on my machine. This conflicts with the numbers coming back from NetStream.bytesLoaded so despite the fact that seems like an inaccurate calculation, it's better than the alternative.
| @@ -546,6 +554,11 @@ package com.videojs.providers{ | |||
| break; | |||
|
|
|||
| case "NetStream.Buffer.Full": | |||
| if (_isSeeking) { | |||
There was a problem hiding this comment.
Very nice. It's probably worth a code comment here so we don't have to dig up the issue later to know why this is here instead of Seek.Notify.
Emitting "seeked" is in location you might not expect. Explain why.
|
@heff added that comment. |
dmlap
added a commit
to dmlap/video.js
that referenced
this pull request
Aug 25, 2015
Requires videojs/video-js-swf#180. Pick up changes from the SWF that expose the start time of the current buffered region.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning just the latest buffered position ignores the fact that the back buffer is limited in many cases. Instead, return an array of arrays that can be mapped onto time range objects in javascript. Stop sending the "seeked" event immediately on Netstream.Seek.Notify. Flash defines the seek as complete as soon as the buffer has been flushed from the previous playback position but HTML waits to trigger "seeked" until enough data is available to being playback. Trigger "seeked" from Netstream.Buffer.Full, when a seek was in progress, to match HTML behavior.