Allow IsPowered to return negative power percentages. #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
JohnN193
reviewed
Mar 18, 2024
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
randhid
added
appimage-ignore-tests
martha-johnston
approved these changes
Mar 19, 2024
viambot
added
safe to test
viambot
added
safe to test
JohnN193
reviewed
Mar 19, 2024
JohnN193
reviewed
Mar 19, 2024
JohnN193
reviewed
Mar 19, 2024
JohnN193
reviewed
Mar 19, 2024
viambot
added
safe to test
viambot
added
safe to test
|
It's way worse now, but I don't have the bandwidth for a full factor of this code - and there will need to be some consideration for when we set the pins versus the locks. |
JohnN193
approved these changes
Mar 19, 2024
| @@ -214,7 +219,6 @@ func (m *Motor) setPWM(ctx context.Context, powerPct float64, extra map[string]i | |||
| } | |||
|
|
|||
| powerPct = math.Max(math.Abs(powerPct), m.minPowerPct) | |||
There was a problem hiding this comment.
[nit] I don't think we need this line anymore, since we moved the min logic to the top
There was a problem hiding this comment.
no but I'm not going to touch more in this pr. It will be merged in messy.
There was a problem hiding this comment.
Edit - no I'm msitaken. This is now the only thing making the pwmPinPower positive. otherwise the pin will crash when you set it to negative.
viambot
added
safe to test
martha-johnston
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am pretty sure this was not written expecting that PowerPct would always return positive. Just an oversight on taking the absolute value of the power percentage.
Still need to fix tests, but it should be returning negative percentages even when on now.
Please