Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-2959 - SLAM UI does not resize well #2324

Merged
merged 2 commits into from
May 5, 2023
Merged

RSDK-2959 - SLAM UI does not resize well #2324

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea1dd92
allow resize on larger monitor
nfranczak May 4, 2023
52a307b
Merge branch 'main' into RSDK-2959
nfranczak May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions web/frontend/src/components/slam-2d-render.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ raycaster.on('click', (event: THREE.Event) => {
* svgLoader example for webgl:
* https://github.com/mrdoob/three.js/blob/master/examples/webgl_loader_svg.html
*/
//
const svgLoader = new SVGLoader();
const makeMarker = async (url : string, name: string, scalar: number) => {
const data = await svgLoader.loadAsync(url);
Expand Down Expand Up @@ -411,7 +410,7 @@ watch(() => props.pointCloudUpdateCount, () => {
<template>
<div
ref="container"
class="pcd-container relative w-full"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been removed since pcd-container has not visual effect on the display of the 2D map.

class="relative w-full"
>
<p class="absolute left-3 top-3 bg-white text-xs">
Grid set to 1 meter
Expand Down
2 changes: 1 addition & 1 deletion web/frontend/src/components/slam.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ onUnmounted(() => {
/>
</div>
</div>
<div class="gap-4x border-border-1 justify-start sm:border-l">
<div class="gap-4x border-border-1 w-full justify-start sm:border-l">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all that we needed 🤯 such that we have proper size on a larger computer monitor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

<div
v-if="refreshErrorMessage2d && show2d"
class="border-l-4 border-red-500 bg-gray-100 px-4 py-3"
Expand Down