RSDK-2959 - SLAM UI does not resize well #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
nfranczak
commented
May 4, 2023
| @@ -508,7 +508,7 @@ onUnmounted(() => { | |||
| /> | |||
| </div> | |||
| </div> | |||
| <div class="gap-4x border-border-1 justify-start sm:border-l"> | |||
| <div class="gap-4x border-border-1 w-full justify-start sm:border-l"> | |||
There was a problem hiding this comment.
this is all that we needed 🤯 such that we have proper size on a larger computer monitor.
|
@nfranczak Mind attaching a quick video where you resize the screen? |
perhaps "resize" is a bit of a mis-nomer. |
nfranczak
commented
May 4, 2023
| @@ -411,7 +410,7 @@ watch(() => props.pointCloudUpdateCount, () => { | |||
| <template> | |||
| <div | |||
| ref="container" | |||
| class="pcd-container relative w-full" | |||
There was a problem hiding this comment.
this has been removed since pcd-container has not visual effect on the display of the 2D map.
|
gotcha, thanks for clarifying! |
micheal-parks
approved these changes
May 4, 2023
nicksanford
approved these changes
May 5, 2023
viambot
added
safe to test
|
Note: merge base coverage results not available, comparing against closest 0b57205~1=(97e399b) instead
|
bazile-clyde
pushed a commit
to bazile-clyde/rdk
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it such that the 2D view of the slam map occupies the entirety of the screen on a larger monitor.
screen recording 5.4.23
