fix Int value range is incorrect #862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
jude-zhu
requested review from
dutor,
whitewum,
laura-ding,
monadbobo and
CPWstatic
laura-ding
reviewed
Aug 30, 2019
| | KW_UPTO INTEGER KW_STEPS { $$ = new StepClause($2, true); } | ||
| | INTEGER KW_STEPS { | ||
| if ((uint64_t)$1 == 9223372036854775808ULL) { | ||
| LOG(ERROR) << "Integer overflow"; |
There was a problem hiding this comment.
We need to handle exceptions
There was a problem hiding this comment.
Where is the exception?
| @@ -285,8 +285,11 @@ IP_OCTET ([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5]) | |||
| yyterminate(); | |||
| } | |||
| } | |||
| int64_t val = 0; | |||
| uint64_t val = 0; | |||
There was a problem hiding this comment.
Hex and octal do not need to be processed
There was a problem hiding this comment.
why？ Don't they overflow?
|
I have fixed this problem on p #1181, so close this |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix int value range is incorrect #826