Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arithmetic overflow and set int boundary value #1181

Merged
merged 5 commits into from
Jan 7, 2020
Merged

Fix arithmetic overflow and set int boundary value #1181

merged 5 commits into from
Jan 7, 2020

Conversation

laura-ding
Copy link
Contributor

@laura-ding laura-ding commented Oct 31, 2019

  • fix arithmetic overflow
  • add unreserved keyword

close #625, close #826, close #827

@laura-ding laura-ding changed the title Fix arithmetic overflow Fix arithmetic overflow and set int boundary value Nov 4, 2019
@jude-zhu jude-zhu requested review from dutor and CPWstatic November 7, 2019 08:37
@laura-ding laura-ding added the ready-for-testing PR: ready for the CI test label Nov 11, 2019
@laura-ding
Copy link
Contributor Author

jenkins go

@nebula-community-bot
Copy link
Member

Unit testing failed.

@laura-ding
Copy link
Contributor Author

jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

2 similar comments
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

CPWstatic
CPWstatic previously approved these changes Nov 25, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@jude-zhu jude-zhu requested a review from CPWstatic December 31, 2019 08:33
@nebula-community-bot
Copy link
Member

Unit testing failed.

@laura-ding
Copy link
Contributor Author

jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit d52afc0 into vesoft-inc:master Jan 7, 2020
@nebula-community-bot
Copy link
Member

Unit testing passed.

tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* Fix arithmetic overflow

* fix vesoft-inc#826 Int value range is incorrect

* rebase upstream

* rebase upstream

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
fix

Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
5 participants