All Describe command unified get data from metad #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins go |
|
Unit testing failed. |
dutor
reviewed
Jun 3, 2019
| auto spaceId = req.get_space_id(); | ||
| auto spaceRet = getSpaceId(req.get_space_name()); | ||
| if (!spaceRet.ok()) { | ||
| resp_.set_code(to(std::move(spaceRet.status()))); |
There was a problem hiding this comment.
use std::move(spaceRet).status() instead.
BTW. Please change to to passing by const reference. Then here std::move is no longer needed.
| @@ -316,7 +330,7 @@ TEST(ProcessorTest, CreateEdgeTest) { | |||
| ASSERT_EQ(cpp2::ErrorCode::E_EXISTED, resp.code); | |||
| } | |||
| { | |||
| // create same name edge in diff spaces | |||
| // Create same name edge in diff spaces | |||
|
Unit testing passed. |
dutor
previously approved these changes
Jun 5, 2019
|
Unit testing passed. |
dangleptr
reviewed
Jun 5, 2019
| auto error = [this] (auto &&e) { | ||
| LOG(ERROR) << "Exception caught: " << e.what(); | ||
| DCHECK(onError_); | ||
| onError_(Status::Error("Internal error")); |
There was a problem hiding this comment.
Output the real error message.
There was a problem hiding this comment.
The error message is internal, I think user can’t need konw it directly, but need to Unified classification of error information in the future. Please accept it.
| auto error = [this] (auto &&e) { | ||
| LOG(ERROR) << "Exception caught: " << e.what(); | ||
| DCHECK(onError_); | ||
| onError_(Status::Error("Internal error")); |
dangleptr
previously approved these changes
Jun 6, 2019
|
Unit testing passed. |
dangleptr
approved these changes
Jun 6, 2019
|
Unit testing failed. |
|
jenkins go |
|
Unit testing passed. |
dutor
approved these changes
Jun 6, 2019
|
close #435 |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
* Describe Tag and Edge from metad * Address dutor's comment * Fix to
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Describe Tag and Edge from metad * Address dutor's comment * Fix to
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、Describe Tag and Edge from metad
2、"Use space" get spaceId from metad
3、Modify DescribeSpace