Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it takes too long to describe a tag after creating it under wsl docker #435

Closed
whitewum opened this issue May 26, 2019 · 8 comments
Closed
Assignees
Milestone

Comments

@whitewum
Copy link
Contributor

whitewum commented May 26, 2019

My environment is wsl.

first I create a tag: CREATE TAG player4(name string, age int);

then i have to wait quite a long time ( about 10sec) to successfully describe tag player4.

During this long period, what i can get is [ERROR (-8)]: Schema not found for tag `player4'

By the way, I know the flag load_data_interval_secs , but i can't find it in the config files in the docker any more.

@dutor
Copy link
Contributor

dutor commented May 27, 2019

This problem is due the synchronization of the meta infos among our different processes. For now the meta infos are updated through periodic polling.

To address this problem we need to some kind of broadcast mechanism or forced update through a user command.

@sherman-the-tank
Copy link
Member

This is definitely a bug. When we DESCRIBE a tag/edge/etc., we should read it from the meta server

@dangleptr
Copy link
Contributor

It is a bug. Currently, show space/edge/tag and describe space are fetched from meta server, but describe tag/edge is fetched from meta client cache.
We should keep them consistency. All show/describe should fetch information from server directly.

@dangleptr
Copy link
Contributor

@laura-ding Do you want to fix it?

@whitewum
Copy link
Contributor Author

My question is: why 10 seconds? The fetch loop cycle is only 1 or 2 sec.

@sherman-the-tank sherman-the-tank added this to the v1_beta_release milestone May 30, 2019
@laura-ding
Copy link
Contributor

I thought the user created a schema, usually read back the schema firstly, then insert the data via the cached schema. So describe uses the cached schema, it can tell the user in advance whether you can insert data.

@laura-ding
Copy link
Contributor

@dangleptr I will modify it to get schema by meta server

@laura-ding
Copy link
Contributor

Under docker, the default value of load_data_interval_secs is 2min, now all describe command unified get data from metad, it doesn't need to wait.

yixinglu pushed a commit to yixinglu/nebula that referenced this issue Mar 21, 2022
#### What type of PR is this?
- [ ] bug
- [x] feature
- [ ] enhancement

#### What does this PR do?


#### Which issue(s)/PR(s) this PR relates to?

  
#### Special notes for your reviewer, ex. impact of this fix, etc:


#### Additional context/ Design document:


#### Checklist:
- [x] Documentation affected (Please add the label if documentation needs to be modified.)
- [x] Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory

#### Release notes:

A little incompatible: The returned column names are the same sequence with the declared columns, while it is random in former release.
```
      MATCH (v:player)-[:like]->(v2)
      WHERE v.name == "Tony Parker" and v2.age == 42
      WITH *, v.age + 100 AS age
      RETURN *, v2.name
```
Now this query returns:
```
      | v    | v2   | age | v2.name      |
```


New features:

```
      MATCH (m)-[]-(n), (n)-[]-(l) WHERE id(m)=="Tim Duncan"
      RETURN m.name AS n1, n.name AS n2, l.name AS n3 ORDER BY n1, n2, n3 LIMIT 10
```

```
      MATCH (m)-[]-(n) WHERE id(m)=="Tim Duncan"
      MATCH (n)-[]-(l)
      RETURN m.name AS n1, n.name AS n2, l.name AS n3 ORDER BY n1, n2, n3 LIMIT 10
```

```
      MATCH (m)-[]-(n) WHERE id(m)=="Tim Duncan"
      OPTIONAL MATCH (n)<-[:serve]-(l)
      RETURN m.name AS n1, n.name AS n2, l AS n3 ORDER BY n1, n2, n3 LIMIT 10
```

We have more test cases in pr vesoft-inc#3537 

Migrated from vesoft-inc#3519

Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants