-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limits for add and recover balance data or zone balance jobs #4104
Conversation
9f4de85
to
8bf228b
Compare
… firstly recover it
8bf228b
to
ce3b613
Compare
Ready? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, @liwenhui-soul please confirm if this PR satisfy.
yeah |
3b1cad2
to
232e810
Compare
926aa49
to
8ca6583
Compare
Codecov Report
@@ Coverage Diff @@
## master #4104 +/- ##
==========================================
- Coverage 85.10% 85.08% -0.02%
==========================================
Files 1339 1324 -15
Lines 132245 131714 -531
==========================================
- Hits 112544 112066 -478
+ Misses 19701 19648 -53
Continue to review full report at Codecov.
|
fe9d964
to
1228f9b
Compare
So complicated ... I'm confusing ... Several question, majorly related to RECOVER:
|
5c228f3
to
de4056f
Compare
|
cb5aad8
to
a9ab055
Compare
Yeah, some of the recovered jobs actually failed, this does not make sense. I mean we could restrict only recover one job is allowed later if necessary, we could simplify the code, and user won't be confused. BTW, if we are recovering one job, and recover failed, what message do we get from console? "Recovered job failed"? |
|
* If there are failed or stopped data balance or zone balance job, must firstly recover it * address wenhaocs's comments * address comments * add more comments * recover job * add more ut * adjust comment format * adjust comment format * adjust comment format
* fix apply outdate membership change (#4107) * fix apply outdate membership change * fix transfer leader to '':0 cause crash Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * add code for part peers backward compatible (#4101) * add code for part peers backward compatible * add balance keys * fix bug: pass tests * add gflag && ignore * change int to int64_t * chage to emplace Co-authored-by: panda-sheep <59197347+panda-sheep@users.noreply.github.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fixed (#4116) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * move KW_CLEAR to unresolved keyword (#4118) * Limits for add and recover balance data or zone balance jobs (#4104) * If there are failed or stopped data balance or zone balance job, must firstly recover it * address wenhaocs's comments * address comments * add more comments * recover job * add more ut * adjust comment format * adjust comment format * adjust comment format Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: pengwei.song <90180021+pengweisong@users.noreply.github.com> Co-authored-by: panda-sheep <59197347+panda-sheep@users.noreply.github.com> Co-authored-by: haifei.zhao <32253291+zhaohaifei@users.noreply.github.com>
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: