add code for part peers backward compatible #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good~ |
panda-sheep
reviewed
Apr 1, 2022
critical27
reviewed
Apr 2, 2022
Codecov Report
@@ Coverage Diff @@
## master #4101 +/- ##
==========================================
+ Coverage 85.03% 85.07% +0.04%
==========================================
Files 1328 1324 -4
Lines 131649 131753 +104
==========================================
+ Hits 111950 112092 +142
+ Misses 19699 19661 -38
Continue to review full report at Codecov.
|
liwenhui-soul
approved these changes
Apr 6, 2022
Sophie-Xie
added a commit
that referenced
this pull request
Apr 7, 2022
* add code for part peers backward compatible * add balance keys * fix bug: pass tests * add gflag && ignore * change int to int64_t * chage to emplace Co-authored-by: panda-sheep <59197347+panda-sheep@users.noreply.github.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
yixinglu
pushed a commit
that referenced
this pull request
Apr 7, 2022
* fix apply outdate membership change (#4107) * fix apply outdate membership change * fix transfer leader to '':0 cause crash Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * add code for part peers backward compatible (#4101) * add code for part peers backward compatible * add balance keys * fix bug: pass tests * add gflag && ignore * change int to int64_t * chage to emplace Co-authored-by: panda-sheep <59197347+panda-sheep@users.noreply.github.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fixed (#4116) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * move KW_CLEAR to unresolved keyword (#4118) * Limits for add and recover balance data or zone balance jobs (#4104) * If there are failed or stopped data balance or zone balance job, must firstly recover it * address wenhaocs's comments * address comments * add more comments * recover job * add more ut * adjust comment format * adjust comment format * adjust comment format Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: pengwei.song <90180021+pengweisong@users.noreply.github.com> Co-authored-by: panda-sheep <59197347+panda-sheep@users.noreply.github.com> Co-authored-by: haifei.zhao <32253291+zhaohaifei@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
When persist peers info in the storage, we should remember to fill the data which upgrade from the old version.
How do you solve it?
Move the balance peer info to another system table: balance table.
When start the storaged, we should:
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: