Book cover extracting enhancements #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Book cover extracting enhancements
This is:
Related issue: #48
Description
BookCoverReaderhacks and heuristics have been removed.<meta name="cover" content="..." />element (this approach is used by most EPUB 2 books). If such element was not found, the implementation will try to find a<guide>/<reference type="cover" href="...">element whosehrefattribute points to a known image.PackageReaderwill try to read all known EPUB 2 and EPUB 3<metadata>/<meta>attributes, regardless of the actual version of the EPUB file (this was suggested in Fix PackageReader to pick up cover images as generated on Adobe Indesign #32).Testing steps
Try to open various EPUB 2 and EPUB 3 books in the WPF Demo app and make sure that their covers are being rendered properly.