Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix WpfDemo: image not displayed #36

Closed
wants to merge 5 commits into from
Closed

Conversation

pinkli
Copy link

@pinkli pinkli commented Nov 25, 2020

  1. fix WpfDemo: image not displayed;
  2. upgrade console app to .Net 5

@GihanSoft
Copy link

@pinkli Tanks. I just merged your PR to my own fork 😅.

@pinkli
Copy link
Author

pinkli commented Sep 22, 2021

@GihanSoft you're welcome.

@vers-one
Copy link
Owner

Sorry for a delayed response. Could you post a link to a EPUB file that reproduces this issue (assuming it's not under copyright restrictions)?

@pinkli
Copy link
Author

pinkli commented Feb 22, 2022

https://molaware.oss-cn-beijing.aliyuncs.com/photographer-book-test.epub see this epub, images will not show in html content pages.

@vers-one
Copy link
Owner

Thank you for providing a sample EPUB file. The change in the GetFullPath method looks good to me. If you extract it into a separate pull request, I will merge it right away.

As for the change in the OnStylesheetLoad method — I couldn't reproduce it with any of the EPUB files I have. All font-family CSS properties are handled properly for all the files I tested. Do you have a sample EPUB file that causes HtmlRenderer to throw an exception for a font-family property?

Still looking into the schema parsing changes.

@vers-one
Copy link
Owner

I will close and reopen this pull request to restart the build check.

@vers-one vers-one closed this Feb 24, 2022
@vers-one vers-one reopened this Feb 24, 2022
@vers-one
Copy link
Owner

GetFullPath change was implemented in 147c690 and the EPUB 3 cover support was added in this PR #49.

Thank you for your contribution!

@vers-one vers-one closed this Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants