Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable issue_path again #4118

Merged
merged 2 commits into from
Mar 8, 2023
Merged

disable issue_path again #4118

merged 2 commits into from
Mar 8, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 8, 2023

Description

Performance is just too bad

@sokra sokra requested a review from a team as a code owner March 8, 2023 00:51
@vercel
Copy link

vercel bot commented Mar 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-designsystem-docs 🔄 Building (Inspect) Mar 8, 2023 at 0:54AM (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Mar 8, 2023 at 0:54AM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:54AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:54AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:54AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:54AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:54AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:54AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:54AM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Mar 8, 2023 at 0:54AM (UTC)

@sokra sokra merged commit 24980ac into main Mar 8, 2023
@sokra sokra deleted the sokra/disable-issue-path branch March 8, 2023 01:18
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Benchmark for cd19385

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack SSR/1000 modules 10.09ms ± 0.03ms 9828.88µs ± 44.55µs -2.60% -1.11%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8962.73µs ± 40.41µs 8793.96µs ± 33.23µs -1.88% -0.24%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9801.98µs ± 47.31µs 9687.21µs ± 49.72µs -1.17%
bench_hmr_to_commit/Turbopack RCC/1000 modules 11.68ms ± 0.04ms 11.51ms ± 0.06ms -1.44%
bench_hmr_to_commit/Turbopack RSC/1000 modules 522.40ms ± 1.48ms 519.36ms ± 0.62ms -0.58%
bench_hmr_to_commit/Turbopack SSR/1000 modules 10.09ms ± 0.03ms 9828.88µs ± 44.55µs -2.60% -1.11%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8803.89µs ± 58.95µs 8686.71µs ± 43.59µs -1.33%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.80ms ± 0.89ms 10.48ms ± 0.09ms -11.18%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8962.73µs ± 40.41µs 8793.96µs ± 33.23µs -1.88% -0.24%
bench_hydration/Turbopack RCC/1000 modules 3680.48ms ± 7.40ms 3655.28ms ± 9.21ms -0.68%
bench_hydration/Turbopack RSC/1000 modules 3311.85ms ± 13.66ms 3326.88ms ± 13.25ms +0.45%
bench_hydration/Turbopack SSR/1000 modules 3404.37ms ± 9.56ms 3380.27ms ± 4.99ms -0.71%
bench_startup/Turbopack CSR/1000 modules 2638.58ms ± 8.07ms 2633.73ms ± 10.02ms -0.18%
bench_startup/Turbopack RCC/1000 modules 2169.17ms ± 2.13ms 2169.18ms ± 5.96ms +0.00%
bench_startup/Turbopack RSC/1000 modules 2104.64ms ± 5.30ms 2099.93ms ± 4.95ms -0.22%
bench_startup/Turbopack SSR/1000 modules 2077.68ms ± 2.78ms 2078.37ms ± 1.69ms +0.03%

@kdy1 kdy1 mentioned this pull request Mar 8, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Mar 8, 2023
@kdy1
Update turbopack to 230308.1 (#46909)
37b0349 
## Bugfixes

 - vercel/turborepo#3526
 - vercel/turborepo#4084
 - vercel/turborepo#4083
 - vercel/turborepo#4067
 - vercel/turborepo#3959
 - vercel/turborepo#4060
 - vercel/turborepo#4081
 - vercel/turborepo#4103
 - vercel/turborepo#4100
 - vercel/turborepo#4108
 - vercel/turborepo#4101
 - vercel/turborepo#4112
 - vercel/turborepo#3956
 - vercel/turborepo#4118
 - vercel/turborepo#4117

## Feature

 - vercel/turborepo#4058
  - vercel/turborepo#4013
  - vercel/turborepo#4005
  - vercel/turborepo#4001
  - vercel/turborepo#3839
  - vercel/turborepo#4017
  - vercel/turborepo#4086
  - vercel/turborepo#4067

## Performance

  - vercel/turborepo#4040
  - vercel/turborepo#4110

## Refactor

 - vercel/turborepo#4098
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@sokra
disable issue_path again (vercel/turborepo#4118)
24c5409 
### Description

Performance is just too bad
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@sokra
disable issue_path again (vercel/turborepo#4118)
c4b6440 
### Description

Performance is just too bad
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
disable issue_path again (vercel/turborepo#4118)
7d41bc2 
### Description

Performance is just too bad
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
disable issue_path again (vercel/turborepo#4118)
5cdc873 
### Description

Performance is just too bad
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
disable issue_path again (vercel/turborepo#4118)
baba144 
### Description

Performance is just too bad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @jridgewell