Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

place all pages in the same intermediate output directory #4081

Merged
merged 2 commits into from
Mar 7, 2023
Merged

place all pages in the same intermediate output directory #4081

merged 2 commits into from
Mar 7, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 6, 2023

Description

The isolation is unnecessary and we can reuse files when we share directories

Testing Instructions

Open multiple pages without client-side navigation in multiple tabs concurrently.

@vercel
Copy link

vercel bot commented Mar 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-nonmonorepo 🔄 Building (Inspect) Mar 6, 2023 at 7:21PM (UTC)
examples-vite-web 🔄 Building (Inspect) Mar 6, 2023 at 7:21PM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Mar 6, 2023 at 7:21PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Mar 6, 2023 at 7:21PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 6, 2023 at 7:21PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 6, 2023 at 7:21PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Mar 6, 2023 at 7:21PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Mar 6, 2023 at 7:21PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 6, 2023 at 7:21PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2023 at 7:21PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Benchmark for b7d23ec

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9098.38µs ± 45.78µs 8937.27µs ± 94.52µs -1.77%
bench_hmr_to_commit/Turbopack RCC/1000 modules 13.06ms ± 0.12ms 13.70ms ± 0.70ms +4.85%
bench_hmr_to_commit/Turbopack RSC/1000 modules 499.04ms ± 2.63ms 503.27ms ± 2.59ms +0.85%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9281.90µs ± 43.80µs 9295.91µs ± 67.44µs +0.15%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8029.63µs ± 58.91µs 8073.89µs ± 19.45µs +0.55%
bench_hmr_to_eval/Turbopack RCC/1000 modules 12.14ms ± 0.15ms 12.14ms ± 0.23ms +0.05%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8246.09µs ± 58.53µs 8229.05µs ± 40.51µs -0.21%
bench_hydration/Turbopack RCC/1000 modules 3587.94ms ± 13.67ms 3614.79ms ± 7.25ms +0.75%
bench_hydration/Turbopack RSC/1000 modules 3207.58ms ± 10.51ms 3193.64ms ± 6.44ms -0.43%
bench_hydration/Turbopack SSR/1000 modules 3258.70ms ± 6.86ms 3261.06ms ± 11.39ms +0.07%
bench_startup/Turbopack CSR/1000 modules 2587.85ms ± 11.04ms 2545.77ms ± 11.63ms -1.63%
bench_startup/Turbopack RCC/1000 modules 2136.66ms ± 9.53ms 2122.01ms ± 7.35ms -0.69%
bench_startup/Turbopack RSC/1000 modules 2054.72ms ± 8.18ms 2069.98ms ± 13.10ms +0.74%
bench_startup/Turbopack SSR/1000 modules 2048.35ms ± 8.03ms 2026.97ms ± 6.82ms -1.04%

@sokra sokra marked this pull request as ready for review March 6, 2023 19:20
@sokra sokra requested a review from a team as a code owner March 6, 2023 19:20
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Benchmark for bbc638b

Test Base PR % Significant %
bench_hydration/Turbopack RCC/1000 modules 3536.32ms ± 5.54ms 3573.12ms ± 9.22ms +1.04% +0.21%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8603.62µs ± 46.63µs 8576.17µs ± 28.38µs -0.32%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.99ms ± 0.14ms 13.54ms ± 0.51ms +4.21%
bench_hmr_to_commit/Turbopack RSC/1000 modules 499.77ms ± 0.86ms 498.43ms ± 1.28ms -0.27%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8869.18µs ± 58.24µs 8895.14µs ± 61.55µs +0.29%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7672.69µs ± 14.74µs 7634.69µs ± 48.33µs -0.50%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.57ms ± 0.24ms 11.48ms ± 0.13ms -0.80%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7922.97µs ± 28.22µs 7968.75µs ± 42.78µs +0.58%
bench_hydration/Turbopack RCC/1000 modules 3536.32ms ± 5.54ms 3573.12ms ± 9.22ms +1.04% +0.21%
bench_hydration/Turbopack RSC/1000 modules 3196.46ms ± 8.41ms 3190.83ms ± 13.91ms -0.18%
bench_hydration/Turbopack SSR/1000 modules 3269.22ms ± 4.99ms 3255.99ms ± 4.04ms -0.40%
bench_startup/Turbopack CSR/1000 modules 2544.17ms ± 5.19ms 2544.63ms ± 7.76ms +0.02%
bench_startup/Turbopack RCC/1000 modules 2110.08ms ± 4.06ms 2114.99ms ± 2.41ms +0.23%
bench_startup/Turbopack RSC/1000 modules 2043.79ms ± 4.56ms 2053.14ms ± 4.01ms +0.46%
bench_startup/Turbopack SSR/1000 modules 2022.41ms ± 3.45ms 2018.16ms ± 2.05ms -0.21%

@sokra sokra marked this pull request as draft March 6, 2023 23:58
@sokra
Copy link
Member Author

sokra commented Mar 7, 2023

Non-determinism in graph traversal need to be fixed first before merging that

@sokra sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Mar 7, 2023
@sokra sokra marked this pull request as ready for review March 7, 2023 16:16
@kodiakhq kodiakhq bot merged commit d00f334 into main Mar 7, 2023
@kodiakhq kodiakhq bot deleted the sokra/no-isolated-directories branch March 7, 2023 16:26
mehulkar pushed a commit that referenced this pull request Mar 7, 2023
@sokra @mehulkar
place all pages in the same intermediate output directory (#4081)
304c3c6 
### Description

The isolation is unnecessary and we can reuse files when we share
directories

### Testing Instructions

Open multiple pages without client-side navigation in multiple tabs
concurrently.
@kdy1 kdy1 mentioned this pull request Mar 8, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Mar 8, 2023
@kdy1
Update turbopack to 230308.1 (#46909)
37b0349 
## Bugfixes

 - vercel/turborepo#3526
 - vercel/turborepo#4084
 - vercel/turborepo#4083
 - vercel/turborepo#4067
 - vercel/turborepo#3959
 - vercel/turborepo#4060
 - vercel/turborepo#4081
 - vercel/turborepo#4103
 - vercel/turborepo#4100
 - vercel/turborepo#4108
 - vercel/turborepo#4101
 - vercel/turborepo#4112
 - vercel/turborepo#3956
 - vercel/turborepo#4118
 - vercel/turborepo#4117

## Feature

 - vercel/turborepo#4058
  - vercel/turborepo#4013
  - vercel/turborepo#4005
  - vercel/turborepo#4001
  - vercel/turborepo#3839
  - vercel/turborepo#4017
  - vercel/turborepo#4086
  - vercel/turborepo#4067

## Performance

  - vercel/turborepo#4040
  - vercel/turborepo#4110

## Refactor

 - vercel/turborepo#4098
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@sokra
place all pages in the same intermediate output directory (vercel/tur…
9df85d6 
…borepo#4081)

### Description

The isolation is unnecessary and we can reuse files when we share
directories

### Testing Instructions

Open multiple pages without client-side navigation in multiple tabs
concurrently.
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@sokra
place all pages in the same intermediate output directory (vercel/tur…
e015780 
…borepo#4081)

### Description

The isolation is unnecessary and we can reuse files when we share
directories

### Testing Instructions

Open multiple pages without client-side navigation in multiple tabs
concurrently.
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
place all pages in the same intermediate output directory (vercel/tur…
157414f 
…borepo#4081)

### Description

The isolation is unnecessary and we can reuse files when we share
directories

### Testing Instructions

Open multiple pages without client-side navigation in multiple tabs
concurrently.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
place all pages in the same intermediate output directory (vercel/tur…
ec77623 
…borepo#4081)

### Description

The isolation is unnecessary and we can reuse files when we share
directories

### Testing Instructions

Open multiple pages without client-side navigation in multiple tabs
concurrently.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
place all pages in the same intermediate output directory (vercel/tur…
0639f82 
…borepo#4081)

### Description

The isolation is unnecessary and we can reuse files when we share
directories

### Testing Instructions

Open multiple pages without client-side navigation in multiple tabs
concurrently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @jridgewell